Don't try to add an implicit undefined for mapped properties outside of `strictNullChecks` #60393

Andarist · 2024-11-02T10:04:33Z

fixes #60390
fixes #60511

…of `strictNullChecks`

src/compiler/expressionToTypeNode.ts

…ecks-crash-optional-undefined

jakebailey

This looks good to me, but will double check with a test run.

jakebailey · 2024-12-19T17:50:53Z

@typescript-bot test it

typescript-bot · 2024-12-19T17:50:57Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-19T18:11:43Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-19T18:12:15Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60393/merge:

Everything looks good!

typescript-bot · 2024-12-19T18:33:20Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,881k (± 1.04%)}	_{193,701k (± 0.77%)}	_~	_192,990k	_196,736k	_{p=0.298 n=6}
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.31s (± 1.40%)}	_~	_1.29s	_1.33s	_{p=0.868 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.79s (± 0.18%)}	_{9.79s (± 0.20%)}	_~	_9.77s	_9.82s	_{p=0.560 n=6}
_{Emit Time}	_{2.73s (± 0.43%)}	_{2.73s (± 0.50%)}	_~	_2.72s	_2.75s	_{p=0.933 n=6}
_{Total Time}	_{14.54s (± 0.15%)}	_{14.55s (± 0.16%)}	_~	_14.51s	_14.58s	_{p=0.464 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,805k (± 0.00%)}	_{1,225,791k (± 0.00%)}	_~	_1,225,741k	_1,225,850k	_{p=0.521 n=6}
_{Parse Time}	_{6.62s (± 0.87%)}	_{6.66s (± 0.62%)}	_~	_6.59s	_6.72s	_{p=0.376 n=6}
_{Bind Time}	_{1.88s (± 0.55%)}	_{1.89s (± 0.44%)}	_~	_1.87s	_1.89s	_{p=0.672 n=6}
_{Check Time}	_{31.97s (± 0.38%)}	_{31.96s (± 0.32%)}	_~	_31.84s	_32.11s	_{p=0.936 n=6}
_{Emit Time}	_{15.17s (± 0.30%)}	_{15.17s (± 0.30%)}	_~	_15.09s	_15.21s	_{p=0.872 n=6}
_{Total Time}	_{55.64s (± 0.28%)}	_{55.67s (± 0.24%)}	_~	_55.51s	_55.85s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,449,172	_2,449,172	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,410	_896,410	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,320,771k (± 0.00%)}	_{2,320,752k (± 0.00%)}	_~	_2,320,707k	_2,320,792k	_{p=0.575 n=6}
_{Parse Time}	_{9.42s (± 0.16%)}	_{9.43s (± 0.10%)}	_~	_9.42s	_9.44s	_{p=0.109 n=6}
_{Bind Time}	_{2.24s (± 0.44%)}	_{2.24s (± 0.34%)}	_~	_2.23s	_2.25s	_{p=0.858 n=6}
_{Check Time}	_{73.26s (± 0.18%)}	_{73.52s (± 0.23%)}	_{+0.26s (+ 0.35%)}	_73.24s	_73.70s	_{p=0.045 n=6}
_{Emit Time}	_{0.28s (± 4.82%)}	_{0.29s (± 4.83%)}	_~	_0.27s	_0.30s	_{p=0.933 n=6}
_{Total Time}	_{85.20s (± 0.15%)}	_{85.47s (± 0.20%)}	_{+0.27s (+ 0.32%)}	_85.19s	_85.67s	_{p=0.031 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,880	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,539,575k (±11.99%)}	_{2,539,188k (±11.97%)}	_~	_2,356,816k	_3,084,889k	_{p=0.471 n=6}
_{Parse Time}	_{5.27s (± 1.61%)}	_{5.28s (± 1.90%)}	_~	_5.17s	_5.45s	_{p=0.748 n=6}
_{Bind Time}	_{1.76s (± 1.11%)}	_{1.78s (± 0.69%)}	_~	_1.75s	_1.78s	_{p=0.301 n=6}
_{Check Time}	_{35.28s (± 0.98%)}	_{35.21s (± 0.73%)}	_~	_34.79s	_35.57s	_{p=0.471 n=6}
_{Emit Time}	_{2.99s (± 0.91%)}	_{3.01s (± 3.80%)}	_~	_2.93s	_3.24s	_{p=0.810 n=6}
_{Total Time}	_{45.31s (± 0.78%)}	_{45.28s (± 0.74%)}	_~	_44.84s	_45.80s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,880	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,032,661k (± 9.75%)}	_{2,911,954k (±12.84%)}	_~	_2,428,081k	_3,154,636k	_{p=0.689 n=6}
_{Parse Time}	_{6.97s (± 1.25%)}	_{6.93s (± 1.55%)}	_~	_6.76s	_7.02s	_{p=0.810 n=6}
_{Bind Time}	_{2.18s (± 1.68%)}	_{2.15s (± 1.87%)}	_~	_2.09s	_2.20s	_{p=0.423 n=6}
_{Check Time}	_{42.87s (± 0.36%)}	_{42.67s (± 0.57%)}	_~	_42.30s	_42.88s	_{p=0.128 n=6}
_{Emit Time}	_{3.46s (± 1.04%)}	_{3.46s (± 3.09%)}	_~	_3.33s	_3.61s	_{p=1.000 n=6}
_{Total Time}	_{55.47s (± 0.38%)}	_{55.23s (± 0.66%)}	_~	_54.66s	_55.53s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,439	_262,439	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,628	_106,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,204k (± 0.01%)}	_{440,187k (± 0.01%)}	_~	_440,157k	_440,227k	_{p=0.423 n=6}
_{Parse Time}	_{3.52s (± 0.86%)}	_{3.54s (± 0.65%)}	_~	_3.51s	_3.56s	_{p=0.169 n=6}
_{Bind Time}	_{1.31s (± 1.15%)}	_{1.31s (± 0.62%)}	_~	_1.30s	_1.32s	_{p=0.797 n=6}
_{Check Time}	_{18.92s (± 0.36%)}	_{18.89s (± 0.43%)}	_~	_18.75s	_18.99s	_{p=0.689 n=6}
_{Emit Time}	_{1.53s (± 1.13%)}	_{1.53s (± 0.53%)}	_~	_1.52s	_1.54s	_{p=1.000 n=6}
_{Total Time}	_{25.27s (± 0.28%)}	_{25.28s (± 0.33%)}	_~	_25.13s	_25.39s	_{p=0.872 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,587k (± 0.01%)}	_{371,623k (± 0.01%)}	_~	_371,567k	_371,685k	_{p=0.294 n=6}
_{Parse Time}	_{2.93s (± 1.00%)}	_{2.91s (± 0.85%)}	_~	_2.88s	_2.95s	_{p=0.227 n=6}
_{Bind Time}	_{1.59s (± 0.65%)}	_{1.58s (± 0.76%)}	_~	_1.57s	_1.60s	_{p=0.210 n=6}
_{Check Time}	_{16.53s (± 0.55%)}	_{16.51s (± 0.58%)}	_~	_16.38s	_16.61s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{21.05s (± 0.46%)}	_{21.00s (± 0.52%)}	_~	_20.85s	_21.12s	_{p=0.374 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,222,962	_3,222,962	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,108,699	_1,108,699	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,289,084k (± 0.01%)}	_{3,288,952k (± 0.01%)}	_~	_3,288,558k	_3,289,378k	_{p=0.575 n=6}
_{Parse Time}	_{14.18s (± 0.49%)}	_{14.20s (± 1.09%)}	_~	_14.03s	_14.49s	_{p=0.936 n=6}
_{Bind Time}	_{4.54s (± 0.67%)}	_{4.53s (± 0.59%)}	_~	_4.48s	_4.55s	_{p=0.222 n=6}
_{Check Time}	_{89.77s (± 3.86%)}	_{88.32s (± 3.18%)}	_~	_86.82s	_94.03s	_{p=0.689 n=6}
_{Emit Time}	_{27.77s (± 1.82%)}	_{28.07s (± 3.41%)}	_~	_27.19s	_29.34s	_{p=0.936 n=6}
_{Total Time}	_{136.26s (± 2.77%)}	_{135.13s (± 1.91%)}	_~	_132.81s	_139.94s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,562	_291,562	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,349k (± 0.02%)}	_{445,364k (± 0.04%)}	_~	_445,147k	_445,498k	_{p=0.630 n=6}
_{Parse Time}	_{4.11s (± 0.65%)}	_{4.08s (± 1.07%)}	_~	_4.03s	_4.13s	_{p=0.517 n=6}
_{Bind Time}	_{1.77s (± 0.80%)}	_{1.77s (± 1.45%)}	_~	_1.75s	_1.82s	_{p=1.000 n=6}
_{Check Time}	_{18.73s (± 0.41%)}	_{18.76s (± 0.47%)}	_~	_18.64s	_18.88s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.60s (± 0.35%)}	_{24.62s (± 0.48%)}	_~	_24.45s	_24.76s	_{p=0.873 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,233	_552,233	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,971	_184,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,399k (± 0.01%)}	_{492,401k (± 0.01%)}	_~	_492,300k	_492,471k	_{p=0.936 n=6}
_{Parse Time}	_{4.26s (± 0.48%)}	_{4.26s (± 0.46%)}	_~	_4.23s	_4.28s	_{p=0.677 n=6}
_{Bind Time}	_{1.47s (± 0.93%)}	_{1.45s (± 0.91%)}	_~	_1.43s	_1.47s	_{p=0.111 n=6}
_{Check Time}	_{24.11s (± 0.26%)}	_{24.11s (± 0.37%)}	_~	_23.98s	_24.23s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.84s (± 0.25%)}	_{29.82s (± 0.26%)}	_~	_29.72s	_29.94s	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-12-19T19:21:40Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60393/merge:

Everything looks good!

jakebailey · 2024-12-19T19:47:37Z

@typescript-bot cherry-pick this to release-5.7

typescript-bot · 2024-12-19T19:47:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	✅ Results

…of `strictNullChecks` (#60393)

typescript-bot · 2024-12-19T19:49:14Z

Hey, @jakebailey! I've created #60825 for you.

…e-5.7 (#60825) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Don't try to add an implicit undefined for mapped properties outside …

b2f4fc4

…of `strictNullChecks`

typescript-bot assigned weswigham Nov 2, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Nov 2, 2024

jakebailey reviewed Nov 2, 2024

View reviewed changes

src/compiler/expressionToTypeNode.ts Outdated Show resolved Hide resolved

Andarist added 2 commits December 5, 2024 11:14

Merge remote-tracking branch 'origin/main' into fix/no-strict-null-ch…

93e81c4

…ecks-crash-optional-undefined

add extra test case

76c3879

Andarist requested a review from jakebailey December 5, 2024 10:17

Andarist added 2 commits December 19, 2024 18:43

Merge remote-tracking branch 'origin/main' into fix/no-strict-null-ch…

07cda04

…ecks-crash-optional-undefined

tweak fix

170d9fd

Andarist force-pushed the fix/no-strict-null-checks-crash-optional-undefined branch from a35d99b to 170d9fd Compare December 19, 2024 17:50

jakebailey approved these changes Dec 19, 2024

View reviewed changes

jakebailey merged commit 12e205b into microsoft:main Dec 19, 2024
32 checks passed

typescript-bot pushed a commit that referenced this pull request Dec 19, 2024

Don't try to add an implicit undefined for mapped properties outside …

520300d

…of `strictNullChecks` (#60393)

typescript-bot mentioned this pull request Dec 19, 2024

🤖 Pick PR #60393 (Don't try to add an implicit undefi...) into release-5.7 #60825

Merged

DanielRosenwasser pushed a commit that referenced this pull request Dec 19, 2024

🤖 Pick PR #60393 (Don't try to add an implicit undefi...) into releas…

7aa63df

…e-5.7 (#60825) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't try to add an implicit undefined for mapped properties outside of `strictNullChecks` #60393

Don't try to add an implicit undefined for mapped properties outside of `strictNullChecks` #60393

Andarist commented Nov 2, 2024 •

edited

Loading

jakebailey left a comment

jakebailey commented Dec 19, 2024

typescript-bot commented Dec 19, 2024 •

edited

Loading

typescript-bot commented Dec 19, 2024

typescript-bot commented Dec 19, 2024

typescript-bot commented Dec 19, 2024

tsc

typescript-bot commented Dec 19, 2024

jakebailey commented Dec 19, 2024

typescript-bot commented Dec 19, 2024 •

edited

Loading

typescript-bot commented Dec 19, 2024

Don't try to add an implicit undefined for mapped properties outside of strictNullChecks #60393

Don't try to add an implicit undefined for mapped properties outside of strictNullChecks #60393

Conversation

Andarist commented Nov 2, 2024 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

jakebailey commented Dec 19, 2024

typescript-bot commented Dec 19, 2024 • edited Loading

typescript-bot commented Dec 19, 2024

typescript-bot commented Dec 19, 2024

typescript-bot commented Dec 19, 2024

tsc

typescript-bot commented Dec 19, 2024

jakebailey commented Dec 19, 2024

typescript-bot commented Dec 19, 2024 • edited Loading

typescript-bot commented Dec 19, 2024

Don't try to add an implicit undefined for mapped properties outside of `strictNullChecks` #60393

Don't try to add an implicit undefined for mapped properties outside of `strictNullChecks` #60393

Andarist commented Nov 2, 2024 •

edited

Loading

typescript-bot commented Dec 19, 2024 •

edited

Loading

typescript-bot commented Dec 19, 2024 •

edited

Loading