Limit error reporting for methods to the method name #5972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @reavowed, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -11175,7 +11175,7 @@ namespace ts { | |||
| // Abstract methods cannot have an implementation. | |||
| // Extra checks are to avoid reporting multiple errors relating to the "abstractness" of the node. | |||
| if (node.flags & NodeFlags.Abstract && node.body) { | |||
| error(node, Diagnostics.Method_0_cannot_have_an_implementation_because_it_is_marked_abstract, declarationNameToString(node.name)); | |||
| error(node.body, Diagnostics.Method_0_cannot_have_an_implementation_because_it_is_marked_abstract, declarationNameToString(node.name)); | |||
There was a problem hiding this comment.
that is not much better than just node, the body could be a whole file. with the other change, the new range will be just the name, which is a better fit.
There was a problem hiding this comment.
Yes, just keep it as node
|
thanks @reavowed, i have one comment, other than that looks good to me. |
DanielRosenwasser
added a commit
that referenced
this pull request
Dec 10, 2015
Limit error reporting for methods to the method name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5732