Do not get awaited type of AsyncGenerator TNext #59644

rbuckton · 2024-08-15T16:59:53Z

We are incorrectly calling getAwaitedType on the TNext type of an async generator, despite the fact that the spec does not perform an Await.

Our runtime emit looks to be correct, only checker appears to be wrong here.

Fixes #44808

jakebailey · 2024-08-15T17:17:33Z

@typescript-bot test it

typescript-bot · 2024-08-15T17:17:37Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-15T17:49:13Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59644/merge:

Everything looks good!

typescript-bot · 2024-08-15T17:50:20Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-15T17:55:53Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,615k (± 0.89%)}	_{193,006k (± 0.76%)}	_~	_192,296k	_195,996k	_{p=0.471 n=6}
_{Parse Time}	_{1.58s (± 0.52%)}	_{1.57s (± 0.57%)}	_~	_1.56s	_1.58s	_{p=0.176 n=6}
_{Bind Time}	_{0.85s (± 1.21%)}	_{0.85s (± 1.42%)}	_~	_0.84s	_0.87s	_{p=1.000 n=6}
_{Check Time}	_{11.35s (± 0.43%)}	_{11.35s (± 0.48%)}	_~	_11.27s	_11.43s	_{p=0.936 n=6}
_{Emit Time}	_{3.23s (± 0.38%)}	_{3.24s (± 0.61%)}	_~	_3.22s	_3.26s	_{p=0.300 n=6}
_{Total Time}	_{17.01s (± 0.20%)}	_{17.02s (± 0.41%)}	_~	_16.92s	_17.10s	_{p=0.808 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,530k (± 0.00%)}	_{1,222,501k (± 0.00%)}	_~	_1,222,429k	_1,222,562k	_{p=0.521 n=6}
_{Parse Time}	_{7.94s (± 0.47%)}	_{7.93s (± 0.60%)}	_~	_7.89s	_8.02s	_{p=0.464 n=6}
_{Bind Time}	_{2.23s (± 0.74%)}	_{2.23s (± 0.28%)}	_~	_2.22s	_2.24s	_{p=0.931 n=6}
_{Check Time}	_{36.32s (± 0.34%)}	_{36.21s (± 0.27%)}	_~	_36.11s	_36.34s	_{p=0.128 n=6}
_{Emit Time}	_{17.81s (± 0.21%)}	_{17.79s (± 0.16%)}	_~	_17.76s	_17.83s	_{p=0.375 n=6}
_{Total Time}	_{64.29s (± 0.23%)}	_{64.16s (± 0.19%)}	_~	_64.07s	_64.40s	_{p=0.054 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,491,254	_2,491,254	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,006,231	_1,006,231	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,365,298k (± 0.00%)}	_{2,365,257k (± 0.00%)}	_~	_2,365,219k	_2,365,290k	_{p=0.521 n=6}
_{Parse Time}	_{9.23s (± 0.32%)}	_{9.24s (± 0.49%)}	_~	_9.19s	_9.30s	_{p=0.747 n=6}
_{Bind Time}	_{2.17s (± 0.38%)}	_{2.18s (± 0.63%)}	_~	_2.15s	_2.19s	_{p=0.325 n=6}
_{Check Time}	_{74.70s (± 0.37%)}	_{74.71s (± 0.28%)}	_~	_74.49s	_74.97s	_{p=0.936 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 2.26%)}	_~	_0.27s	_0.29s	_{p=0.673 n=6}
_{Total Time}	_{86.39s (± 0.33%)}	_{86.42s (± 0.27%)}	_~	_86.14s	_86.69s	_{p=0.873 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,261	_1,231,260	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,287	_264,287	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,352,831k (± 0.04%)}	_{2,471,231k (±11.75%)}	_~	_2,351,941k	_3,064,592k	_{p=0.936 n=6}
_{Parse Time}	_{5.01s (± 0.69%)}	_{4.96s (± 1.25%)}	_~	_4.88s	_5.05s	_{p=0.173 n=6}
_{Bind Time}	_{1.89s (± 0.64%)}	_{1.89s (± 0.73%)}	_~	_1.87s	_1.90s	_{p=0.300 n=6}
_{Check Time}	_{34.73s (± 0.15%)}	_{34.71s (± 0.40%)}	_~	_34.51s	_34.87s	_{p=1.000 n=6}
_{Emit Time}	_{3.31s (± 1.30%)}	_{3.31s (± 0.62%)}	_~	_3.28s	_3.33s	_{p=0.871 n=6}
_{Total Time}	_{44.95s (± 0.08%)}	_{44.88s (± 0.37%)}	_~	_44.60s	_45.08s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,261	_1,231,260	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,287	_264,287	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,426,580k (± 0.01%)}	_{2,427,148k (± 0.02%)}	_{+568k (+ 0.02%)}	_2,426,695k	_2,427,766k	_{p=0.045 n=6}
_{Parse Time}	_{7.71s (± 0.56%)}	_{7.72s (± 0.68%)}	_~	_7.68s	_7.80s	_{p=0.810 n=6}
_{Bind Time}	_{2.50s (± 0.94%)}	_{2.51s (± 1.30%)}	_~	_2.47s	_2.56s	_{p=0.419 n=6}
_{Check Time}	_{51.63s (± 0.57%)}	_{51.54s (± 0.26%)}	_~	_51.34s	_51.69s	_{p=0.936 n=6}
_{Emit Time}	_{5.05s (± 1.19%)}	_{5.02s (± 0.82%)}	_~	_4.99s	_5.09s	_{p=0.377 n=6}
_{Total Time}	_{66.91s (± 0.49%)}	_{66.83s (± 0.23%)}	_~	_66.64s	_67.04s	_{p=0.873 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,902	_256,901	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,594	_105,594	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,189k (± 0.01%)}	_{429,295k (± 0.02%)}	_{+106k (+ 0.02%)}	_429,191k	_429,378k	_{p=0.031 n=6}
_{Parse Time}	_{2.79s (± 0.77%)}	_{2.78s (± 0.27%)}	_~	_2.77s	_2.79s	_{p=0.805 n=6}
_{Bind Time}	_{1.09s (± 1.38%)}	_{1.08s (± 1.36%)}	_~	_1.07s	_1.10s	_{p=0.203 n=6}
_{Check Time}	_{15.32s (± 0.31%)}	_{15.36s (± 0.20%)}	_~	_15.31s	_15.40s	_{p=0.127 n=6}
_{Emit Time}	_{1.40s (± 1.16%)}	_{1.39s (± 0.84%)}	_~	_1.38s	_1.41s	_{p=0.221 n=6}
_{Total Time}	_{20.61s (± 0.29%)}	_{20.61s (± 0.19%)}	_~	_20.54s	_20.65s	_{p=0.871 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,153k (± 0.01%)}	_{370,128k (± 0.02%)}	_~	_370,066k	_370,240k	_{p=0.229 n=6}
_{Parse Time}	_{2.29s (± 0.62%)}	_{2.29s (± 0.58%)}	_~	_2.28s	_2.31s	_{p=0.802 n=6}
_{Bind Time}	_{1.33s (± 2.05%)}	_{1.32s (± 1.24%)}	_~	_1.31s	_1.35s	_{p=0.178 n=6}
_{Check Time}	_{13.36s (± 0.30%)}	_{13.32s (± 0.18%)}	_~	_13.29s	_13.36s	_{p=0.146 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.99s (± 0.26%)}	_{16.93s (± 0.21%)}	_~	_16.89s	_16.99s	_{p=0.064 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,004,214	_3,004,214	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,034,825	_1,034,825	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,128,221k (± 0.00%)}	_{3,128,160k (± 0.00%)}	_~	_3,128,077k	_3,128,252k	_{p=0.173 n=6}
_{Parse Time}	_{14.00s (± 0.40%)}	_{13.96s (± 0.31%)}	_~	_13.90s	_14.03s	_{p=0.171 n=6}
_{Bind Time}	_{4.33s (± 2.18%)}	_{4.29s (± 0.41%)}	_~	_4.26s	_4.30s	_{p=0.565 n=6}
_{Check Time}	_{79.79s (± 0.34%)}	_{79.83s (± 0.29%)}	_~	_79.58s	_80.15s	_{p=0.689 n=6}
_{Emit Time}	_{20.54s (± 0.14%)}	_{20.50s (± 0.28%)}	_~	_20.43s	_20.60s	_{p=0.172 n=6}
_{Total Time}	_{118.67s (± 0.26%)}	_{118.58s (± 0.19%)}	_~	_118.23s	_118.86s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_275,352	_275,352	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,436	_112,436	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,253k (± 0.02%)}	_{424,234k (± 0.02%)}	_~	_424,166k	_424,378k	_{p=0.575 n=6}
_{Parse Time}	_{4.90s (± 0.15%)}	_{4.91s (± 0.48%)}	_~	_4.88s	_4.94s	_{p=0.318 n=6}
_{Bind Time}	_{2.14s (± 1.01%)}	_{2.12s (± 1.12%)}	_~	_2.09s	_2.15s	_{p=0.255 n=6}
_{Check Time}	_{21.60s (± 0.55%)}	_{21.67s (± 0.22%)}	_~	_21.61s	_21.75s	_{p=0.297 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{28.64s (± 0.46%)}	_{28.70s (± 0.20%)}	_~	_28.61s	_28.79s	_{p=0.375 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_534,188	_534,188	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,207	_176,207	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{479,265k (± 0.00%)}	_{479,269k (± 0.01%)}	_~	_479,201k	_479,306k	_{p=0.748 n=6}
_{Parse Time}	_{3.39s (± 0.89%)}	_{3.40s (± 0.45%)}	_~	_3.37s	_3.41s	_{p=0.805 n=6}
_{Bind Time}	_{1.24s (± 1.10%)}	_{1.25s (± 0.94%)}	_~	_1.23s	_1.26s	_{p=0.563 n=6}
_{Check Time}	_{17.93s (± 0.24%)}	_{17.93s (± 0.30%)}	_~	_17.87s	_18.01s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.57s (± 0.20%)}	_{22.58s (± 0.31%)}	_~	_22.49s	_22.66s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-15T18:55:05Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59644/merge:

Everything looks good!

gabritto · 2024-08-15T19:19:27Z

@typescript-bot pack this

typescript-bot · 2024-08-15T19:19:31Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-08-15T19:21:12Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163306/artifacts?artifactName=tgz&fileId=5A45468CEA7B378F428B4B3D354225573933893DA9D375F0DC45A2721566B93502&fileName=/typescript-5.6.0-insiders.20240815.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59644-8".;

gabritto

Might be good to add a test case for when the async generator return type is inferred, but looks good to me.

Do not get awaited type of AsyncGenerator TNext

32ed8e9

rbuckton requested review from andrewbranch and gabritto August 15, 2024 16:59

typescript-bot assigned rbuckton Aug 15, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 15, 2024

gabritto approved these changes Aug 15, 2024

View reviewed changes

Add test for inferred return type

18af23f

rbuckton merged commit 09a8522 into main Aug 16, 2024
32 checks passed

rbuckton deleted the fix44808 branch August 16, 2024 15:55

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not get awaited type of AsyncGenerator TNext #59644

Do not get awaited type of AsyncGenerator TNext #59644

Uh oh!

rbuckton commented Aug 15, 2024

Uh oh!

jakebailey commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024

tsc

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

gabritto commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

gabritto left a comment

Uh oh!

Uh oh!

Uh oh!

Do not get awaited type of AsyncGenerator TNext #59644

Do not get awaited type of AsyncGenerator TNext #59644

Uh oh!

Conversation

rbuckton commented Aug 15, 2024

Uh oh!

jakebailey commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024

tsc

Uh oh!

typescript-bot commented Aug 15, 2024

Uh oh!

gabritto commented Aug 15, 2024

Uh oh!

typescript-bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Aug 15, 2024 •

edited

Loading

typescript-bot commented Aug 15, 2024 •

edited

Loading

typescript-bot commented Aug 15, 2024 •

edited

Loading