Always error on overshifts #59520
Closed
Always error on overshifts #59520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot user test this |
|
@weswigham Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
Hm, unsure if those are legitimate errors in webpack or funky
AssemblyScript-isms that hint how to handle the numbers to the
runtime/compiler.
…On Fri, Aug 2, 2024, 1:57 PM TypeScript Bot ***@***.***> wrote:
@weswigham <https://github.com/weswigham> Here are the results of running
the user tests with tsc comparing main and refs/pull/59520/merge:
Something interesting changed - please have a look.
Details webpack <https://github.com/webpack/webpack.git>
assembly/tsconfig.json
<https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/tsconfig.json>
- [NEW] error TS6807: This operation can be simplified. This shift is
identical to result >> 1.
- assembly/hash/xxhash64.asm.ts#L105
<https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L105>
- [NEW] error TS6807: This operation can be simplified. This shift is
identical to result >> 0.
- assembly/hash/xxhash64.asm.ts#L109
<https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L109>
- assembly/hash/xxhash64.asm.ts#L111
<https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L111>
- [NEW] error TS6807: This operation can be simplified. This shift is
identical to (x & 0xffff) << 0.
- assembly/hash/xxhash64.asm.ts#L118
<https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L118>
—
Reply to this email directly, view it on GitHub
<#59520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWMAMQZ7QREW6DLQZE2RITZPPXERAVCNFSM6AAAAABL5FT6YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWGEZTMNJRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Seems idiomatic in asm? It's declared let result: u64;so presumably you can 32-shift it |
|
@weswigham Here are the results of running the top 600 repos with tsc comparing Everything looks good! |
|
Well, not breaking AssemblyScript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see if making it always an error instead of a suggestion is viable.