Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local symbol rather then target symbol for tracking reused references #59493

Merged

Conversation

weswigham
Copy link
Member

Fixes #59470

When we started reusing the node from the target file (since it refers to the same thing as the local name), we accidentally stopped marking the local reference to that thing as used for the output. By swapping which symbol we track to the local version, we ensure we track the references we need to keep in the output.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 31, 2024
@weswigham weswigham changed the title Add missinging reverse lookup type Use local symbol rather then target symbol for tracking reused references Jul 31, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, nice; theoretically I think we want this for another 5.5 patch if we're doing one.

@weswigham weswigham merged commit 41b993b into microsoft:main Jul 31, 2024
32 checks passed
@weswigham weswigham deleted the add-missinging-reverse-lookup-type branch July 31, 2024 22:52
@jakebailey
Copy link
Member

@typescript-bot cherry-pick this to release-5.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 1, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.5 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @jakebailey! I've created #59502 for you.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 1, 2024

Was the original issue actually a 5.5 regression?

@RyanCavanaugh
Copy link
Member

Yes, the regressing PR was #57887

DanielRosenwasser pushed a commit that referenced this pull request Aug 8, 2024
…e-5.5 (#59502)

Co-authored-by: Wesley Wigham <wewigham@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Namespace missing in generated .d.ts
5 participants