Fix: tsc -w is losing working directory in macOS Terminal #59315
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Jul 17, 2024
| @@ -1604,7 +1604,11 @@ export let sys: System = (() => { | |||
| setTimeout, | |||
| clearTimeout, | |||
| clearScreen: () => { | |||
| process.stdout.write("\x1Bc"); | |||
| process.stdout.write( | |||
| platform === "win32" | |||
There was a problem hiding this comment.
Like #57701 this will be a behavior change; we'll have to check to see how it behaves and make sure we're okay with the change.
jakebailey
requested changes
Jul 22, 2024
There was a problem hiding this comment.
I posted a big list of tests on #57701 (comment); I believe that other PR to be better (but both fix your issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57894.
See this comment for the detailed explanation of the fix.
The escape sequences are taken from Jest that doesn't have the same issue.