Fixed crash on authored import type nodes when serializing for declarations #59160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Jul 6, 2024
| const firstIdentifier = getFirstIdentifier(node.qualifier); | ||
| const name = getNameForExportedSymbol(firstIdentifier.symbol, scriptTarget); | ||
| const qualifier = name !== firstIdentifier.text | ||
| if (!firstIdentifier.symbol) { |
There was a problem hiding this comment.
Value-space identifiers get their .symbol in the binder but type-level identifiers in import type nodes don't.
Alternatively, this could be fixed in visitExistingNodeTreeSymbolsWorker but it's more tricky there.
Andarist
commented
Jul 6, 2024
| includes: [ | ||
| { | ||
| name: "method", | ||
| insertText: `method(param: import("./doesntexist.js").Foo);`, |
There was a problem hiding this comment.
This is weird but not anything new. Return types nodes with errors are omitted based on NodeBuilderFlags.SuppressAnyReturnType. No mechanism like this for parameters is used.
andrewbranch
approved these changes
Jul 10, 2024
|
@typescript-bot cherry-pick to release-5.5 |
|
Hey, @andrewbranch! I've created #59226 for you. |
typescript-bot
added
For Milestone Bug
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jul 17, 2024
…e-5.5 (#59226) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #59159