Send updated sourceFile to getLiteralText #59141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59085 (comment)
When the node's sourceFile is not the same as the
currentSourceFile
the method returns an incorrect position. In example, in the code below, the position will hit the comment text infoo.ts
instead ofbar.ts
.Note that I unsuccessfully tried creating the repro as a fourslash test but for some reason the completions api treats the whole thing as a single file avoiding the issue. Also, I don't know how to avoid the test that changed.