Skip to content

fix(58772): Duplicate exports.* = assignments in CommonJS output in some cases #59120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(58772): Duplicate exports.* = assignments in CommonJS output in some cases #59120

merged 1 commit into from
Jul 22, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #58772

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 2, 2024
jakebailey
jakebailey approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is right, especially given exportedBindings also works in terms of original nodes.

@jakebailey jakebailey requested a review from rbuckton July 8, 2024 20:41
@jakebailey jakebailey merged commit 8a0e47e into microsoft:main Jul 22, 2024
29 checks passed
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@rbuckton rbuckton

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate exports.* = assignments in CommonJS output in some cases
4 participants
@a-tarasyuk @jakebailey @rbuckton @typescript-bot