Skip to content

Conversation

@sparecycles
Copy link
Contributor

@sparecycles
Copy link
Contributor Author

Tried running jake lib in the #5461 commit, didn't work then either 😉

CONTRIBUTING.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it is lib that builds the library files.

jake lib -> src\lib\*.d.ts combine them into built\local\lib.*.d.ts
jake LKG -> jake local with debug=false, copy built\local\* to lib\* in preparation of publishing an npm

so files in \lib\ should not be touched by hand, only through jake LKG

@mhegazy
Copy link
Contributor

mhegazy commented Dec 3, 2015

Tried running jake lib in the #5461 commit, didn't work then either 😉

how is that? what did you see? any errors?

@sparecycles
Copy link
Contributor Author

You don't even need jake lib to update the built/local data, just running jake after changing src/lib files updates that fine (as I expect running jake with no arguments to do).

But, when I run jake lib I don't think it's out of scope to assume lib would be updated.

In the instructions: "To build the library files" obviously means the files in lib/ (except it doesn't). The README in lib/ says these files are not meant to be updated by hand, and changes should be made in src/ but nowhere is it documented that the command is jake LKG.

Can you not see how this is confusing?

@mhegazy
Copy link
Contributor

mhegazy commented Dec 3, 2015

i see. well in my defense, \lib was called \bin and that was less confusing..

Any how, so we can make it jake local or just 'jake`, how about that?

@sparecycles
Copy link
Contributor Author

(hmm... musing) perhaps /bootstrap ( or /bs ? ) would be a better name?

@mhegazy
Copy link
Contributor

mhegazy commented Dec 3, 2015

looks good. thanks!

mhegazy added a commit that referenced this pull request Dec 3, 2015
fix instructions for contributing to lib.d.ts
@mhegazy mhegazy merged commit 3edc9c9 into microsoft:master Dec 3, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants