-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing namespace import debug failure #59004
Open
navya9singh
wants to merge
17
commits into
microsoft:main
Choose a base branch
from
navya9singh:errorForNamespaceImport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,622
−7
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e31bb29
Fixes namespace debug failure but test 2 fails
navya9singh c4d86b8
fixing test 2
navya9singh 1347b9f
fixing formatting
navya9singh 45af3f0
fixing baselines
navya9singh 9e4a30a
Merge branch 'main' of https://github.com/microsoft/TypeScript into e…
navya9singh e35b0f7
Adding more fixes and tests
navya9singh c0aaae4
Removing previous changes
navya9singh dc452e8
deleting old baselines
navya9singh d47ff25
default import fixes
navya9singh ba4c3dd
fixing baselines
navya9singh fb453ee
changing baselines
navya9singh ba364e8
Merge branch 'main' of https://github.com/microsoft/TypeScript into e…
navya9singh b21b4a1
fixing tests and baselines
navya9singh b23e6d8
removing baseline for deleted test
navya9singh cb06e8f
fixes
navya9singh 2a432e4
addressing pr comments
navya9singh e3deb17
addAsTypeOnly changes
navya9singh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
isValidTypeOnlyUseSite
should be consulted here in addition to the reference import. Also, what if the reference import is a type-only namespace import? It looks like we're only considering the type-onlyness of the import if it's a default import.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what the rules are supposed to be for setting
addAsTypeOnly
? I don't quite understand the last commit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe when
isValidTypeOnlyUseSite
is true, then ifisTypeOnlyImportDeclaration(referenceImport)
is true then it should beAddAsTypeOnly.Required
and if not, then it should beAddAsTypeOnly.Allowed
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and if
isValidTypeOnlyUseSite
is false, then it has to beAddAsTypeOnly.NotAllowed
. That makes sense to me!