Add new option "noUncheckedSideEffectImports"

src/compiler/checker.ts

@@ -1504,6 +1504,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
     var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
     var exactOptionalPropertyTypes = compilerOptions.exactOptionalPropertyTypes;
+    var resolveSideEffectImports = compilerOptions.resolveSideEffectImports;
 
     var checkBinaryExpression = createCheckBinaryExpression();
     var emitResolver = createResolver();
@@ -4573,6 +4574,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         if (ambientModule) {
             return ambientModule;
         }
+        const isSideEffectImport = isImportDeclaration(location) && !location.importClause;
         const currentSourceFile = getSourceFileOfNode(location);
         const contextSpecifier = isStringLiteralLike(location)
             ? location
@@ -4656,6 +4658,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 return getMergedSymbol(sourceFile.symbol);
             }
             if (errorNode && moduleNotFoundError) {
+                if (isSideEffectImport) {
+                    // This a side-effect import; ignore the fact that it's not a module.
+                    return undefined;
+                }
                 // report errors only if it was requested
                 error(errorNode, Diagnostics.File_0_is_not_a_module, sourceFile.fileName);
             }
@@ -4683,6 +4689,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 
         // May be an untyped module. If so, ignore resolutionDiagnostic.
         if (resolvedModule && !resolutionExtensionIsTSOrJson(resolvedModule.extension) && resolutionDiagnostic === undefined || resolutionDiagnostic === Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type) {
+            if (isSideEffectImport) {
+                // This a side-effect import; ignore the implicit any.
+                return undefined;
+            }
             if (isForAugmentation) {
                 const diag = Diagnostics.Invalid_module_name_in_augmentation_Module_0_resolves_to_an_untyped_module_at_1_which_cannot_be_augmented;
                 error(errorNode, diag, moduleReference, resolvedModule!.resolvedFileName);
@@ -47229,6 +47239,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     }
                 }
             }
+            else if (resolveSideEffectImports && !importClause) {
+                void resolveExternalModuleName(node, node.moduleSpecifier);
+            }
         }
         checkImportAttributes(node);
     }

src/compiler/commandLineParser.ts

@@ -1201,6 +1201,15 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
         category: Diagnostics.Modules,
         description: Diagnostics.Conditions_to_set_in_addition_to_the_resolver_specific_defaults_when_resolving_imports,
     },
+    {
+        name: "resolveSideEffectImports",
+        type: "boolean",
+        affectsSemanticDiagnostics: true,
+        affectsBuildInfo: true,
+        category: Diagnostics.Modules,
+        description: Diagnostics.Resolve_side_effect_imports,
+        defaultValueDescription: false,
+    },
 
     // Source Maps
     {

src/compiler/diagnosticMessages.json

@@ -6388,6 +6388,10 @@
         "category": "Message",
         "code": 6805
     },
+    "Resolve side effect imports.": {
+        "category": "Message",
+        "code": 6806
+    },
 
     "one of:": {
         "category": "Message",

src/compiler/types.ts

@@ -7418,6 +7418,7 @@ export interface CompilerOptions {
     target?: ScriptTarget;
     traceResolution?: boolean;
     useUnknownInCatchVariables?: boolean;
+    resolveSideEffectImports?: boolean;
     resolveJsonModule?: boolean;
     types?: string[];
     /** Paths used to compute primary types search locations */

tests/baselines/reference/api/typescript.d.ts

@@ -7017,6 +7017,7 @@ declare namespace ts {
         target?: ScriptTarget;
         traceResolution?: boolean;
         useUnknownInCatchVariables?: boolean;
+        resolveSideEffectImports?: boolean;
         resolveJsonModule?: boolean;
         types?: string[];
         /** Paths used to compute primary types search locations */

tests/baselines/reference/config/initTSConfig/Default initialized TSConfig/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --help/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --watch/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with advanced options/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with boolean value compiler options/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with enum value compiler options/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with files options/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with incorrect compiler option value/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with incorrect compiler option/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with list compiler options with enum value/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with list compiler options/tsconfig.json

@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "resolveSideEffectImports": true,                 /* Resolve side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

tests/baselines/reference/config/showConfig/Shows tsconfig for single option/resolveSideEffectImports/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "resolveSideEffectImports": true
+    }
+}

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=false).js

@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=false).symbols

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=false).types

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=true).errors.txt

@@ -0,0 +1,16 @@
+sideEffectImports1.ts(1,8): error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+sideEffectImports1.ts(2,8): error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+sideEffectImports1.ts(3,8): error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+
+
+==== sideEffectImports1.ts (3 errors) ====
+    import "does-not-exist";
+           ~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+    import "./does-not-exist-either";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+    import "./does-not-exist-either.js";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=true).js

@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=true).symbols

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=commonjs,resolvesideeffectimports=true).types

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=false).js

@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=false).symbols

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=false).types

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=true).errors.txt

@@ -0,0 +1,16 @@
+sideEffectImports1.ts(1,8): error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+sideEffectImports1.ts(2,8): error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+sideEffectImports1.ts(3,8): error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+
+
+==== sideEffectImports1.ts (3 errors) ====
+    import "does-not-exist";
+           ~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+    import "./does-not-exist-either";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+    import "./does-not-exist-either.js";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=true).js

@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=true).symbols

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+

tests/baselines/reference/sideEffectImports1(module=nodenext,resolvesideeffectimports=true).types

@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+