Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typescript-etw #58832

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove typescript-etw #58832

merged 1 commit into from
Jun 13, 2024

Conversation

jakebailey
Copy link
Member

@microsoft/typescript-etw has been deprecated and archived. Remove all related code.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 11, 2024
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 13, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 192,856k (± 0.74%) 194,024k (± 1.01%) ~ 192,229k 195,907k p=0.810 n=6
Parse Time 1.30s (± 0.64%) 1.31s (± 0.57%) ~ 1.30s 1.32s p=0.652 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.60s (± 0.47%) 9.58s (± 0.24%) ~ 9.54s 9.61s p=0.373 n=6
Emit Time 2.73s (± 1.34%) 2.74s (± 0.55%) ~ 2.72s 2.76s p=0.405 n=6
Total Time 14.35s (± 0.48%) 14.34s (± 0.25%) ~ 14.29s 14.40s p=1.000 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,104 944,104 ~ ~ ~ p=1.000 n=6
Types 407,044 407,044 ~ ~ ~ p=1.000 n=6
Memory used 1,218,575k (± 0.00%) 1,218,548k (± 0.00%) ~ 1,218,479k 1,218,612k p=0.378 n=6
Parse Time 7.91s (± 0.34%) 7.93s (± 0.67%) ~ 7.86s 8.00s p=0.469 n=6
Bind Time 2.23s (± 1.41%) 2.23s (± 1.58%) ~ 2.20s 2.30s p=0.546 n=6
Check Time 36.19s (± 0.63%) 36.05s (± 0.26%) ~ 35.89s 36.14s p=0.470 n=6
Emit Time 17.80s (± 0.27%) 17.76s (± 0.24%) ~ 17.70s 17.82s p=0.143 n=6
Total Time 64.13s (± 0.33%) 63.98s (± 0.17%) ~ 63.85s 64.09s p=0.077 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 2,132,301 2,132,301 ~ ~ ~ p=1.000 n=6
Types 926,081 926,081 ~ ~ ~ p=1.000 n=6
Memory used 2,115,012k (± 0.00%) 2,114,980k (± 0.01%) ~ 2,114,812k 2,115,085k p=0.810 n=6
Parse Time 6.63s (± 0.33%) 6.62s (± 0.12%) ~ 6.61s 6.63s p=0.324 n=6
Bind Time 2.31s (± 0.61%) 2.32s (± 0.61%) ~ 2.30s 2.34s p=0.289 n=6
Check Time 71.49s (± 0.54%) 71.50s (± 0.41%) ~ 71.03s 71.87s p=1.000 n=6
Emit Time 0.14s (± 2.95%) 0.14s (± 3.77%) ~ 0.13s 0.14s p=0.595 n=6
Total Time 80.56s (± 0.47%) 80.57s (± 0.36%) ~ 80.12s 80.96s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,230,572 1,229,984 -588 (- 0.05%) ~ ~ p=0.001 n=6
Types 261,228 261,100 -128 (- 0.05%) ~ ~ p=0.001 n=6
Memory used 2,352,804k (± 0.04%) 2,350,484k (± 0.06%) -2,320k (- 0.10%) 2,347,862k 2,351,736k p=0.005 n=6
Parse Time 5.94s (± 0.47%) 5.95s (± 1.02%) ~ 5.86s 6.03s p=0.471 n=6
Bind Time 2.25s (± 0.73%) 2.25s (± 0.92%) ~ 2.22s 2.28s p=1.000 n=6
Check Time 39.88s (± 0.64%) 40.01s (± 0.29%) ~ 39.87s 40.16s p=0.297 n=6
Emit Time 3.08s (± 2.36%) 3.05s (± 2.83%) ~ 2.97s 3.20s p=0.521 n=6
Total Time 51.17s (± 0.59%) 51.27s (± 0.37%) ~ 51.15s 51.65s p=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,230,572 1,229,984 -588 (- 0.05%) ~ ~ p=0.001 n=6
Types 261,228 261,100 -128 (- 0.05%) ~ ~ p=0.001 n=6
Memory used 2,427,469k (± 0.04%) 2,427,060k (± 0.04%) ~ 2,426,225k 2,428,391k p=0.378 n=6
Parse Time 5.20s (± 0.83%) 5.19s (± 0.66%) ~ 5.14s 5.23s p=0.628 n=6
Bind Time 1.69s (± 0.61%) 1.69s (± 0.37%) ~ 1.68s 1.70s p=0.654 n=6
Check Time 34.46s (± 0.50%) 34.38s (± 0.26%) ~ 34.27s 34.51s p=0.575 n=6
Emit Time 2.69s (± 2.43%) 2.61s (± 2.35%) ~ 2.54s 2.70s p=0.092 n=6
Total Time 44.06s (± 0.44%) 43.88s (± 0.22%) ~ 43.78s 44.02s p=0.066 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 259,198 259,075 -123 (- 0.05%) ~ ~ p=0.001 n=6
Types 105,191 105,106 -85 (- 0.08%) ~ ~ p=0.001 n=6
Memory used 428,905k (± 0.02%) 428,717k (± 0.02%) -189k (- 0.04%) 428,630k 428,854k p=0.013 n=6
Parse Time 3.28s (± 0.66%) 3.32s (± 0.64%) +0.03s (+ 1.07%) 3.29s 3.34s p=0.036 n=6
Bind Time 1.34s (± 0.73%) 1.31s (± 1.25%) -0.03s (- 2.37%) 1.29s 1.33s p=0.009 n=6
Check Time 18.11s (± 0.46%) 18.14s (± 0.29%) ~ 18.08s 18.20s p=0.521 n=6
Emit Time 1.39s (± 0.84%) 1.37s (± 0.97%) ~ 1.35s 1.38s p=0.055 n=6
Total Time 24.12s (± 0.35%) 24.14s (± 0.23%) ~ 24.08s 24.22s p=0.810 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,597k (± 0.03%) 369,563k (± 0.02%) ~ 369,478k 369,621k p=0.575 n=6
Parse Time 2.31s (± 0.36%) 2.30s (± 0.86%) ~ 2.27s 2.32s p=0.506 n=6
Bind Time 1.33s (± 0.57%) 1.33s (± 1.02%) ~ 1.32s 1.36s p=0.652 n=6
Check Time 13.33s (± 0.30%) 13.32s (± 0.38%) ~ 13.23s 13.37s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 16.96s (± 0.27%) 16.95s (± 0.28%) ~ 16.89s 17.00s p=0.809 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,853,506 2,853,506 ~ ~ ~ p=1.000 n=6
Types 968,049 968,049 ~ ~ ~ p=1.000 n=6
Memory used 3,020,482k (± 0.00%) 3,020,508k (± 0.00%) ~ 3,020,448k 3,020,631k p=0.689 n=6
Parse Time 16.77s (± 0.35%) 16.80s (± 0.37%) ~ 16.72s 16.86s p=0.227 n=6
Bind Time 5.09s (± 0.16%) 5.17s (± 2.17%) ~ 5.07s 5.31s p=0.251 n=6
Check Time 89.85s (± 0.20%) 89.28s (± 0.34%) -0.57s (- 0.63%) 88.93s 89.80s p=0.020 n=6
Emit Time 29.03s (± 0.68%) 29.12s (± 0.83%) ~ 28.95s 29.58s p=0.471 n=6
Total Time 140.74s (± 0.24%) 140.36s (± 0.20%) -0.38s (- 0.27%) 140.12s 140.91s p=0.031 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 266,914 266,914 ~ ~ ~ p=1.000 n=6
Types 108,685 108,685 ~ ~ ~ p=1.000 n=6
Memory used 411,442k (± 0.01%) 411,389k (± 0.03%) ~ 411,291k 411,571k p=0.298 n=6
Parse Time 4.72s (± 0.48%) 4.70s (± 0.18%) ~ 4.69s 4.71s p=0.078 n=6
Bind Time 2.07s (± 0.66%) 2.07s (± 0.39%) ~ 2.06s 2.08s p=0.933 n=6
Check Time 21.01s (± 0.21%) 20.96s (± 0.64%) ~ 20.82s 21.16s p=0.520 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.80s (± 0.15%) 27.73s (± 0.48%) ~ 27.59s 27.93s p=0.423 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 523,429 523,429 ~ ~ ~ p=1.000 n=6
Types 177,955 177,955 ~ ~ ~ p=1.000 n=6
Memory used 461,865k (± 0.02%) 461,588k (± 0.07%) ~ 461,155k 461,894k p=0.093 n=6
Parse Time 2.63s (± 0.76%) 2.64s (± 0.39%) ~ 2.62s 2.65s p=0.459 n=6
Bind Time 0.99s (± 0.41%) 1.00s (± 1.04%) ~ 0.98s 1.01s p=0.257 n=6
Check Time 15.34s (± 0.43%) 15.29s (± 0.36%) ~ 15.23s 15.39s p=0.197 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 18.96s (± 0.36%) 18.92s (± 0.33%) ~ 18.87s 19.03s p=0.226 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,418ms (± 0.40%) 3,408ms (± 0.64%) ~ 3,387ms 3,441ms p=0.378 n=6
Req 2 - geterr 7,552ms (± 0.33%) 7,538ms (± 1.50%) ~ 7,330ms 7,649ms p=0.810 n=6
Req 3 - references 395ms (± 0.50%) 397ms (± 0.44%) ~ 395ms 400ms p=0.454 n=6
Req 4 - navto 339ms (± 0.43%) 340ms (± 0.16%) ~ 339ms 340ms p=0.476 n=6
Req 5 - completionInfo count 1,357 1,357 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 129ms (± 1.42%) 124ms (± 5.96%) ~ 114ms 131ms p=0.188 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,403ms (± 0.60%) 2,397ms (± 0.38%) ~ 2,384ms 2,407ms p=0.630 n=6
Req 2 - geterr 3,870ms (± 0.32%) 3,875ms (± 0.19%) ~ 3,866ms 3,888ms p=0.297 n=6
Req 3 - references 273ms (± 0.38%) 273ms (± 0.28%) ~ 272ms 274ms p=0.437 n=6
Req 4 - navto 228ms (± 0.18%) 228ms (± 0.18%) ~ 227ms 228ms p=1.000 n=6
Req 5 - completionInfo count 1,519 1,519 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 75ms (± 7.39%) 72ms (± 1.05%) ~ 71ms 73ms p=0.389 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 6,175ms (± 0.78%) 6,175ms (± 0.78%) ~ 6,111ms 6,255ms p=1.000 n=6
Req 2 - geterr 1,524ms (±12.17%) 1,638ms (± 7.86%) ~ 1,382ms 1,747ms p=0.630 n=6
Req 3 - references 131ms (± 9.77%) 137ms (± 4.41%) ~ 131ms 143ms p=0.406 n=6
Req 4 - navto 586ms (± 2.86%) 596ms (± 2.18%) ~ 580ms 612ms p=0.128 n=6
Req 5 - completionInfo count 3,412 3,412 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 1,250ms (± 1.48%) 1,255ms (± 2.31%) ~ 1,219ms 1,293ms p=1.000 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 187.25ms (± 0.17%) 186.72ms (± 0.18%) -0.53ms (- 0.28%) 184.70ms 190.95ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 241.70ms (± 0.12%) 241.61ms (± 0.14%) -0.09ms (- 0.04%) 240.16ms 246.95ms p=0.001 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 237.58ms (± 0.12%) 237.06ms (± 0.14%) -0.52ms (- 0.22%) 235.64ms 241.65ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 351.07ms (± 0.29%) 350.50ms (± 0.30%) -0.56ms (- 0.16%) 341.76ms 361.09ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey jakebailey merged commit e30b5fb into microsoft:main Jun 13, 2024
28 checks passed
@jakebailey jakebailey deleted the remove-etw branch June 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @RyanCavanaugh