Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure jsDocParsingMode is passed to LanguageService document registry #58404

Merged
merged 1 commit into from
May 6, 2024

Conversation

jakebailey
Copy link
Member

Noticed this inconsistency when looking into an ESLint crash (but this wouldn't fix that).

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 2, 2024
@jakebailey
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 3, 2024

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161602/artifacts?artifactName=tgz&fileId=5950FA5BFD654C5EBFE2D85B2D3435D7E79A4843895C59CD9DEA980F09FD725602&fileName=/typescript-5.5.0-insiders.20240503.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58404-2".;

@jakebailey jakebailey merged commit 2070713 into microsoft:main May 6, 2024
28 checks passed
@jakebailey jakebailey deleted the fix-jsdoc-parsing-mode-ls branch May 6, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants