Disable constraint reduction in intersections created by constraint hoisting #58403

ahejlsberg · 2024-05-02T16:04:14Z

ahejlsberg · 2024-05-02T16:04:26Z

typescript-bot · 2024-05-02T16:04:29Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-02T16:27:28Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-02T16:28:16Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58403/merge:

Everything looks good!

typescript-bot · 2024-05-02T16:40:00Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,851k (± 0.75%)}	_{192,889k (± 0.73%)}	_~	_192,216k	_195,765k	_{p=0.471 n=6}
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.30s (± 0.90%)}	_~	_1.28s	_1.31s	_{p=0.498 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.35%)}	_{9.55s (± 0.44%)}	_~	_9.51s	_9.61s	_{p=1.000 n=6}
_{Emit Time}	_{2.63s (± 0.51%)}	_{2.63s (± 0.61%)}	_~	_2.61s	_2.65s	_{p=1.000 n=6}
_{Total Time}	_{14.21s (± 0.29%)}	_{14.20s (± 0.42%)}	_~	_14.13s	_14.29s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,322	_945,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_408,088	_408,110	_{+22 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,849k (± 0.00%)}	_{1,222,845k (± 0.00%)}	_~	_1,222,799k	_1,222,953k	_{p=0.575 n=6}
_{Parse Time}	_{6.78s (± 0.62%)}	_{6.79s (± 0.64%)}	_~	_6.73s	_6.84s	_{p=0.936 n=6}
_{Bind Time}	_{1.87s (± 0.65%)}	_{1.88s (± 0.55%)}	_~	_1.86s	_1.89s	_{p=0.675 n=6}
_{Check Time}	_{31.35s (± 0.45%)}	_{31.23s (± 0.38%)}	_~	_31.03s	_31.34s	_{p=0.109 n=6}
_{Emit Time}	_{14.59s (± 1.49%)}	_{14.75s (± 0.82%)}	_~	_14.56s	_14.85s	_{p=0.128 n=6}
_{Total Time}	_{54.60s (± 0.34%)}	_{54.64s (± 0.36%)}	_~	_54.39s	_54.85s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,956,826	_1,956,875	_{+49 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_676,443	_676,637	_{+194 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,764,744k (± 0.00%)}	_{1,765,669k (± 0.00%)}	_{+925k (+ 0.05%)}	_1,765,591k	_1,765,721k	_{p=0.005 n=6}
_{Parse Time}	_{6.69s (± 0.25%)}	_{6.68s (± 0.21%)}	_~	_6.66s	_6.70s	_{p=0.869 n=6}
_{Bind Time}	_{2.31s (± 0.64%)}	_{2.32s (± 0.22%)}	_~	_2.31s	_2.32s	_{p=0.667 n=6}
_{Check Time}	_{56.37s (± 0.43%)}	_{56.24s (± 0.11%)}	_~	_56.18s	_56.32s	_{p=0.336 n=6}
_{Emit Time}	_0.14s	_{0.14s (± 4.51%)}	_~	_0.13s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{65.51s (± 0.37%)}	_{65.38s (± 0.08%)}	_~	_65.31s	_65.43s	_{p=0.375 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,318	_1,217,388	_{+70 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,271	_259,008	_{+737 (+ 0.29%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,327,333k (± 0.02%)}	_{2,328,074k (± 0.03%)}	_~	_2,326,835k	_2,328,636k	_{p=0.128 n=6}
_{Parse Time}	_{4.91s (± 1.02%)}	_{4.94s (± 0.93%)}	_~	_4.87s	_5.00s	_{p=0.261 n=6}
_{Bind Time}	_{1.88s (± 1.36%)}	_{1.88s (± 0.80%)}	_~	_1.85s	_1.89s	_{p=0.871 n=6}
_{Check Time}	_{33.48s (± 0.31%)}	_{33.48s (± 0.26%)}	_~	_33.34s	_33.58s	_{p=1.000 n=6}
_{Emit Time}	_{2.60s (± 0.86%)}	_{2.63s (± 1.64%)}	_~	_2.58s	_2.71s	_{p=0.126 n=6}
_{Total Time}	_{42.89s (± 0.26%)}	_{42.96s (± 0.35%)}	_~	_42.75s	_43.14s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,318	_1,217,388	_{+70 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,271	_259,008	_{+737 (+ 0.29%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,402,804k (± 0.04%)}	_{2,402,797k (± 0.02%)}	_~	_2,402,348k	_2,403,370k	_{p=0.575 n=6}
_{Parse Time}	_{7.73s (± 1.10%)}	_{7.71s (± 0.63%)}	_~	_7.65s	_7.79s	_{p=1.000 n=6}
_{Bind Time}	_{2.47s (± 0.71%)}	_{2.46s (± 0.56%)}	_~	_2.44s	_2.48s	_{p=0.411 n=6}
_{Check Time}	_{49.43s (± 0.20%)}	_{49.55s (± 0.57%)}	_~	_49.32s	_50.11s	_{p=0.689 n=6}
_{Emit Time}	_{3.90s (± 4.27%)}	_{3.87s (± 1.34%)}	_~	_3.79s	_3.95s	_{p=0.748 n=6}
_{Total Time}	_{63.54s (± 0.21%)}	_{63.60s (± 0.42%)}	_~	_63.39s	_64.10s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,297	_256,310	_{+13 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_103,722	_104,458	_{+736 (+ 0.71%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{424,323k (± 0.01%)}	_{424,921k (± 0.01%)}	_{+599k (+ 0.14%)}	_424,877k	_424,950k	_{p=0.005 n=6}
_{Parse Time}	_{3.37s (± 0.63%)}	_{3.38s (± 0.99%)}	_~	_3.34s	_3.43s	_{p=0.466 n=6}
_{Bind Time}	_{1.31s (± 0.64%)}	_{1.31s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.527 n=6}
_{Check Time}	_{17.76s (± 0.36%)}	_{17.79s (± 0.28%)}	_~	_17.71s	_17.83s	_{p=0.422 n=6}
_{Emit Time}	_{1.36s (± 1.95%)}	_{1.35s (± 2.04%)}	_~	_1.32s	_1.39s	_{p=0.516 n=6}
_{Total Time}	_{23.79s (± 0.22%)}	_{23.82s (± 0.25%)}	_~	_23.76s	_23.90s	_{p=0.572 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,824	_224,826	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,390	_94,115	_{+725 (+ 0.78%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{369,308k (± 0.01%)}	_{369,998k (± 0.03%)}	_{+690k (+ 0.19%)}	_369,842k	_370,175k	_{p=0.005 n=6}
_{Parse Time}	_{2.84s (± 0.87%)}	_{2.83s (± 0.80%)}	_~	_2.79s	_2.85s	_{p=0.468 n=6}
_{Bind Time}	_{1.58s (± 0.53%)}	_{1.58s (± 0.48%)}	_~	_1.57s	_1.59s	_{p=0.172 n=6}
_{Check Time}	_{15.52s (± 0.35%)}	_{15.57s (± 0.46%)}	_~	_15.45s	_15.64s	_{p=0.172 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.95s (± 0.25%)}	_{19.98s (± 0.35%)}	_~	_19.85s	_20.04s	_{p=0.261 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,801,596	_2,801,607	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_951,622	_951,635	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,949,564k (± 0.01%)}	_{2,949,568k (± 0.00%)}	_~	_2,949,498k	_2,949,676k	_{p=0.810 n=6}
_{Parse Time}	_{13.51s (± 0.37%)}	_{13.48s (± 0.11%)}	_~	_13.45s	_13.49s	_{p=0.085 n=6}
_{Bind Time}	_{4.12s (± 2.36%)}	_{4.13s (± 2.10%)}	_~	_4.08s	_4.30s	_{p=0.655 n=6}
_{Check Time}	_{72.88s (± 0.33%)}	_{72.81s (± 0.27%)}	_~	_72.49s	_73.05s	_{p=0.689 n=6}
_{Emit Time}	_{23.58s (± 0.99%)}	_{23.55s (± 0.55%)}	_~	_23.36s	_23.70s	_{p=1.000 n=6}
_{Total Time}	_{114.09s (± 0.29%)}	_{113.98s (± 0.26%)}	_~	_113.58s	_114.26s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,858	_265,864	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,442	_108,449	_{+7 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{410,410k (± 0.01%)}	_{410,595k (± 0.02%)}	_{+185k (+ 0.04%)}	_410,493k	_410,685k	_{p=0.005 n=6}
_{Parse Time}	_{4.78s (± 0.98%)}	_{4.80s (± 0.76%)}	_~	_4.76s	_4.85s	_{p=0.334 n=6}
_{Bind Time}	_{2.07s (± 0.66%)}	_{2.07s (± 1.10%)}	_~	_2.03s	_2.10s	_{p=0.802 n=6}
_{Check Time}	_{20.99s (± 0.39%)}	_{21.05s (± 0.29%)}	_~	_20.99s	_21.16s	_{p=0.422 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.84s (± 0.34%)}	_{27.92s (± 0.12%)}	_~	_27.87s	_27.95s	_{p=0.148 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,146	_524,146	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,732	_178,737	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{462,190k (± 0.02%)}	_{462,219k (± 0.02%)}	_~	_462,123k	_462,393k	_{p=0.810 n=6}
_{Parse Time}	_{3.89s (± 0.60%)}	_{3.89s (± 0.62%)}	_~	_3.86s	_3.93s	_{p=0.570 n=6}
_{Bind Time}	_{1.47s (± 0.96%)}	_{1.47s (± 0.79%)}	_~	_1.45s	_1.48s	_{p=0.803 n=6}
_{Check Time}	_{22.32s (± 0.70%)}	_{22.33s (± 0.55%)}	_~	_22.16s	_22.48s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.67s (± 0.50%)}	_{27.69s (± 0.42%)}	_~	_27.53s	_27.85s	_{p=0.873 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-02T17:55:32Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58403/merge:

Everything looks good!

ahejlsberg · 2024-05-02T18:08:13Z

Tests and performance all look good. This is ready to review and merge.

jakebailey · 2024-05-02T19:21:53Z

src/compiler/checker.ts

@@ -17467,7 +17468,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
    // a type alias of the form "type List<T> = T & { next: List<T> }" cannot be reduced during its declaration.
    // Also, unlike union types, the order of the constituent types is preserved in order that overload resolution
    // for intersections of types with signatures can be deterministic.
-    function getIntersectionType(types: readonly Type[], aliasSymbol?: Symbol, aliasTypeArguments?: readonly Type[], noSupertypeReduction?: boolean): Type {
+    function getIntersectionType(types: readonly Type[], flags = IntersectionFlags.None, aliasSymbol?: Symbol, aliasTypeArguments?: readonly Type[]): Type {


Is this flag something that should be required, in case we forget to pass it? Happens all the time for the relation intersection state...

No, it's exceedingly rare to need any of these flags (only one place for each flag in entire code base), so I think it's preferable to leave it optional.

ahejlsberg added 4 commits May 2, 2024 08:56

Add IntersectionFlags

5625f8b

Accept new baselines

505fe38

Add tests

16373df

Formatting

cc202c1

typescript-bot assigned ahejlsberg May 2, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 2, 2024

ahejlsberg requested a review from RyanCavanaugh May 2, 2024 18:07

RyanCavanaugh approved these changes May 2, 2024

View reviewed changes

jakebailey reviewed May 2, 2024

View reviewed changes

ahejlsberg merged commit 3a74ec4 into main May 2, 2024

ahejlsberg deleted the fix58370 branch May 2, 2024 23:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Disable constraint reduction in intersections created by constraint hoisting #58403

Disable constraint reduction in intersections created by constraint hoisting #58403

Uh oh!

ahejlsberg commented May 2, 2024

Uh oh!

ahejlsberg commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024 •

edited

Loading

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024

tsc

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

ahejlsberg commented May 2, 2024

Uh oh!

jakebailey May 2, 2024

Uh oh!

ahejlsberg May 2, 2024

Uh oh!

Uh oh!

Disable constraint reduction in intersections created by constraint hoisting #58403

Disable constraint reduction in intersections created by constraint hoisting #58403

Uh oh!

Conversation

ahejlsberg commented May 2, 2024

Uh oh!

ahejlsberg commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

typescript-bot commented May 2, 2024

tsc

Uh oh!

typescript-bot commented May 2, 2024

Uh oh!

ahejlsberg commented May 2, 2024

Uh oh!

jakebailey May 2, 2024

Choose a reason for hiding this comment

Uh oh!

ahejlsberg May 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

typescript-bot commented May 2, 2024 •

edited

Loading