Skip to content

Remove deprecated originalKeywordKind and isInJSDocNamespace #58228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

Remove deprecated originalKeywordKind and isInJSDocNamespace #58228

merged 1 commit into from
Apr 17, 2024

Conversation

jakebailey
Copy link
Member

These were both deprecated in 5.0, started warning in 5.1, and now throw errors in 5.2+; I think it's safe to remove these. Probably helps perf to do so.

Closes #51496

@jakebailey jakebailey requested a review from rbuckton April 17, 2024 18:18
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 17, 2024
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 17, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 297,001k (± 0.01%) 297,017k (± 0.00%) ~ 296,997k 297,026k p=0.378 n=6
Parse Time 3.26s (± 0.74%) 3.26s (± 0.45%) ~ 3.24s 3.28s p=0.466 n=6
Bind Time 0.98s (± 0.42%) 0.98s (± 0.83%) ~ 0.98s 1.00s p=1.000 n=6
Check Time 9.78s (± 0.27%) 9.80s (± 0.48%) ~ 9.74s 9.88s p=0.806 n=6
Emit Time 8.43s (± 0.32%) 8.44s (± 0.48%) ~ 8.37s 8.48s p=0.809 n=6
Total Time 22.45s (± 0.17%) 22.48s (± 0.25%) ~ 22.41s 22.57s p=0.573 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 192,467k (± 0.73%) 191,810k (± 0.02%) ~ 191,758k 191,846k p=0.066 n=6
Parse Time 1.35s (± 1.46%) 1.35s (± 0.38%) ~ 1.35s 1.36s p=0.437 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=1.000 n=6
Check Time 9.56s (± 0.30%) 9.58s (± 0.45%) ~ 9.54s 9.64s p=0.374 n=6
Emit Time 2.62s (± 0.16%) 2.63s (± 0.64%) ~ 2.61s 2.66s p=0.257 n=6
Total Time 14.25s (± 0.29%) 14.28s (± 0.35%) ~ 14.22s 14.34s p=0.377 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,751,111k (± 0.00%) 1,751,138k (± 0.00%) ~ 1,751,079k 1,751,173k p=1.000 n=6
Parse Time 8.09s (± 0.42%) 8.08s (± 0.42%) ~ 8.05s 8.13s p=0.747 n=6
Bind Time 2.72s (± 0.54%) 2.71s (± 0.49%) ~ 2.70s 2.73s p=0.357 n=6
Check Time 66.87s (± 0.42%) 66.94s (± 0.33%) ~ 66.67s 67.19s p=0.873 n=6
Emit Time 0.16s (± 0.00%) 0.16s (± 0.00%) ~ 0.16s 0.16s p=1.000 n=6
Total Time 77.84s (± 0.33%) 77.89s (± 0.28%) ~ 77.65s 78.11s p=0.936 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,307,817k (± 0.04%) 2,307,426k (± 0.02%) ~ 2,306,651k 2,307,721k p=0.423 n=6
Parse Time 7.42s (± 1.48%) 7.34s (± 0.33%) ~ 7.31s 7.36s p=0.378 n=6
Bind Time 2.74s (± 1.11%) 2.71s (± 0.57%) ~ 2.69s 2.73s p=0.064 n=6
Check Time 49.49s (± 0.51%) 49.25s (± 0.81%) ~ 48.93s 49.94s p=0.230 n=6
Emit Time 3.84s (± 2.32%) 3.89s (± 2.56%) ~ 3.71s 4.00s p=0.471 n=6
Total Time 63.48s (± 0.63%) 63.18s (± 0.69%) ~ 62.80s 63.95s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 2,382,674k (± 0.04%) 2,381,303k (± 0.04%) -1,372k (- 0.06%) 2,380,368k 2,382,723k p=0.031 n=6
Parse Time 7.62s (± 0.70%) 7.64s (± 0.65%) ~ 7.57s 7.70s p=0.378 n=6
Bind Time 2.50s (± 0.67%) 2.50s (± 1.09%) ~ 2.47s 2.54s p=0.686 n=6
Check Time 49.65s (± 0.74%) 50.12s (± 0.73%) ~ 49.73s 50.50s p=0.066 n=6
Emit Time 3.93s (± 1.73%) 3.90s (± 2.77%) ~ 3.70s 3.99s p=0.810 n=6
Total Time 63.72s (± 0.59%) 64.18s (± 0.69%) ~ 63.69s 64.65s p=0.128 n=6
self-compiler - node (v18.15.0, x64)
Memory used 419,412k (± 0.01%) 419,455k (± 0.02%) ~ 419,396k 419,580k p=0.230 n=6
Parse Time 2.78s (± 2.15%) 2.76s (± 2.98%) ~ 2.64s 2.82s p=0.872 n=6
Bind Time 1.11s (± 4.58%) 1.12s (± 4.37%) ~ 1.07s 1.20s p=0.803 n=6
Check Time 15.31s (± 0.36%) 15.33s (± 0.39%) ~ 15.28s 15.43s p=1.000 n=6
Emit Time 1.16s (± 1.95%) 1.14s (± 1.89%) ~ 1.11s 1.17s p=0.517 n=6
Total Time 20.36s (± 0.32%) 20.34s (± 0.36%) ~ 20.25s 20.46s p=0.744 n=6
ts-pre-modules - node (v18.15.0, x64)
Memory used 368,962k (± 0.03%) 368,988k (± 0.02%) ~ 368,919k 369,102k p=0.471 n=6
Parse Time 2.93s (± 1.07%) 2.95s (± 1.19%) ~ 2.91s 2.99s p=0.418 n=6
Bind Time 1.59s (± 1.08%) 1.62s (± 1.41%) +0.03s (+ 1.99%) 1.58s 1.64s p=0.044 n=6
Check Time 15.68s (± 0.13%) 15.67s (± 0.18%) ~ 15.64s 15.72s p=0.746 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.20s (± 0.09%) 20.24s (± 0.34%) ~ 20.14s 20.33s p=0.225 n=6
vscode - node (v18.15.0, x64)
Memory used 2,915,456k (± 0.01%) 2,915,589k (± 0.00%) ~ 2,915,546k 2,915,654k p=0.297 n=6
Parse Time 16.54s (± 0.43%) 16.52s (± 0.31%) ~ 16.45s 16.58s p=0.936 n=6
Bind Time 4.95s (± 0.41%) 4.95s (± 0.22%) ~ 4.94s 4.97s p=0.868 n=6
Check Time 88.15s (± 0.34%) 88.34s (± 0.21%) ~ 88.10s 88.62s p=0.228 n=6
Emit Time 25.12s (± 8.87%) 23.80s (± 0.72%) ~ 23.56s 24.03s p=0.572 n=6
Total Time 134.75s (± 1.75%) 133.62s (± 0.24%) ~ 133.28s 134.17s p=0.810 n=6
webpack - node (v18.15.0, x64)
Memory used 409,443k (± 0.02%) 409,472k (± 0.02%) ~ 409,397k 409,561k p=0.471 n=6
Parse Time 3.88s (± 1.46%) 3.89s (± 0.91%) ~ 3.84s 3.94s p=0.872 n=6
Bind Time 1.66s (± 0.99%) 1.66s (± 1.01%) ~ 1.64s 1.69s p=0.676 n=6
Check Time 16.98s (± 0.44%) 17.00s (± 0.37%) ~ 16.93s 17.08s p=0.689 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.52s (± 0.39%) 22.54s (± 0.43%) ~ 22.45s 22.67s p=1.000 n=6
xstate-main - node (v18.15.0, x64)
Memory used 458,907k (± 0.01%) 458,955k (± 0.02%) ~ 458,866k 459,125k p=0.423 n=6
Parse Time 2.69s (± 0.66%) 2.69s (± 0.84%) ~ 2.66s 2.72s p=0.934 n=6
Bind Time 0.98s (± 0.77%) 0.98s (± 0.77%) ~ 0.97s 0.99s p=1.000 n=6
Check Time 15.31s (± 0.16%) 15.33s (± 0.42%) ~ 15.26s 15.44s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 18.98s (± 0.13%) 19.00s (± 0.41%) ~ 18.90s 19.13s p=0.688 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,347ms (± 0.38%) 2,344ms (± 0.73%) ~ 2,322ms 2,374ms p=0.423 n=6
Req 2 - geterr 5,165ms (± 2.03%) 5,126ms (± 0.50%) ~ 5,093ms 5,171ms p=1.000 n=6
Req 3 - references 284ms (± 0.74%) 289ms (± 2.02%) ~ 285ms 297ms p=0.139 n=6
Req 4 - navto 228ms (± 0.70%) 227ms (± 0.66%) ~ 225ms 229ms p=0.210 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 81ms (± 7.39%) 82ms (± 9.81%) ~ 76ms 92ms p=0.804 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,510ms (± 0.89%) 2,490ms (± 1.04%) ~ 2,447ms 2,516ms p=0.230 n=6
Req 2 - geterr 3,907ms (± 2.09%) 3,923ms (± 1.64%) ~ 3,837ms 3,976ms p=1.000 n=6
Req 3 - references 302ms (± 1.75%) 301ms (± 1.76%) ~ 296ms 309ms p=0.935 n=6
Req 4 - navto 228ms (± 0.33%) 228ms (± 0.46%) ~ 226ms 229ms p=0.273 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 79ms (± 7.66%) 78ms (± 6.74%) ~ 72ms 84ms p=0.681 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,652ms (± 0.23%) 2,658ms (± 0.29%) ~ 2,649ms 2,672ms p=0.167 n=6
Req 2 - geterr 1,487ms (± 0.34%) 1,485ms (± 0.75%) ~ 1,467ms 1,495ms p=0.872 n=6
Req 3 - references 134ms (± 7.24%) 139ms (± 8.31%) ~ 127ms 154ms p=0.418 n=6
Req 4 - navto 349ms (± 0.31%) 351ms (± 0.66%) ~ 348ms 353ms p=0.249 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 298ms (± 0.25%) 299ms (± 0.80%) ~ 295ms 301ms p=0.415 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 154.86ms (± 0.16%) 154.85ms (± 0.17%) ~ 153.82ms 158.60ms p=0.915 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 228.45ms (± 0.14%) 227.59ms (± 0.15%) -0.86ms (- 0.38%) 226.30ms 233.87ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 275.14ms (± 0.27%) 274.00ms (± 0.27%) -1.14ms (- 0.41%) 267.13ms 277.15ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 333.46ms (± 0.32%) 332.38ms (± 0.27%) -1.08ms (- 0.32%) 324.78ms 335.82ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

@typescript-bot perf test this predictable

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 17, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this predictable ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 296,950k (± 0.00%) 296,950k (± 0.00%) ~ 296,950k 296,950k p=1.000 n=6
Parse Time 3.07s (± 0.34%) 3.08s (± 0.34%) ~ 3.06s 3.09s p=0.801 n=6
Bind Time 1.12s (± 0.00%) 1.12s (± 0.00%) ~ 1.12s 1.12s p=1.000 n=6
Check Time 9.98s (± 0.04%) 9.93s (± 0.12%) -0.04s (- 0.43%) 9.92s 9.95s p=0.003 n=6
Emit Time 8.42s (± 0.29%) 8.42s (± 0.21%) ~ 8.41s 8.45s p=0.361 n=6
Total Time 22.59s (± 0.14%) 22.56s (± 0.11%) -0.03s (- 0.15%) 22.53s 22.60s p=0.050 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 191,832k (± 0.00%) 191,832k (± 0.00%) ~ 191,832k 191,832k p=1.000 n=6
Parse Time 2.02s (± 0.37%) 2.02s (± 0.58%) ~ 2.00s 2.03s p=0.796 n=6
Bind Time 1.06s (± 0.49%) 1.06s (± 0.38%) ~ 1.06s 1.07s p=0.595 n=6
Check Time 13.85s (± 0.08%) 13.85s (± 0.17%) ~ 13.84s 13.90s p=0.796 n=6
Emit Time 4.11s (± 0.10%) 4.11s (± 0.00%) ~ 4.11s 4.11s p=0.405 n=6
Total Time 21.04s (± 0.07%) 21.04s (± 0.14%) ~ 21.02s 21.10s p=0.807 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,751,446k (± 0.00%) 1,751,357k (± 0.00%) -90k (- 0.01%) 1,751,317k 1,751,401k p=0.011 n=6
Parse Time 8.28s (± 0.18%) 8.28s (± 0.13%) ~ 8.26s 8.29s p=1.000 n=6
Bind Time 2.20s (± 0.00%) 2.20s (± 0.00%) ~ 2.20s 2.20s p=1.000 n=6
Check Time 71.11s (± 0.16%) 71.38s (± 0.49%) +0.28s (+ 0.39%) 71.13s 72.06s p=0.045 n=6
Emit Time 0.17s (± 3.10%) 0.17s (± 3.32%) ~ 0.16s 0.17s p=0.640 n=6
Total Time 81.76s (± 0.13%) 82.03s (± 0.43%) ~ 81.78s 82.71s p=0.054 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,309,512k (± 0.00%) 2,307,711k (± 0.00%) -1,801k (- 0.08%) 2,307,661k 2,307,830k p=0.004 n=6
Parse Time 7.09s (± 0.24%) 7.06s (± 0.26%) ~ 7.05s 7.10s p=0.059 n=6
Bind Time 2.60s (± 0.29%) 2.60s (± 0.29%) ~ 2.59s 2.61s p=0.289 n=6
Check Time 49.54s (± 0.10%) 49.76s (± 0.06%) +0.21s (+ 0.43%) 49.71s 49.79s p=0.005 n=6
Emit Time 4.25s (± 0.20%) 4.26s (± 0.12%) ~ 4.26s 4.27s p=0.078 n=6
Total Time 63.49s (± 0.09%) 63.67s (± 0.08%) +0.18s (+ 0.28%) 63.62s 63.75s p=0.005 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 2,382,443k (± 0.00%) 2,380,611k (± 0.00%) -1,832k (- 0.08%) 2,380,584k 2,380,616k p=0.004 n=6
Parse Time 5.91s (± 0.18%) 5.89s (± 0.23%) -0.02s (- 0.34%) 5.88s 5.92s p=0.034 n=6
Bind Time 2.04s (± 0.44%) 2.03s (± 0.20%) ~ 2.03s 2.04s p=0.086 n=6
Check Time 40.55s (± 0.11%) 40.66s (± 0.05%) +0.10s (+ 0.25%) 40.63s 40.69s p=0.008 n=6
Emit Time 3.45s (± 0.16%) 3.46s (± 0.00%) ~ 3.46s 3.46s p=0.071 n=6
Total Time 51.99s (± 0.09%) 52.06s (± 0.06%) +0.07s (+ 0.13%) 52.03s 52.11s p=0.030 n=6
self-compiler - node (v18.15.0, x64)
Memory used 419,387k (± 0.00%) 419,390k (± 0.00%) +3k (+ 0.00%) 419,390k 419,390k p=0.001 n=6
Parse Time 2.63s (± 0.00%) 2.63s (± 0.00%) ~ 2.63s 2.63s p=1.000 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.00%) ~ 1.11s 1.11s p=0.405 n=6
Check Time 15.67s (± 0.07%) 15.65s (± 0.12%) ~ 15.63s 15.68s p=0.123 n=6
Emit Time 1.14s (± 0.00%) 1.14s (± 0.00%) ~ 1.14s 1.14s p=1.000 n=6
Total Time 20.55s (± 0.04%) 20.53s (± 0.09%) -0.02s (- 0.12%) 20.50s 20.55s p=0.028 n=6
ts-pre-modules - node (v18.15.0, x64)
Memory used 368,906k (± 0.00%) 368,913k (± 0.00%) +7k (+ 0.00%) 368,913k 368,913k p=0.001 n=6
Parse Time 3.62s (± 0.23%) 3.63s (± 0.29%) ~ 3.61s 3.64s p=0.865 n=6
Bind Time 1.75s (± 0.00%) 1.75s (± 0.00%) ~ 1.75s 1.75s p=1.000 n=6
Check Time 19.76s (± 0.21%) 19.74s (± 0.14%) ~ 19.71s 19.78s p=0.628 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 25.13s (± 0.14%) 25.12s (± 0.13%) ~ 25.08s 25.16s p=1.000 n=6
vscode - node (v18.15.0, x64)
Memory used 2,916,173k (± 0.00%) 2,916,173k (± 0.00%) ~ 2,916,173k 2,916,173k p=1.000 n=6
Parse Time 14.10s (± 0.18%) 14.08s (± 0.08%) ~ 14.07s 14.10s p=0.117 n=6
Bind Time 4.21s (± 0.32%) 4.20s (± 0.00%) -0.01s (- 0.32%) 4.20s 4.20s p=0.008 n=6
Check Time 74.85s (± 0.11%) 74.33s (± 0.12%) -0.53s (- 0.71%) 74.24s 74.49s p=0.005 n=6
Emit Time 19.50s (± 0.07%) 19.52s (± 0.19%) ~ 19.49s 19.59s p=0.408 n=6
Total Time 112.66s (± 0.06%) 112.12s (± 0.08%) -0.55s (- 0.48%) 112.05s 112.29s p=0.005 n=6
webpack - node (v18.15.0, x64)
Memory used 409,339k (± 0.00%) 409,348k (± 0.00%) +9k (+ 0.00%) 409,348k 409,348k p=0.001 n=6
Parse Time 3.24s (± 0.16%) 3.24s (± 0.25%) ~ 3.23s 3.25s p=0.929 n=6
Bind Time 1.44s (± 0.00%) 1.44s (± 0.36%) ~ 1.43s 1.44s p=0.174 n=6
Check Time 14.34s (± 0.08%) 14.40s (± 0.08%) +0.06s (+ 0.43%) 14.39s 14.42s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 19.01s (± 0.07%) 19.07s (± 0.05%) +0.06s (+ 0.33%) 19.06s 19.09s p=0.005 n=6
xstate-main - node (v18.15.0, x64)
Memory used 458,944k (± 0.00%) 458,935k (± 0.00%) -9k (- 0.00%) 458,935k 458,935k p=0.001 n=6
Parse Time 3.88s (± 0.16%) 3.88s (± 0.27%) ~ 3.87s 3.90s p=0.388 n=6
Bind Time 1.68s (± 0.00%) 1.68s (± 0.24%) ~ 1.68s 1.69s p=0.405 n=6
Check Time 22.21s (± 0.04%) 22.19s (± 0.09%) -0.02s (- 0.11%) 22.17s 22.22s p=0.050 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.77s (± 0.07%) 27.76s (± 0.05%) ~ 27.74s 27.78s p=0.142 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,555ms (± 0.31%) 3,538ms (± 1.02%) ~ 3,487ms 3,574ms p=0.689 n=6
Req 2 - geterr 7,496ms (± 0.16%) 7,487ms (± 0.20%) ~ 7,468ms 7,506ms p=0.423 n=6
Req 3 - references 425ms (± 0.10%) 424ms (± 0.21%) ~ 423ms 425ms p=0.086 n=6
Req 4 - navto 333ms (± 0.70%) 333ms (± 0.12%) ~ 333ms 334ms p=0.584 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 138ms (± 0.37%) 137ms (± 0.00%) -1ms (- 0.48%) 137ms 137ms p=0.025 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,814ms (± 0.87%) 3,784ms (± 0.80%) ~ 3,743ms 3,810ms p=0.127 n=6
Req 2 - geterr 5,631ms (± 0.10%) 5,633ms (± 0.11%) ~ 5,626ms 5,641ms p=0.630 n=6
Req 3 - references 455ms (± 0.18%) 454ms (± 0.43%) ~ 451ms 456ms p=0.446 n=6
Req 4 - navto 337ms (± 0.35%) 337ms (± 0.24%) ~ 336ms 338ms p=0.498 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 122ms (± 0.67%) 122ms (± 0.00%) ~ 122ms 122ms p=0.405 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,672ms (± 0.08%) 2,675ms (± 0.09%) ~ 2,671ms 2,678ms p=0.064 n=6
Req 2 - geterr 1,481ms (± 0.12%) 1,482ms (± 0.12%) ~ 1,479ms 1,484ms p=0.330 n=6
Req 3 - references 114ms (± 0.00%) 114ms (± 0.00%) ~ 114ms 114ms p=1.000 n=6
Req 4 - navto 354ms (± 0.23%) 353ms (± 0.16%) -1ms (- 0.33%) 352ms 353ms p=0.025 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 285ms (± 0.14%) 286ms (± 0.19%) ~ 285ms 286ms p=0.282 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 235.54ms (± 0.14%) 238.12ms (± 0.17%) +2.57ms (+ 1.09%) 236.35ms 245.28ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 359.37ms (± 0.28%) 358.22ms (± 0.27%) -1.15ms (- 0.32%) 350.72ms 365.67ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 233.13ms (± 0.10%) 232.94ms (± 0.12%) -0.19ms (- 0.08%) 232.12ms 238.74ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 347.60ms (± 0.26%) 346.23ms (± 0.28%) -1.36ms (- 0.39%) 338.62ms 354.68ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

noisy noisy...

@jakebailey jakebailey merged commit 72f413c into microsoft:main Apr 17, 2024
@jakebailey jakebailey deleted the remove-originalKeywordKind branch April 17, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@rbuckton rbuckton rbuckton approved these changes

Assignees

@DanielRosenwasser DanielRosenwasser

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment with removing originalKeywordKind from every Identifier
4 participants
@jakebailey @typescript-bot @DanielRosenwasser @rbuckton