Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for fixed declaration emit type parameter leak #58208

Closed
wants to merge 1 commit into from
Closed

Add test for fixed declaration emit type parameter leak #58208

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

Closes #44727, which was actually fixed by #57772.

@jakebailey
Copy link
Member Author

That or it's not fixed, if this type were to be inferred somehow?

@weswigham
Copy link
Member

That or it's not fixed, if this type were to be inferred somehow?

If you add a , prop = [null as any as BrokenType<any>][0] does it repro? Looks like it does on the playground.

@jakebailey
Copy link
Member Author

Sure does, so, not fixed. Oh well!

@jakebailey jakebailey closed this Apr 16, 2024
@jakebailey jakebailey deleted the fix-44727 branch April 16, 2024 00:11
@weswigham
Copy link
Member

If you want a fix, the first block in the old related PR (replacing Independent type parameters in the emit with unknown) is probably still the way to go; I don't think the emit's changed all that much.

@jakebailey jakebailey restored the fix-44727 branch April 16, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaration emit incorrectly prints uninstantiated generic type
2 participants
@jakebailey @weswigham