Fixed widening errors locations in union-normalized object literal types #58157

Andarist · 2024-04-12T07:50:27Z

Andarist · 2024-04-13T17:28:00Z

@jakebailey could u build a TS playground here?

jakebailey · 2024-04-13T18:01:28Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-04-13T18:01:35Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	❌ Results
`pack this`	✅ Started	✅ Results

Andarist · 2024-04-13T18:02:18Z

Thank you! ❤️

typescript-bot · 2024-04-13T18:06:57Z

@jakebailey, the perf run you requested failed. You can check the log here.

typescript-bot · 2024-04-13T18:09:16Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161203/artifacts?artifactName=tgz&fileId=CE3F941F78306DD691538893971F42892594430B83E45E9661776AB7208E1D7E02&fileName=/typescript-5.5.0-insiders.20240413.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58157-5".;

jakebailey · 2024-04-13T18:19:24Z

@typescript-bot perf test this

typescript-bot · 2024-04-13T18:19:26Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-04-13T18:20:39Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-13T18:29:00Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58157/merge:

Everything looks good!

typescript-bot · 2024-04-13T18:59:42Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{297,032k (± 0.01%)}	_{296,999k (± 0.01%)}	_~	_296,970k	_297,037k	_{p=0.078 n=6}
_{Parse Time}	_{4.04s (± 0.14%)}	_{4.05s (± 0.46%)}	_~	_4.03s	_4.08s	_{p=0.498 n=6}
_{Bind Time}	_{1.21s (± 0.43%)}	_{1.21s (± 0.69%)}	_~	_1.21s	_1.23s	_{p=0.923 n=6}
_{Check Time}	_{12.12s (± 0.26%)}	_{12.11s (± 0.32%)}	_~	_12.07s	_12.17s	_{p=0.518 n=6}
_{Emit Time}	_{10.51s (± 0.26%)}	_{10.51s (± 0.42%)}	_~	_10.45s	_10.56s	_{p=1.000 n=6}
_{Total Time}	_{27.89s (± 0.10%)}	_{27.88s (± 0.24%)}	_~	_27.79s	_27.96s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,374k (± 0.76%)}	_{193,001k (± 1.00%)}	_~	_191,720k	_195,514k	_{p=0.873 n=6}
_{Parse Time}	_{2.02s (± 1.06%)}	_{2.02s (± 0.81%)}	_~	_2.00s	_2.04s	_{p=1.000 n=6}
_{Bind Time}	_{1.06s (± 0.60%)}	_{1.07s (± 1.28%)}	_~	_1.05s	_1.08s	_{p=0.362 n=6}
_{Check Time}	_{14.07s (± 0.24%)}	_{14.07s (± 0.28%)}	_~	_14.02s	_14.12s	_{p=1.000 n=6}
_{Emit Time}	_{3.86s (± 0.88%)}	_{3.86s (± 0.66%)}	_~	_3.83s	_3.89s	_{p=0.744 n=6}
_{Total Time}	_{21.01s (± 0.28%)}	_{21.02s (± 0.13%)}	_~	_20.99s	_21.06s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{348,882k (± 0.00%)}	_{348,858k (± 0.01%)}	_~	_348,830k	_348,894k	_{p=0.128 n=6}
_{Parse Time}	_{3.85s (± 0.64%)}	_{3.83s (± 0.85%)}	_~	_3.79s	_3.89s	_{p=0.331 n=6}
_{Bind Time}	_{1.33s (± 0.00%)}	_{1.32s (± 0.39%)}	_{-0.01s (- 1.00%)}	_1.31s	_1.32s	_{p=0.002 n=6}
_{Check Time}	_{10.28s (± 0.35%)}	_{10.25s (± 0.57%)}	_~	_10.19s	_10.33s	_{p=0.297 n=6}
_{Emit Time}	_{5.99s (± 0.27%)}	_{5.98s (± 0.27%)}	_~	_5.96s	_6.00s	_{p=0.465 n=6}
_{Total Time}	_{21.44s (± 0.22%)}	_{21.38s (± 0.45%)}	_~	_21.30s	_21.51s	_{p=0.195 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,978k (± 0.01%)}	_{302,981k (± 0.01%)}	_~	_302,947k	_303,015k	_{p=1.000 n=6}
_{Parse Time}	_{2.03s (± 1.10%)}	_{2.03s (± 0.80%)}	_~	_2.01s	_2.05s	_{p=0.514 n=6}
_{Bind Time}	_{0.98s (± 0.64%)}	_{0.98s (± 0.64%)}	_~	_0.97s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{6.45s (± 0.76%)}	_{6.43s (± 0.30%)}	_~	_6.41s	_6.46s	_{p=0.294 n=6}
_{Emit Time}	_{3.58s (± 0.65%)}	_{3.58s (± 0.39%)}	_~	_3.56s	_3.60s	_{p=0.871 n=6}
_{Total Time}	_{13.04s (± 0.25%)}	_{13.02s (± 0.17%)}	_~	_12.99s	_13.05s	_{p=0.333 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,615k (± 0.01%)}	_{511,588k (± 0.01%)}	_~	_511,556k	_511,634k	_{p=0.149 n=6}
_{Parse Time}	_{3.26s (± 0.78%)}	_{3.28s (± 0.71%)}	_~	_3.26s	_3.32s	_{p=0.288 n=6}
_{Bind Time}	_{1.18s (± 0.71%)}	_{1.18s (± 0.87%)}	_~	_1.17s	_1.20s	_{p=0.788 n=6}
_{Check Time}	_{20.48s (± 0.31%)}	_{20.51s (± 0.33%)}	_~	_20.38s	_20.56s	_{p=0.293 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.93s (± 0.26%)}	_{24.98s (± 0.30%)}	_~	_24.83s	_25.04s	_{p=0.199 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,748,652k (± 0.00%)}	_{1,748,679k (± 0.00%)}	_~	_1,748,605k	_1,748,729k	_{p=0.378 n=6}
_{Parse Time}	_{9.93s (± 0.36%)}	_{9.97s (± 0.87%)}	_~	_9.87s	_10.12s	_{p=0.469 n=6}
_{Bind Time}	_{3.34s (± 0.54%)}	_{3.33s (± 0.45%)}	_~	_3.32s	_3.36s	_{p=0.683 n=6}
_{Check Time}	_{81.87s (± 0.37%)}	_{81.80s (± 0.25%)}	_~	_81.57s	_82.05s	_{p=0.575 n=6}
_{Emit Time}	_{0.20s (± 3.79%)}	_{0.20s (± 5.95%)}	_~	_0.19s	_0.22s	_{p=0.503 n=6}
_{Total Time}	_{95.34s (± 0.29%)}	_{95.31s (± 0.19%)}	_~	_95.09s	_95.56s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,306,654k (± 0.03%)}	_{2,306,604k (± 0.03%)}	_~	_2,305,540k	_2,307,625k	_{p=0.936 n=6}
_{Parse Time}	_{7.39s (± 1.35%)}	_{7.36s (± 0.48%)}	_~	_7.32s	_7.40s	_{p=0.229 n=6}
_{Bind Time}	_{2.75s (± 0.56%)}	_{2.75s (± 0.63%)}	_~	_2.73s	_2.77s	_{p=0.936 n=6}
_{Check Time}	_{49.27s (± 0.42%)}	_{49.14s (± 0.57%)}	_~	_48.96s	_49.69s	_{p=0.173 n=6}
_{Emit Time}	_{4.00s (± 4.04%)}	_{4.00s (± 5.08%)}	_~	_3.78s	_4.26s	_{p=0.810 n=6}
_{Total Time}	_{63.42s (± 0.30%)}	_{63.27s (± 0.47%)}	_~	_62.96s	_63.79s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,406,187k (± 2.48%)}	_{2,381,526k (± 0.03%)}	_~	_2,380,568k	_2,382,587k	_{p=0.378 n=6}
_{Parse Time}	_{6.22s (± 0.74%)}	_{6.19s (± 1.17%)}	_~	_6.09s	_6.28s	_{p=0.378 n=6}
_{Bind Time}	_{2.08s (± 0.73%)}	_{2.06s (± 0.73%)}	_~	_2.04s	_2.08s	_{p=0.243 n=6}
_{Check Time}	_{40.14s (± 0.29%)}	_{40.10s (± 0.46%)}	_~	_39.84s	_40.40s	_{p=0.575 n=6}
_{Emit Time}	_{3.17s (± 3.21%)}	_{3.14s (± 2.83%)}	_~	_2.98s	_3.22s	_{p=0.748 n=6}
_{Total Time}	_{51.60s (± 0.37%)}	_{51.51s (± 0.20%)}	_~	_51.35s	_51.60s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{419,093k (± 0.01%)}	_{419,084k (± 0.01%)}	_~	_419,054k	_419,116k	_{p=0.936 n=6}
_{Parse Time}	_{3.40s (± 0.89%)}	_{3.42s (± 0.84%)}	_~	_3.37s	_3.45s	_{p=0.295 n=6}
_{Bind Time}	_{1.31s (± 1.40%)}	_{1.31s (± 1.22%)}	_~	_1.29s	_1.34s	_{p=0.933 n=6}
_{Check Time}	_{18.00s (± 0.34%)}	_{18.01s (± 0.30%)}	_~	_17.96s	_18.09s	_{p=0.747 n=6}
_{Emit Time}	_{1.36s (± 1.70%)}	_{1.36s (± 1.59%)}	_~	_1.33s	_1.38s	_{p=0.935 n=6}
_{Total Time}	_{24.06s (± 0.30%)}	_{24.10s (± 0.14%)}	_~	_24.07s	_24.15s	_{p=0.570 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,913,589k (± 0.00%)}	_{2,913,560k (± 0.00%)}	_~	_2,913,517k	_2,913,604k	_{p=0.378 n=6}
_{Parse Time}	_{16.45s (± 0.10%)}	_{16.47s (± 0.31%)}	_~	_16.40s	_16.53s	_{p=0.334 n=6}
_{Bind Time}	_{4.89s (± 0.53%)}	_{4.93s (± 2.09%)}	_~	_4.85s	_5.13s	_{p=0.744 n=6}
_{Check Time}	_{87.73s (± 0.17%)}	_{88.53s (± 2.18%)}	_~	_87.28s	_92.38s	_{p=0.810 n=6}
_{Emit Time}	_{23.72s (± 0.90%)}	_{23.71s (± 0.74%)}	_~	_23.56s	_24.03s	_{p=1.000 n=6}
_{Total Time}	_{132.79s (± 0.22%)}	_{133.64s (± 1.44%)}	_~	_132.31s	_137.49s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{409,400k (± 0.01%)}	_{409,354k (± 0.01%)}	_~	_409,300k	_409,432k	_{p=0.128 n=6}
_{Parse Time}	_{3.27s (± 0.63%)}	_{3.25s (± 1.29%)}	_~	_3.18s	_3.30s	_{p=0.685 n=6}
_{Bind Time}	_{1.38s (± 0.00%)}	_{1.38s (± 0.59%)}	_~	_1.37s	_1.39s	_{p=0.290 n=6}
_{Check Time}	_{14.37s (± 0.14%)}	_{14.38s (± 0.32%)}	_~	_14.33s	_14.44s	_{p=0.808 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{19.02s (± 0.17%)}	_{19.00s (± 0.43%)}	_~	_18.91s	_19.11s	_{p=0.687 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{671,886k (± 0.01%)}	_{671,909k (± 0.01%)}	_~	_671,833k	_672,083k	_{p=0.810 n=6}
_{Parse Time}	_{3.40s (± 0.37%)}	_{3.41s (± 0.49%)}	_~	_3.39s	_3.43s	_{p=0.195 n=6}
_{Bind Time}	_{1.57s (± 0.26%)}	_{1.57s (± 0.26%)}	_~	_1.56s	_1.57s	_{p=1.000 n=6}
_{Check Time}	_{2.90s (± 0.34%)}	_{2.91s (± 0.57%)}	_~	_2.89s	_2.93s	_{p=0.318 n=6}
_{Emit Time}	_{0.02s (±18.82%)}	_{0.02s (± 0.00%)}	_~	_0.02s	_0.02s	_{p=0.405 n=6}
_{Total Time}	_{7.89s (± 0.24%)}	_{7.91s (± 0.21%)}	_~	_7.89s	_7.93s	_{p=0.416 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,502ms (± 0.51%)}	_{3,510ms (± 0.95%)}	_~	_3,452ms	_3,548ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{7,652ms (± 1.80%)}	_{7,663ms (± 1.96%)}	_~	_7,528ms	_7,854ms	_{p=0.936 n=6}
_{Req 3 - references}	_{429ms (± 0.65%)}	_{429ms (± 1.64%)}	_~	_421ms	_442ms	_{p=0.628 n=6}
_{Req 4 - navto}	_{337ms (± 1.07%)}	_{336ms (± 1.15%)}	_~	_329ms	_340ms	_{p=0.870 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{118ms (± 8.53%)}	_{117ms (± 9.29%)}	_~	_108ms	_137ms	_{p=0.628 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,484ms (± 1.42%)}	_{2,490ms (± 0.92%)}	_~	_2,455ms	_2,517ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{3,934ms (± 1.93%)}	_{3,926ms (± 1.87%)}	_~	_3,826ms	_3,979ms	_{p=0.298 n=6}
_{Req 3 - references}	_{301ms (± 1.98%)}	_{301ms (± 1.56%)}	_~	_296ms	_308ms	_{p=0.628 n=6}
_{Req 4 - navto}	_{226ms (± 0.52%)}	_{226ms (± 0.79%)}	_~	_223ms	_228ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 5.99%)}	_{77ms (± 7.24%)}	_~	_73ms	_84ms	_{p=0.566 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,284ms (± 6.54%)}	_{3,288ms (± 6.24%)}	_~	_3,199ms	_3,707ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{1,755ms (± 1.07%)}	_{1,898ms (±12.41%)}	_~	_1,736ms	_2,228ms	_{p=0.873 n=6}
_{Req 3 - references}	_{173ms (±11.57%)}	_{170ms (± 9.01%)}	_~	_155ms	_187ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{512ms (± 7.55%)}	_{498ms (±10.17%)}	_~	_431ms	_534ms	_{p=0.689 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{436ms (± 8.75%)}	_{423ms (±10.43%)}	_~	_365ms	_460ms	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.44ms (± 0.18%)}	_{153.34ms (± 0.17%)}	_{-0.10ms (- 0.06%)}	_152.21ms	_157.91ms	_{p=0.001 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.61ms (± 0.15%)}	_{227.38ms (± 0.16%)}	_{-0.23ms (- 0.10%)}	_226.10ms	_233.49ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{224.74ms (± 0.16%)}	_{224.67ms (± 0.16%)}	_~	_222.98ms	_227.29ms	_{p=0.116 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.93ms (± 0.17%)}	_{223.02ms (± 0.19%)}	_{+0.10ms (+ 0.04%)}	_221.25ms	_229.95ms	_{p=0.040 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-13T19:46:42Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58157/merge:

Everything looks good!

…or-location-obj-literal-union-normalization

Fixed widening errors locations in union-normalized object literal types

b9877df

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 12, 2024

Merge remote-tracking branch 'origin/main' into fix/noimplicitany-err…

42d77b0

…or-location-obj-literal-union-normalization

sandersn assigned gabritto Jun 14, 2024

sandersn requested review from gabritto and navya9singh June 14, 2024 17:50

gabritto approved these changes Jun 14, 2024

View reviewed changes

gabritto merged commit 0ca1973 into microsoft:main Jun 14, 2024

Andarist deleted the fix/noimplicitany-error-location-obj-literal-union-normalization branch June 15, 2024 08:30

Andarist mentioned this pull request Jun 15, 2024

Fixed propagating object flags when dealing with spreads #58180

Open

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed widening errors locations in union-normalized object literal types #58157

Fixed widening errors locations in union-normalized object literal types #58157

Uh oh!

Andarist commented Apr 12, 2024

Uh oh!

Andarist commented Apr 13, 2024

Uh oh!

jakebailey commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 •

edited

Loading

Uh oh!

Andarist commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 •

edited

Loading

Uh oh!

jakebailey commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

tsc

tsserver

startup

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

Uh oh!

Fixed widening errors locations in union-normalized object literal types #58157

Fixed widening errors locations in union-normalized object literal types #58157

Uh oh!

Conversation

Andarist commented Apr 12, 2024

Uh oh!

Andarist commented Apr 13, 2024

Uh oh!

jakebailey commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andarist commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

typescript-bot commented Apr 13, 2024

tsc

tsserver

startup

Uh oh!

typescript-bot commented Apr 13, 2024

Uh oh!

Uh oh!

typescript-bot commented Apr 13, 2024 •

edited

Loading

typescript-bot commented Apr 13, 2024 •

edited

Loading

typescript-bot commented Apr 13, 2024 •

edited

Loading