Fixed na issue with evaluator using binding element initializers as const values #55910

Andarist · 2023-09-29T12:55:38Z

…onst values

Andarist · 2023-09-29T12:56:38Z

src/compiler/checker.ts

                        if (isConstantVariable(symbol)) {
                            const declaration = symbol.valueDeclaration as VariableDeclaration | undefined;
-                            if (declaration && !declaration.type && declaration.initializer && (!location || declaration !== location && isBlockScopedNameDeclaredBeforeUse(declaration, location))) {
+                            if (declaration?.kind === SyntaxKind.VariableDeclaration && !declaration.type && declaration.initializer && (!location || declaration !== location && isBlockScopedNameDeclaredBeforeUse(declaration, location))) {


alternatively, I could check if the parent is not a BindingElement

Would that break on parameters? I guess not, since isConstantVariable won't be true.

I'll also note that this feels weird because declaration is VariableDeclaration which must have kind === SyntaxKind.VariableDeclaration.

I'll also note that this feels weird because declaration is VariableDeclaration which must have kind === SyntaxKind.VariableDeclaration.

Good catch! I didn't notice it. It is VariableDeclaration just because of the cast - so I'll make that cast more accurate in a second :)

jakebailey · 2023-09-29T18:56:40Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-09-29T18:56:42Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 8cd9111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T18:56:42Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 8cd9111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T18:56:42Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 8cd9111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T18:56:42Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 8cd9111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T19:14:28Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55910/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-29T19:35:22Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,063k (± 0.02%)}	_{295,058k (± 0.01%)}	_~	_295,032k	_295,098k	_{p=0.936 n=6}
_{Parse Time}	_{2.64s (± 1.01%)}	_{2.63s (± 0.34%)}	_~	_2.62s	_2.64s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 1.47%)}	_{0.84s (± 1.23%)}	_~	_0.83s	_0.85s	_{p=0.752 n=6}
_{Check Time}	_{8.07s (± 0.23%)}	_{8.05s (± 0.37%)}	_~	_8.01s	_8.09s	_{p=0.411 n=6}
_{Emit Time}	_{7.04s (± 0.52%)}	_{7.04s (± 0.46%)}	_~	_6.99s	_7.07s	_{p=1.000 n=6}
_{Total Time}	_{18.58s (± 0.24%)}	_{18.56s (± 0.13%)}	_~	_18.53s	_18.60s	_{p=0.686 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,477k (± 1.34%)}	_{191,686k (± 1.28%)}	_~	_190,634k	_196,710k	_{p=0.298 n=6}
_{Parse Time}	_{1.34s (± 1.21%)}	_{1.34s (± 0.73%)}	_~	_1.32s	_1.35s	_{p=0.654 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.17s (± 0.82%)}	_{9.18s (± 0.70%)}	_~	_9.11s	_9.28s	_{p=0.747 n=6}
_{Emit Time}	_{2.63s (± 0.42%)}	_{2.63s (± 0.46%)}	_~	_2.61s	_2.64s	_{p=0.739 n=6}
_{Total Time}	_{13.87s (± 0.60%)}	_{13.88s (± 0.46%)}	_~	_13.81s	_13.99s	_{p=0.810 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,293k (± 0.01%)}	_{347,303k (± 0.00%)}	_~	_347,279k	_347,320k	_{p=0.378 n=6}
_{Parse Time}	_{2.45s (± 0.61%)}	_{2.47s (± 0.17%)}	_~	_2.46s	_2.47s	_{p=0.071 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{6.89s (± 0.55%)}	_{6.90s (± 0.46%)}	_~	_6.86s	_6.94s	_{p=0.809 n=6}
_{Emit Time}	_{4.02s (± 0.44%)}	_{4.03s (± 0.34%)}	_~	_4.01s	_4.05s	_{p=0.192 n=6}
_{Total Time}	_{14.31s (± 0.34%)}	_{14.34s (± 0.30%)}	_~	_14.28s	_14.38s	_{p=0.378 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,585k (± 0.01%)}	_{302,556k (± 0.01%)}	_~	_302,525k	_302,636k	_{p=0.297 n=6}
_{Parse Time}	_{1.99s (± 0.32%)}	_{2.00s (± 0.86%)}	_~	_1.98s	_2.02s	_{p=0.303 n=6}
_{Bind Time}	_{1.01s (± 0.51%)}	_{1.00s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=0.672 n=6}
_{Check Time}	_{6.27s (± 0.43%)}	_{6.27s (± 0.39%)}	_~	_6.23s	_6.30s	_{p=0.871 n=6}
_{Emit Time}	_{3.58s (± 0.58%)}	_{3.57s (± 0.38%)}	_~	_3.55s	_3.59s	_{p=0.869 n=6}
_{Total Time}	_{12.84s (± 0.30%)}	_{12.85s (± 0.30%)}	_~	_12.80s	_12.89s	_{p=0.809 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,513k (± 0.01%)}	_{470,496k (± 0.00%)}	_~	_470,475k	_470,541k	_{p=0.336 n=6}
_{Parse Time}	_{2.57s (± 0.57%)}	_{2.58s (± 0.32%)}	_~	_2.57s	_2.59s	_{p=0.284 n=6}
_{Bind Time}	_{0.99s (± 0.84%)}	_{0.99s (± 1.05%)}	_~	_0.98s	_1.01s	_{p=1.000 n=6}
_{Check Time}	_{16.63s (± 0.62%)}	_{16.65s (± 0.47%)}	_~	_16.55s	_16.79s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.19s (± 0.59%)}	_{20.21s (± 0.40%)}	_~	_20.10s	_20.35s	_{p=0.809 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,607k (± 0.01%)}	_{512,623k (± 0.01%)}	_~	_512,540k	_512,735k	_{p=0.810 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=0.273 n=6}
_{Bind Time}	_{1.55s (± 0.00%)}	_{1.54s (± 0.35%)}	_~	_1.54s	_1.55s	_{p=0.071 n=6}
_{Check Time}	_{2.83s (± 0.35%)}	_{2.84s (± 0.53%)}	_~	_2.83s	_2.87s	_{p=0.122 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.72s (± 0.13%)}	_{7.73s (± 0.29%)}	_~	_7.71s	_7.76s	_{p=0.745 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,370ms (± 0.88%)}	_{2,385ms (± 1.41%)}	_~	_2,322ms	_2,412ms	_{p=0.229 n=6}
_{Req 2 - geterr}	_{5,341ms (± 1.53%)}	_{5,288ms (± 0.50%)}	_~	_5,244ms	_5,324ms	_{p=0.471 n=6}
_{Req 3 - references}	_{331ms (± 1.39%)}	_{341ms (± 6.96%)}	_~	_326ms	_388ms	_{p=0.629 n=6}
_{Req 4 - navto}	_{276ms (± 0.62%)}	_{277ms (± 0.58%)}	_~	_275ms	_280ms	_{p=0.531 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 9.81%)}	_{76ms (± 2.94%)}	_~	_74ms	_80ms	_{p=0.411 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,452ms (± 1.18%)}	_{2,491ms (± 0.53%)}	_{+39ms (+ 1.59%)}	_2,473ms	_2,506ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{4,159ms (± 1.85%)}	_{4,065ms (± 0.25%)}	_~	_4,053ms	_4,081ms	_{p=0.092 n=6}
_{Req 3 - references}	_{337ms (± 1.70%)}	_{341ms (± 1.37%)}	_~	_335ms	_347ms	_{p=0.135 n=6}
_{Req 4 - navto}	_{283ms (± 0.18%)}	_{285ms (± 0.37%)}	_~	_283ms	_286ms	_{p=0.051 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.32%)}	_{83ms (± 6.68%)}	_~	_76ms	_87ms	_{p=0.342 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,585ms (± 0.50%)}	_{2,594ms (± 0.83%)}	_~	_2,561ms	_2,618ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,722ms (± 2.14%)}	_{1,704ms (± 2.78%)}	_~	_1,653ms	_1,757ms	_{p=0.336 n=6}
_{Req 3 - references}	_{110ms (± 7.41%)}	_{113ms (± 7.33%)}	_~	_105ms	_124ms	_{p=0.366 n=6}
_{Req 4 - navto}	_{360ms (± 0.61%)}	_{360ms (± 0.38%)}	_~	_358ms	_361ms	_{p=0.869 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{311ms (± 1.04%)}	_{307ms (± 2.09%)}	_~	_296ms	_314ms	_{p=0.165 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.84ms (± 0.18%)}	_{151.74ms (± 0.17%)}	_{-0.10ms (- 0.07%)}	_150.81ms	_155.05ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.49ms (± 0.16%)}	_{227.26ms (± 0.17%)}	_{-0.22ms (- 0.10%)}	_225.91ms	_232.83ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.83ms (± 0.17%)}	_{228.90ms (± 0.16%)}	_{+0.06ms (+ 0.03%)}	_227.36ms	_232.91ms	_{p=0.047 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.48ms (± 0.15%)}	_{228.59ms (± 0.19%)}	_{+0.11ms (+ 0.05%)}	_226.96ms	_236.70ms	_{p=0.034 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-29T20:20:55Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55910/merge:

Everything looks good!

typescript-bot · 2023-09-29T20:24:37Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Fixed na issue with evaluator using binding element initializers as c…

7f1543c

…onst values

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 29, 2023

Andarist commented Sep 29, 2023

View reviewed changes

Andarist added 2 commits September 29, 2023 19:22

Make the cast more accurate

c0f986d

ditch the cast altogether

8cd9111

jakebailey approved these changes Sep 29, 2023

View reviewed changes

jakebailey merged commit 38d09d4 into microsoft:main Sep 29, 2023

mjbvz mentioned this pull request Aug 24, 2018

"Quick info" and "go to definition" not working inside old school JavaScript constructor functions #26666

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Fixed na issue with evaluator using binding element initializers as const values #55910

Fixed na issue with evaluator using binding element initializers as const values #55910

Uh oh!

Conversation

Andarist commented Sep 29, 2023

Uh oh!

Andarist Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

Andarist Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading