fix(54992): Negative constant enums return number when toString is called #55031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
reviewed
Jul 15, 2023
Andarist
reviewed
Jul 15, 2023
Andarist
reviewed
Jul 15, 2023
Andarist
reviewed
Jul 15, 2023
|
Adding parenthesis could create other problems - but I guess that's not really possible since the emitter prefers semicolons. Is that right? Or am I missing some edge cases in which an accidental function call could be created? |
|
What happened to this PR? Was it totally wrong in some way? FWIW, here's what esbuild does; thankfully doesn't have this problem, but my recollection of this PR before it was force pushed to empty was that this PR matched. |
|
@jakebailey I've closed it in favor of @Andarist's PR. |
|
Which PR is that? #55018 is for a different bug, and I'm not seeing any other enum PRs... |
|
I believe @Andarist will create a new PR soon. |
|
here it is: #55065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.