support generic variant setter #55030

Zzzen · 2023-07-15T15:15:04Z

src/compiler/checker.ts

jakebailey · 2023-08-17T17:22:11Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-08-17T17:22:13Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at b1728a1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-17T17:22:13Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at b1728a1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-17T17:22:13Z

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at b1728a1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-17T17:22:13Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at b1728a1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-17T17:47:01Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55030/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55030/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-17T17:51:03Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,378k (± 0.01%)}	_{300,346k (± 0.01%)}	_{-33k (- 0.01%)}	_300,329k	_300,376k	_{p=0.030 n=6}
_{Parse Time}	_{3.02s (± 0.36%)}	_{3.02s (± 0.45%)}	_~	_3.00s	_3.04s	_{p=0.504 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=0.405 n=6}
_{Check Time}	_{9.49s (± 0.35%)}	_{9.49s (± 0.30%)}	_~	_9.46s	_9.54s	_{p=0.748 n=6}
_{Emit Time}	_{7.62s (± 0.41%)}	_{7.63s (± 0.16%)}	_~	_7.61s	_7.64s	_{p=0.869 n=6}
_{Total Time}	_{21.06s (± 0.34%)}	_{21.07s (± 0.16%)}	_~	_21.04s	_21.12s	_{p=0.809 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,876k (± 0.01%)}	_{193,892k (± 0.01%)}	_~	_193,876k	_193,901k	_{p=0.149 n=6}
_{Parse Time}	_{1.57s (± 1.45%)}	_{1.57s (± 0.78%)}	_~	_1.55s	_1.58s	_{p=0.930 n=6}
_{Bind Time}	_{0.79s (± 0.00%)}	_{0.79s (± 0.00%)}	_~	_0.79s	_0.79s	_{p=1.000 n=6}
_{Check Time}	_{9.95s (± 0.25%)}	_{9.91s (± 0.26%)}	_~	_9.87s	_9.94s	_{p=0.053 n=6}
_{Emit Time}	_{2.75s (± 0.44%)}	_{2.74s (± 0.23%)}	_~	_2.73s	_2.75s	_{p=0.344 n=6}
_{Total Time}	_{15.05s (± 0.26%)}	_{15.02s (± 0.21%)}	_~	_14.98s	_15.06s	_{p=0.167 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,119k (± 0.00%)}	_{347,119k (± 0.01%)}	_~	_347,077k	_347,138k	_{p=0.422 n=6}
_{Parse Time}	_{2.68s (± 0.44%)}	_{2.69s (± 0.30%)}	_~	_2.68s	_2.70s	_{p=0.401 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.41%)}	_~	_0.99s	_1.00s	_{p=0.405 n=6}
_{Check Time}	_{7.92s (± 0.29%)}	_{7.92s (± 0.40%)}	_~	_7.86s	_7.95s	_{p=0.871 n=6}
_{Emit Time}	_{4.26s (± 0.38%)}	_{4.27s (± 0.50%)}	_~	_4.24s	_4.30s	_{p=0.370 n=6}
_{Total Time}	_{15.85s (± 0.21%)}	_{15.86s (± 0.30%)}	_~	_15.77s	_15.90s	_{p=0.465 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,132k (± 0.01%)}	_{301,131k (± 0.01%)}	_~	_301,110k	_301,151k	_{p=1.000 n=6}
_{Parse Time}	_{2.18s (± 0.63%)}	_{2.19s (± 0.45%)}	_~	_2.18s	_2.20s	_{p=0.082 n=6}
_{Bind Time}	_{1.08s (± 5.97%)}	_{1.11s (± 0.00%)}	_~	_1.11s	_1.11s	_{p=0.295 n=6}
_{Check Time}	_{7.24s (± 0.46%)}	_{7.26s (± 0.40%)}	_~	_7.21s	_7.29s	_{p=0.376 n=6}
_{Emit Time}	_{3.97s (± 0.29%)}	_{3.97s (± 0.19%)}	_~	_3.96s	_3.98s	_{p=0.933 n=6}
_{Total Time}	_{14.47s (± 0.45%)}	_{14.53s (± 0.13%)}	_~	_14.50s	_14.55s	_{p=0.121 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,420k (± 0.01%)}	_{479,464k (± 0.01%)}	_~	_479,359k	_479,529k	_{p=0.230 n=6}
_{Parse Time}	_{3.15s (± 0.00%)}	_{3.15s (± 0.13%)}	_~	_3.15s	_3.16s	_{p=0.405 n=6}
_{Bind Time}	_{0.91s (± 0.45%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=0.405 n=6}
_{Check Time}	_{17.92s (± 0.32%)}	_{17.99s (± 0.36%)}	_~	_17.92s	_18.10s	_{p=0.149 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.98s (± 0.26%)}	_{22.05s (± 0.28%)}	_~	_21.98s	_22.16s	_{p=0.106 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,808k (± 0.01%)}	_{542,830k (± 0.01%)}	_~	_542,779k	_542,934k	_{p=0.298 n=6}
_{Parse Time}	_{3.70s (± 0.20%)}	_{3.69s (± 0.33%)}	_~	_3.68s	_3.71s	_{p=0.388 n=6}
_{Bind Time}	_{1.42s (± 4.38%)}	_{1.34s (± 0.39%)}	_{🟩-0.08s (- 5.87%)}	_1.33s	_1.34s	_{p=0.021 n=6}
_{Check Time}	_{3.22s (± 3.21%)}	_{3.34s (± 0.83%)}	_~	_3.31s	_3.38s	_{p=0.090 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.42s (± 0.52%)}	_{8.45s (± 0.31%)}	_~	_8.43s	_8.50s	_{p=0.054 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-08-17T18:50:03Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55030/merge:

Everything looks good!

typescript-bot · 2023-08-17T19:04:24Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-08-17T19:18:21Z

sigh

@typescript-bot run dt

typescript-bot · 2023-08-17T19:18:24Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at b1728a1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-17T21:29:37Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

jakebailey

LGTM now, but @weswigham may be able to poke holes.

support generic variant setter

651affd

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 15, 2023

sandersn assigned jakebailey Jul 28, 2023

sandersn requested review from weswigham and jakebailey July 28, 2023 23:54

jakebailey reviewed Jul 31, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

jakebailey requested changes Aug 15, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

jakebailey mentioned this pull request Aug 15, 2023

[experiment] remove a problematic optimization in instantiateSymbol #55388

Closed

simplify

b1728a1

jakebailey self-requested a review August 17, 2023 17:21

jakebailey approved these changes Aug 17, 2023

View reviewed changes

jakebailey merged commit c5f92d4 into microsoft:main Aug 29, 2023

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

support generic variant setter (microsoft#55030)

eaf81d3

support generic variant setter #55030

support generic variant setter #55030

Uh oh!

Conversation

Zzzen commented Jul 15, 2023

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Aug 17, 2023

Uh oh!

typescript-bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

typescript-bot commented Aug 17, 2023

Compiler

Uh oh!

typescript-bot commented Aug 17, 2023

Uh oh!

typescript-bot commented Aug 17, 2023

Uh oh!

jakebailey commented Aug 17, 2023

Uh oh!

typescript-bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

typescript-bot commented Aug 17, 2023 •

edited

Loading

typescript-bot commented Aug 17, 2023 •

edited

Loading

typescript-bot commented Aug 17, 2023 •

edited

Loading

typescript-bot commented Aug 17, 2023 •

edited

Loading

typescript-bot commented Aug 17, 2023 •

edited

Loading