Fixed an issue with constraint of an infer type parameter not being fully instantiatable by Andarist · Pull Request #54205 · microsoft/TypeScript

Andarist · 2023-05-10T09:34:11Z

…ully instantiatable

Andarist · 2023-05-10T10:06:19Z

src/compiler/checker.ts

    function maybeCloneTypeParameter(p: TypeParameter) {
        const constraint = getConstraintOfTypeParameter(p);
-        return constraint && (isGenericObjectType(constraint) || isGenericIndexType(constraint)) ? cloneTypeParameter(p) : p;
+        return constraint && couldContainTypeVariables(constraint) ? cloneTypeParameter(p) : p;


I keep thinking that perhaps there is a better check for this kind of thing - but I honestly don't know what it is. I already had a need for this a couple of times and I couldn't find anything else in the codebase that would already test this kind of stuff in a different way.

This function was introduced back in #31455; I suspect that it was a targeted fix and personally I'm partial to what you're changing it to (it makes sense to me as an optimization; if we always called clone, all tests pass, it's just slower).

@weswigham

jakebailey · 2023-05-10T15:19:22Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

typescript-bot · 2023-05-10T15:19:26Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0519dfa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-10T15:19:26Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0519dfa. You can monitor the build here.

typescript-bot · 2023-05-10T15:19:26Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 0519dfa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-10T15:19:26Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0519dfa. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-10T15:19:26Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 0519dfa. You can monitor the build here.

typescript-bot · 2023-05-10T15:19:27Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 0519dfa. You can monitor the build here.

typescript-bot · 2023-05-10T15:21:10Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/154118/artifacts?artifactName=tgz&fileId=EBD30EA9E7439D2A06D6AD86127F8115C8CFC1EE7CA43284406A7EFDD55BF31102&fileName=/typescript-5.1.0-insiders.20230510.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-54205-7".;

typescript-bot · 2023-05-10T15:35:09Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54205

_Metric	_main	₅₄₂₀₅	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,267k (± 0.01%)}	_{365,292k (± 0.01%)}	_~	_365,243k	_365,353k	_{p=0.298 n=6}
_{Parse Time}	_{3.56s (± 0.52%)}	_{3.57s (± 0.70%)}	_~	_3.54s	_3.61s	_{p=0.366 n=6}
_{Bind Time}	_{1.17s (± 0.47%)}	_{1.18s (± 1.03%)}	_~	_1.17s	_1.20s	_{p=0.855 n=6}
_{Check Time}	_{9.63s (± 0.46%)}	_{9.61s (± 0.25%)}	_~	_9.58s	_9.65s	_{p=0.571 n=6}
_{Emit Time}	_{7.89s (± 0.50%)}	_{7.88s (± 0.71%)}	_~	_7.84s	_7.99s	_{p=0.520 n=6}
_{Total Time}	_{22.25s (± 0.25%)}	_{22.25s (± 0.27%)}	_~	_22.17s	_22.34s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,306k (± 0.69%)}	_{192,714k (± 0.04%)}	_~	_192,635k	_192,808k	_{p=0.230 n=6}
_{Parse Time}	_{1.60s (± 1.96%)}	_{1.61s (± 2.27%)}	_~	_1.54s	_1.64s	_{p=0.625 n=6}
_{Bind Time}	_{0.83s (± 0.99%)}	_{0.83s (± 0.91%)}	_~	_0.82s	_0.84s	_{p=0.729 n=6}
_{Check Time}	_{10.33s (± 0.52%)}	_{10.38s (± 0.71%)}	_~	_10.28s	_10.44s	_{p=0.295 n=6}
_{Emit Time}	_{3.01s (± 0.56%)}	_{3.02s (± 0.95%)}	_~	_3.00s	_3.07s	_{p=0.683 n=6}
_{Total Time}	_{15.77s (± 0.50%)}	_{15.84s (± 0.56%)}	_~	_15.73s	_15.97s	_{p=0.230 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,860k (± 0.00%)}	_{345,863k (± 0.00%)}	_~	_345,848k	_345,876k	_{p=0.810 n=6}
_{Parse Time}	_{2.73s (± 0.71%)}	_{2.73s (± 0.19%)}	_~	_2.72s	_2.73s	_{p=1.000 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.08s (± 0.77%)}	_~	_1.08s	_1.10s	_{p=0.533 n=6}
_{Check Time}	_{7.86s (± 0.60%)}	_{7.89s (± 0.46%)}	_~	_7.83s	_7.93s	_{p=0.227 n=6}
_{Emit Time}	_{4.46s (± 0.98%)}	_{4.46s (± 0.67%)}	_~	_4.42s	_4.49s	_{p=0.627 n=6}
_{Total Time}	_{16.14s (± 0.55%)}	_{16.16s (± 0.39%)}	_~	_16.09s	_16.24s	_{p=0.688 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,083k (± 0.01%)}	_{300,119k (± 0.01%)}	_{+36k (+ 0.01%)}	_300,098k	_300,152k	_{p=0.031 n=6}
_{Parse Time}	_{2.17s (± 0.80%)}	_{2.18s (± 1.11%)}	_~	_2.16s	_2.23s	_{p=0.560 n=6}
_{Bind Time}	_{1.23s (± 0.61%)}	_{1.25s (± 0.44%)}	_{+0.02s (+ 1.36%)}	_1.24s	_1.25s	_{p=0.008 n=6}
_{Check Time}	_{7.28s (± 0.40%)}	_{7.32s (± 0.46%)}	_{+0.04s (+ 0.62%)}	_7.27s	_7.37s	_{p=0.042 n=6}
_{Emit Time}	_{4.34s (± 0.72%)}	_{4.35s (± 0.66%)}	_~	_4.31s	_4.39s	_{p=1.000 n=6}
_{Total Time}	_{15.02s (± 0.34%)}	_{15.10s (± 0.38%)}	_~	_15.04s	_15.19s	_{p=0.092 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,933k (± 0.01%)}	_{480,912k (± 0.00%)}	_~	_480,872k	_480,935k	_{p=0.471 n=6}
_{Parse Time}	_{3.25s (± 0.36%)}	_{3.25s (± 0.19%)}	_~	_3.24s	_3.26s	_{p=1.000 n=6}
_{Bind Time}	_{0.93s (± 0.59%)}	_{0.94s (± 0.43%)}	_~	_0.93s	_0.94s	_{p=0.282 n=6}
_{Check Time}	_{17.88s (± 1.60%)}	_{17.75s (± 0.45%)}	_~	_17.64s	_17.83s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.06s (± 1.35%)}	_{21.94s (± 0.35%)}	_~	_21.83s	_22.02s	_{p=0.748 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,416k (± 0.02%)}	_{560,442k (± 0.02%)}	_~	_560,335k	_560,604k	_{p=0.748 n=6}
_{Parse Time}	_{4.02s (± 0.34%)}	_{4.01s (± 0.27%)}	_~	_4.00s	_4.03s	_{p=0.066 n=6}
_{Bind Time}	_{1.76s (± 0.66%)}	_{1.76s (± 0.46%)}	_~	_1.75s	_1.77s	_{p=1.000 n=6}
_{Check Time}	_{3.06s (± 0.49%)}	_{3.08s (± 0.69%)}	_~	_3.06s	_3.11s	_{p=0.085 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 4.62%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.93s (± 0.21%)}	_{8.95s (± 0.20%)}	_~	_8.93s	_8.97s	_{p=0.126 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₂₀₅	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-05-10T17:00:02Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54205/merge:

Everything looks good!

typescript-bot · 2023-05-10T17:24:13Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

…ending-on-type-variables

Andarist · 2024-08-26T17:41:55Z

this was already fixed by #57362 so I opened a test-only PR here: #59760

Fixed an issue with constraint of an infer type parameter not being f…

0519dfa

…ully instantiatable

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 10, 2023

Andarist commented May 10, 2023

View reviewed changes

RyanCavanaugh assigned rbuckton May 10, 2023

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 10, 2023

sandersn requested a review from rbuckton May 22, 2023 23:38

Merge remote-tracking branch 'origin/main' into fix/infer-extends-dep…

7ea5eee

…ending-on-type-variables

Andarist closed this Aug 26, 2024

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

Andarist commented May 10, 2023

Uh oh!

Andarist May 10, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey May 10, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey commented May 10, 2023

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 10, 2023

Uh oh!

typescript-bot commented May 10, 2023

Uh oh!

typescript-bot commented May 10, 2023

Uh oh!

Andarist commented Aug 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading

typescript-bot commented May 10, 2023 •

edited

Loading