Skip to content

Add CI job that detects unused baselines #54141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2023

Conversation

jakebailey
Copy link
Member

This can catch things like #54140.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 4, 2023
@jakebailey jakebailey marked this pull request as ready for review May 4, 2023 23:25
run: |
if ! git diff --exit-code --quiet; then
echo "::group::npm test"
npm test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra test ensures that the tests still pass after the baselines are removed. But, I think I'm going to drop this, because theoretically anyone who fails this pass will delete the unused baselines and then push their code up, having it rerun.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This was really only a concern when we still had baselines that weren't produced by npm test, e.g. the docker and user baselines, which I have since removed.)

@jakebailey
Copy link
Member Author

@jakebailey jakebailey merged commit 910efac into microsoft:main May 5, 2023
@jakebailey jakebailey deleted the unused-baselines branch May 5, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants