Error on template tag inside callback/overload/typedef tag

[sandersn]

Fixes #52844

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 3efaa85. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 3efaa85. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 3efaa85. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 3efaa85. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 3efaa85. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54118

Metric	main	54118	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	365,264k (± 0.01%)	365,276k (± 0.01%)	~	365,234k	365,345k	p=0.470 n=6
Parse Time	3.53s (± 0.77%)	3.56s (± 0.73%)	~	3.52s	3.58s	p=0.168 n=6
Bind Time	1.17s (± 0.44%)	1.18s (± 0.44%)	~	1.17s	1.18s	p=0.311 n=6
Check Time	9.58s (± 0.57%)	9.59s (± 0.52%)	~	9.54s	9.66s	p=0.688 n=6
Emit Time	7.92s (± 0.82%)	7.93s (± 0.66%)	~	7.87s	8.00s	p=0.810 n=6
Total Time	22.20s (± 0.55%)	22.26s (± 0.48%)	~	22.14s	22.41s	p=0.470 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,729k (± 0.05%)	193,282k (± 0.65%)	~	192,701k	195,842k	p=0.261 n=6
Parse Time	1.59s (± 0.95%)	1.59s (± 0.40%)	~	1.58s	1.60s	p=0.391 n=6
Bind Time	0.82s (± 0.00%)	0.83s (± 0.99%)	~	0.82s	0.84s	p=0.073 n=6
Check Time	10.30s (± 0.29%)	10.32s (± 0.30%)	~	10.28s	10.35s	p=0.418 n=6
Emit Time	2.99s (± 0.44%)	3.00s (± 0.53%)	~	2.99s	3.03s	p=0.145 n=6
Total Time	15.71s (± 0.25%)	15.74s (± 0.12%)	~	15.72s	15.77s	p=0.102 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,841k (± 0.01%)	345,848k (± 0.01%)	~	345,799k	345,881k	p=0.575 n=6
Parse Time	2.70s (± 0.30%)	2.71s (± 0.54%)	~	2.69s	2.73s	p=0.284 n=6
Bind Time	1.08s (± 1.31%)	1.08s (± 0.48%)	~	1.08s	1.09s	p=0.667 n=6
Check Time	7.86s (± 0.53%)	7.84s (± 0.39%)	~	7.80s	7.89s	p=0.517 n=6
Emit Time	4.46s (± 0.39%)	4.50s (± 1.06%)	~	4.44s	4.58s	p=0.147 n=6
Total Time	16.11s (± 0.33%)	16.13s (± 0.46%)	~	16.03s	16.25s	p=0.810 n=6
TFS - node (v16.17.1, x64)
Memory used	300,127k (± 0.01%)	300,101k (± 0.01%)	~	300,072k	300,134k	p=0.173 n=6
Parse Time	2.15s (± 0.38%)	2.16s (± 0.25%)	~	2.15s	2.16s	p=0.088 n=6
Bind Time	1.23s (± 0.66%)	1.23s (± 0.66%)	~	1.22s	1.24s	p=0.204 n=6
Check Time	7.29s (± 0.46%)	7.26s (± 0.40%)	~	7.22s	7.29s	p=0.334 n=6
Emit Time	4.38s (± 0.55%)	4.38s (± 0.52%)	~	4.36s	4.42s	p=1.000 n=6
Total Time	15.05s (± 0.36%)	15.03s (± 0.33%)	~	14.95s	15.09s	p=0.687 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,585k (± 0.01%)	481,568k (± 0.01%)	~	481,540k	481,612k	p=0.336 n=6
Parse Time	3.24s (± 0.16%)	3.23s (± 0.53%)	~	3.21s	3.25s	p=0.548 n=6
Bind Time	0.94s (± 0.55%)	0.93s (± 0.59%)	~	0.93s	0.94s	p=0.640 n=6
Check Time	17.93s (± 0.41%)	17.81s (± 0.31%)	-0.12s (- 0.69%)	17.73s	17.88s	p=0.024 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.11s (± 0.36%)	21.97s (± 0.28%)	-0.14s (- 0.62%)	21.90s	22.06s	p=0.020 n=6
xstate - node (v16.17.1, x64)
Memory used	560,337k (± 0.01%)	560,460k (± 0.02%)	+122k (+ 0.02%)	560,375k	560,569k	p=0.013 n=6
Parse Time	3.99s (± 0.21%)	3.97s (± 0.44%)	~	3.96s	4.00s	p=0.166 n=6
Bind Time	1.76s (± 0.66%)	1.76s (± 0.23%)	~	1.75s	1.76s	p=0.787 n=6
Check Time	3.06s (± 0.55%)	3.07s (± 0.64%)	~	3.05s	3.09s	p=0.627 n=6
Emit Time	0.09s (± 4.45%)	0.09s (± 4.62%)	~	0.08s	0.09s	p=0.218 n=6
Total Time	8.90s (± 0.17%)	8.89s (± 0.19%)	~	8.87s	8.91s	p=0.329 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	54118	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54118/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Unknown failure"
• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54118/merge:

Everything looks good!

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.