Skip to content

Conversation

@ahejlsberg
Copy link
Member

Fixes #53998.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 26, 2023
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2023

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 3625f21. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2023

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 3625f21. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2023

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 3625f21. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2023

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 3625f21. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2023

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 3625f21. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/54033/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/54033/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54033

Metric main 54033 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,291k (± 0.01%) 365,303k (± 0.01%) ~ 365,271k 365,348k p=0.575 n=6
Parse Time 3.53s (± 0.58%) 3.52s (± 0.49%) ~ 3.49s 3.54s p=0.366 n=6
Bind Time 1.17s (± 0.47%) 1.17s (± 0.44%) ~ 1.17s 1.18s p=0.640 n=6
Check Time 9.49s (± 0.40%) 9.56s (± 0.46%) +0.06s (+ 0.68%) 9.49s 9.61s p=0.037 n=6
Emit Time 7.86s (± 0.74%) 7.89s (± 0.33%) ~ 7.85s 7.93s p=0.124 n=6
Total Time 22.07s (± 0.38%) 22.14s (± 0.25%) ~ 22.09s 22.21s p=0.065 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,680k (± 0.02%) 192,715k (± 0.04%) ~ 192,586k 192,800k p=0.297 n=6
Parse Time 1.59s (± 0.93%) 1.60s (± 0.39%) ~ 1.59s 1.61s p=0.156 n=6
Bind Time 0.82s (± 0.66%) 0.83s (± 0.62%) ~ 0.82s 0.83s p=0.640 n=6
Check Time 10.21s (± 0.59%) 10.24s (± 0.64%) ~ 10.17s 10.35s p=0.335 n=6
Emit Time 3.01s (± 0.35%) 3.02s (± 1.15%) ~ 2.99s 3.06s p=1.000 n=6
Total Time 15.64s (± 0.32%) 15.69s (± 0.59%) ~ 15.59s 15.83s p=0.466 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,769k (± 0.00%) 345,796k (± 0.02%) ~ 345,741k 345,881k p=0.810 n=6
Parse Time 2.71s (± 0.49%) 2.72s (± 0.19%) +0.01s (+ 0.55%) 2.72s 2.73s p=0.039 n=6
Bind Time 1.08s (± 0.00%) 1.08s (± 1.27%) ~ 1.06s 1.09s p=1.000 n=6
Check Time 7.88s (± 0.26%) 7.83s (± 0.55%) ~ 7.77s 7.89s p=0.064 n=6
Emit Time 4.43s (± 0.39%) 4.44s (± 0.27%) ~ 4.42s 4.45s p=0.620 n=6
Total Time 16.10s (± 0.15%) 16.07s (± 0.36%) ~ 16.00s 16.16s p=0.374 n=6
TFS - node (v16.17.1, x64)
Memory used 300,079k (± 0.01%) 300,062k (± 0.01%) ~ 300,025k 300,086k p=0.298 n=6
Parse Time 2.15s (± 0.81%) 2.15s (± 0.49%) ~ 2.13s 2.16s p=0.869 n=6
Bind Time 1.25s (± 1.21%) 1.23s (± 0.80%) ~ 1.22s 1.24s p=0.070 n=6
Check Time 7.23s (± 0.60%) 7.23s (± 0.30%) ~ 7.21s 7.26s p=0.809 n=6
Emit Time 4.38s (± 0.70%) 4.35s (± 0.29%) ~ 4.34s 4.37s p=0.084 n=6
Total Time 15.01s (± 0.57%) 14.96s (± 0.19%) ~ 14.92s 15.00s p=0.228 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,599k (± 0.01%) 481,518k (± 0.00%) -81k (- 0.02%) 481,482k 481,537k p=0.031 n=6
Parse Time 3.23s (± 0.36%) 3.24s (± 0.36%) ~ 3.23s 3.26s p=0.111 n=6
Bind Time 0.94s (± 0.55%) 0.94s (± 0.95%) ~ 0.93s 0.95s p=0.541 n=6
Check Time 17.82s (± 0.62%) 17.81s (± 0.75%) ~ 17.71s 18.06s p=0.629 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.98s (± 0.55%) 21.98s (± 0.62%) ~ 21.88s 22.24s p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used 560,723k (± 0.02%) 560,683k (± 0.02%) ~ 560,505k 560,853k p=0.810 n=6
Parse Time 3.98s (± 0.35%) 3.98s (± 0.22%) ~ 3.97s 3.99s p=0.621 n=6
Bind Time 1.76s (± 0.46%) 1.76s (± 0.43%) ~ 1.75s 1.77s p=0.729 n=6
Check Time 3.03s (± 0.47%) 3.03s (± 0.40%) ~ 3.01s 3.04s p=0.935 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.86s (± 0.12%) 8.85s (± 0.19%) ~ 8.83s 8.87s p=0.869 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-147-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54033 6
Baseline main 6

Developer Information:

Download Benchmark

@ahejlsberg ahejlsberg merged commit 94564cf into main May 2, 2023
@ahejlsberg ahejlsberg deleted the fix53998 branch May 2, 2023 13:40
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic Extract alone cannot be used from uninstantiated generic parameter

4 participants