Skip to content

added wordPattern Regex to include more characters #53934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

iisaduan
Copy link
Member

@iisaduan iisaduan commented Apr 20, 2023

Makes linked editing match more characters. Allows users to type property access expressions, custom elements, and JSX generics.

It does match more strings than valid tag names, but this lets the linked editing continue when you're not done typing the full tag name.

fixes #53936

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 20, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@iisaduan iisaduan closed this Apr 20, 2023
@iisaduan iisaduan reopened this Apr 20, 2023
@iisaduan iisaduan merged commit c169305 into microsoft:main Apr 20, 2023
@iisaduan iisaduan deleted the linkedEditRegex branch April 21, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked editing disconnects on valid tag names with non alphanumeric characters
3 participants