When installing unrelated package inside scoped packages dont invalidate resolutions from everything in the scoped package #53873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate resolutions from everything in the scoped package
sheetalkamat
force-pushed
the
scopedPackageUpdate
branch
from
8061bfa to
ac9f51e
Compare
sheetalkamat
commented
Apr 17, 2023
| Scheduling update | ||
| Elapsed:: *ms DirectoryWatcher:: Triggered with /user/username/projects/myproject/node_modules/@myapp/unrelated2/index.d.ts :: WatchInfo: /user/username/projects/myproject 1 undefined Wild card directory | ||
| Reloading new file names and options | ||
| Synchronizing program |
There was a problem hiding this comment.
Before this change this would cause use to invalidate resolution for ts-types as well and we would re-resolve it. Because everything in @myapp was marked as something to invalidate because of above directory watcher invoke instead of marking eberything in @myapp/unrelated2
sheetalkamat
commented
Apr 17, 2023
| CreatingProgramWith:: | ||
| roots: ["/user/username/projects/myproject/lib/app.ts"] | ||
| options: {"watch":true,"project":"/user/username/projects/myproject","traceResolution":true,"extendedDiagnostics":true,"configFilePath":"/user/username/projects/myproject/tsconfig.json"} | ||
| ======== Resolving module '@myapp/ts-types' from '/user/username/projects/myproject/lib/app.ts'. ======== |
There was a problem hiding this comment.
this is re-resolved here because node_modules get created.
sheetalkamat
commented
Apr 17, 2023
| CreatingProgramWith:: | ||
| roots: ["/user/username/projects/myproject/lib/app.ts"] | ||
| options: {"watch":true,"project":"/user/username/projects/myproject","traceResolution":true,"extendedDiagnostics":true,"configFilePath":"/user/username/projects/myproject/tsconfig.json"} | ||
| ======== Resolving module '@myapp/ts-types' from '/user/username/projects/myproject/lib/app.ts'. ======== |
There was a problem hiding this comment.
Re-resolve is becuse "@myapp" is created in node_modules
sheetalkamat
requested review from
andrewbranch and
jakebailey
and removed request for
andrewbranch
jakebailey
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.