Skip to content

Bump minimum Node to 14.17, ES to 2020 for TS 5.1 #53291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2023
Merged

Bump minimum Node to 14.17, ES to 2020 for TS 5.1 #53291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83e6114
Bump minimum Node to 14.17, ES to 2020 for TS 5.1
jakebailey Mar 16, 2023
0d96746
Move down to 2019 to definitely avoid node 14 problems
jakebailey Apr 13, 2023
9eec20f
Merge branch 'main' into node-14
jakebailey Apr 13, 2023
49f70c2
Revert "Move down to 2019 to definitely avoid node 14 problems"
jakebailey Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Herebyfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ function createBundler(entrypoint, outfile, taskOptions = {}) {
bundle: true,
outfile,
platform: "node",
target: "es2018",
target: ["es2020", "node14.17"],
format: "cjs",
sourcemap: "linked",
sourcesContent: false,
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"tsserver": "./bin/tsserver"
},
"engines": {
"node": ">=12.20"
"node": ">=14.17"
},
"files": [
"bin",
Expand Down
4 changes: 2 additions & 2 deletions src/tsconfig-base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"outDir": "../built/local",

"pretty": true,
"lib": ["es2018"],
"target": "es2018",
"lib": ["es2020"],
"target": "es2020",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be set to ES2019 to be safe about the Node 14 problems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set these to es2019 in an abundance of caution.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, that feels inconsistent :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just flipped it back. We'll k now if we have to do it but since we aren't using this output anyway I don't think the inconsistency is a good idea.

"module": "CommonJS",
"moduleResolution": "node",

Expand Down