Skip to content

When resolving type reference from custom typeRoot localtion use mangled scope name if the package is scoped name #53166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

When resolving type reference from custom typeRoot localtion use mangled scope name if the package is scoped name #53166

merged 3 commits into from
Mar 10, 2023

Conversation

sheetalkamat
Copy link
Member

Fixes #53154

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 8, 2023
DanielRosenwasser
DanielRosenwasser reviewed Mar 8, 2023
View reviewed changes
@sheetalkamat sheetalkamat merged commit 46d70d7 into main Mar 10, 2023
@sheetalkamat sheetalkamat deleted the customTypeRootsScopedPackage branch March 10, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@jakebailey jakebailey jakebailey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle scoped package resolution from custom type roots
4 participants
@sheetalkamat @DanielRosenwasser @jakebailey @typescript-bot