Skip to content

Fix transform flags for certain ES2020 features. #52445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

DanielRosenwasser
Copy link
Member

It doesn't matter because these don't get downleveled; but it is technically more correct.

It does mean we won't perform any ES2021+ transforms when we see these constructs though.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 27, 2023
@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 28c4ee6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52445

Metric main 52445 Delta Best Worst
Angular - node (v16.17.1, x64)
Memory used 359,216k (± 0.01%) 359,208k (± 0.01%) -8k (- 0.00%) 359,172k 359,228k
Parse Time 4.19s (± 0.25%) 4.18s (± 0.36%) -0.00s (- 0.04%) 4.16s 4.20s
Bind Time 1.23s (± 0.68%) 1.22s (± 0.62%) -0.00s (- 0.27%) 1.21s 1.23s
Check Time 9.38s (± 0.57%) 9.38s (± 0.41%) +0.00s (+ 0.02%) 9.33s 9.44s
Emit Time 8.08s (± 0.47%) 8.07s (± 0.45%) -0.00s (- 0.04%) 8.01s 8.11s
Total Time 22.87s (± 0.35%) 22.86s (± 0.33%) -0.01s (- 0.04%) 22.77s 22.96s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,253k (± 0.06%) 194,828k (± 0.74%) +575k (+ 0.30%) 194,174k 197,774k
Parse Time 1.80s (± 0.55%) 1.80s (± 0.57%) +0.00s (+ 0.09%) 1.79s 1.82s
Bind Time 0.84s (± 0.97%) 0.85s (± 1.22%) +0.00s (+ 0.40%) 0.84s 0.86s
Check Time 10.41s (± 1.08%) 10.40s (± 0.49%) -0.01s (- 0.13%) 10.32s 10.46s
Emit Time 3.06s (± 0.70%) 3.06s (± 0.76%) -0.00s (- 0.16%) 3.02s 3.09s
Total Time 16.12s (± 0.70%) 16.11s (± 0.41%) -0.01s (- 0.06%) 16.05s 16.21s
Monaco - node (v16.17.1, x64)
Memory used 343,270k (± 0.01%) 343,239k (± 0.01%) -31k (- 0.01%) 343,190k 343,295k
Parse Time 3.19s (± 1.22%) 3.17s (± 0.89%) -0.02s (- 0.47%) 3.14s 3.22s
Bind Time 1.11s (± 0.68%) 1.11s (± 0.37%) 0.00s ( 0.00%) 1.11s 1.12s
Check Time 7.70s (± 0.36%) 7.73s (± 0.36%) +0.03s (+ 0.43%) 7.71s 7.78s
Emit Time 4.53s (± 0.67%) 4.54s (± 0.27%) +0.01s (+ 0.26%) 4.53s 4.56s
Total Time 16.53s (± 0.33%) 16.56s (± 0.21%) +0.03s (+ 0.20%) 16.51s 16.61s
TFS - node (v16.17.1, x64)
Memory used 299,762k (± 0.00%) 299,755k (± 0.00%) -7k (- 0.00%) 299,742k 299,773k
Parse Time 2.48s (± 1.59%) 2.48s (± 1.19%) 0.00s ( 0.00%) 2.44s 2.50s
Bind Time 1.25s (± 0.65%) 1.25s (± 0.44%) +0.00s (+ 0.13%) 1.25s 1.26s
Check Time 7.17s (± 0.36%) 7.17s (± 0.35%) +0.00s (+ 0.00%) 7.13s 7.20s
Emit Time 4.21s (± 0.47%) 4.23s (± 0.50%) +0.02s (+ 0.36%) 4.20s 4.25s
Total Time 15.12s (± 0.47%) 15.13s (± 0.30%) +0.02s (+ 0.10%) 15.07s 15.21s
material-ui - node (v16.17.1, x64)
Memory used 476,075k (± 0.02%) 476,037k (± 0.02%) -39k (- 0.01%) 475,977k 476,196k
Parse Time 3.72s (± 0.33%) 3.72s (± 0.43%) +0.00s (+ 0.04%) 3.69s 3.73s
Bind Time 1.02s (± 0.74%) 1.02s (± 0.40%) -0.00s (- 0.33%) 1.01s 1.02s
Check Time 18.12s (± 0.12%) 18.09s (± 0.17%) -0.03s (- 0.18%) 18.06s 18.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.86s (± 0.13%) 22.83s (± 0.20%) -0.03s (- 0.12%) 22.77s 22.90s
xstate - node (v16.17.1, x64)
Memory used 546,281k (± 0.01%) 546,288k (± 0.02%) +8k (+ 0.00%) 546,204k 546,457k
Parse Time 4.75s (± 0.35%) 4.75s (± 0.41%) -0.00s (- 0.04%) 4.74s 4.79s
Bind Time 1.81s (± 3.74%) 1.81s (± 3.94%) +0.01s (+ 0.37%) 1.67s 1.86s
Check Time 2.99s (± 2.91%) 3.00s (± 2.85%) +0.00s (+ 0.11%) 2.95s 3.17s
Emit Time 0.10s (± 5.34%) 0.09s (± 4.45%) 🟩-0.01s (- 5.17%) 0.09s 0.10s
Total Time 9.65s (± 0.35%) 9.66s (± 0.42%) +0.01s (+ 0.07%) 9.62s 9.70s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52445 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn
Copy link
Member

@DanielRosenwasser is this worth taking for 5.1?

@rbuckton @navya9singh want to review this?

@DanielRosenwasser DanielRosenwasser merged commit 1af17f8 into main Apr 13, 2023
@DanielRosenwasser DanielRosenwasser deleted the fixTransformFlagsForES2020 branch April 13, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants