Add cache to auto-import package.json filter#52422
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Feb 6, 2023
Merged
Add cache to auto-import package.json filter#52422andrewbranch merged 1 commit intomicrosoft:mainfrom
andrewbranch merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
Author
|
@typescript-bot perf test this |
Collaborator
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at 638dd64. You can monitor the build here. Update: The results are in! |
Collaborator
|
@andrewbranch Here they are:
CompilerComparison Report - main..52422
System
Hosts
Scenarios
TSServerComparison Report - main..52422
System
Hosts
Scenarios
StartupComparison Report - main..52422
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
@typescript-bot user test tsserver |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 638dd64. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 638dd64. You can monitor the build here. Update: The results are in! |
Collaborator
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
Collaborator
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsbackstage/backstage
|
Member
Author
|
Cool, it does look like this gives a 5% improvement to completions on xstate! |
sheetalkamat
approved these changes
Jan 26, 2023
jakebailey
reviewed
Jan 26, 2023
Comment on lines
+3666
to
+3667
| let ambientModuleCache: Map<Symbol, boolean> | undefined; | ||
| let sourceFileCache: Map<SourceFile, boolean> | undefined; |
Member
There was a problem hiding this comment.
I don't think we typically use the symbols or nodes themselves as cache keys; all caches I've dealt with or added use symbol/node IDs instead; not sure if that's intentional or not, though.
Member
There was a problem hiding this comment.
i think this should be ok now that we are using native maps and life of this cache is well maintained..
Member
There was a problem hiding this comment.
That does make me wonder if we'd gain anything by switching all of the other caches to work directly...
Member
Author
There was a problem hiding this comment.
I had a vague memory of someone saying using the object instead of ids is preferred now. But I don’t know if there’s a real difference.
Member
Author
There was a problem hiding this comment.
Can @rbuckton or @DanielRosenwasser advise on this?
Member
There was a problem hiding this comment.
Node IDs are set to 0 unconditionally, and set lazily when we need to use a Node in a Map or WeakMap. I tried to remove some usages out of the compiler and didn't find a ton of wins.
The biggest risk here is that you keep a PackageJsonFilter around across language service operations - leading to either a memory leak, or corrupt state. A WeakMap works, but I'd rather we just be a little careful about how we use these.
So I agree with Sheetal - the cache doesn't escape so we should be okay with these - just make sure the PackageJsonFilter object doesn't either.
Member
There was a problem hiding this comment.
Actually, let me rephrase that - using objects/sparse arrays over Maps actually is a win, but not if you rely on iteration order.
Member
Author
There was a problem hiding this comment.
Yeah, this object only lasts a single request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging another issue and noticed that during completions, we go through some work to generate the module specifiers for every export within an ambient module, when obviously that work only needs to be done once per module, not once per export. It made it a pain to debug module specifier generation since I was hitting a breakpoint in one of those functions called with the same inputs over and over, but apparently that work is quite cheap, because I can’t see any appreciable difference locally. Figured I would run the server perf tests though.