Skip to content

Comments

[experimental] Cache all internally created Printers#52404

Closed
jakebailey wants to merge 9 commits intomicrosoft:mainfrom
jakebailey:printer-handlers
Closed

[experimental] Cache all internally created Printers#52404
jakebailey wants to merge 9 commits intomicrosoft:mainfrom
jakebailey:printer-handlers

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Jan 25, 2023

More invasive version of #52382 which gets rid of the rest of the createPrinter calls at the cost of changing our internal API to accept handlers too.

This isn't a totally clean approach, but I want to see how it goes.

@jakebailey
Copy link
Member Author

jakebailey commented Jan 25, 2023

@typescript-bot perf test this

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 25, 2023
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 25, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 2f48ec3. You can monitor the build here.

Update: The results are in!

@jakebailey
Copy link
Member Author

jakebailey commented Jan 25, 2023

Oh, yeah, I forgot that there was one pesky test.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 25, 2023

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52404
Metric main 52404 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,693k (± 0.01%) 359,794k (± 0.02%) +100k (+ 0.03%) 359,720k 359,887k
Parse Time 3.95s (± 0.94%) 3.96s (± 0.68%) +0.01s (+ 0.38%) 3.93s 4.00s
Bind Time 1.17s (± 0.35%) 1.18s (± 1.15%) +0.01s (+ 1.00%) 1.17s 1.21s
Check Time 8.85s (± 0.30%) 8.67s (± 0.31%) -0.17s (- 1.96%) 8.64s 8.72s
Emit Time 7.58s (± 0.39%) 7.46s (± 0.77%) -0.12s (- 1.63%) 7.39s 7.54s
Total Time 21.55s (± 0.21%) 21.28s (± 0.45%) -0.27s (- 1.27%) 21.21s 21.43s
Compiler-Unions - node (v18.10.0, x64)
Memory used 194,467k (± 1.52%) 193,492k (± 1.15%) -975k (- 0.50%) 192,540k 198,057k
Parse Time 1.64s (± 1.86%) 1.63s (± 1.92%) -0.01s (- 0.51%) 1.58s 1.66s
Bind Time 0.80s (± 0.69%) 0.79s (± 0.65%) -0.00s (- 0.21%) 0.79s 0.80s
Check Time 9.68s (± 0.92%) 9.67s (± 0.46%) -0.01s (- 0.12%) 9.62s 9.75s
Emit Time 2.79s (± 1.00%) 2.85s (± 3.91%) +0.06s (+ 2.15%) 2.75s 3.06s
Total Time 14.91s (± 0.65%) 14.95s (± 0.96%) +0.04s (+ 0.30%) 14.78s 15.15s
Monaco - node (v18.10.0, x64)
Memory used 343,978k (± 0.01%) 343,958k (± 0.01%) -20k (- 0.01%) 343,915k 344,001k
Parse Time 2.96s (± 0.89%) 2.95s (± 0.43%) -0.01s (- 0.28%) 2.93s 2.96s
Bind Time 1.03s (± 1.17%) 1.04s (± 0.72%) +0.00s (+ 0.48%) 1.03s 1.05s
Check Time 7.29s (± 0.56%) 7.03s (± 0.38%) 🟩-0.26s (- 3.63%) 6.99s 7.07s
Emit Time 4.35s (± 0.74%) 4.17s (± 0.29%) 🟩-0.18s (- 4.06%) 4.16s 4.19s
Total Time 15.63s (± 0.42%) 15.19s (± 0.30%) -0.44s (- 2.82%) 15.12s 15.24s
TFS - node (v18.10.0, x64)
Memory used 300,321k (± 0.00%) 300,389k (± 0.01%) +67k (+ 0.02%) 300,365k 300,423k
Parse Time 2.24s (± 1.24%) 2.27s (± 1.69%) +0.03s (+ 1.41%) 2.23s 2.32s
Bind Time 1.17s (± 0.88%) 1.17s (± 0.35%) +0.00s (+ 0.43%) 1.17s 1.18s
Check Time 6.90s (± 0.36%) 6.60s (± 0.26%) 🟩-0.30s (- 4.28%) 6.57s 6.62s
Emit Time 3.93s (± 0.73%) 3.85s (± 1.03%) -0.09s (- 2.16%) 3.80s 3.91s
Total Time 14.24s (± 0.34%) 13.89s (± 0.29%) -0.35s (- 2.45%) 13.81s 13.92s
material-ui - node (v18.10.0, x64)
Memory used 476,721k (± 0.01%) 476,725k (± 0.00%) +4k (+ 0.00%) 476,711k 476,740k
Parse Time 3.55s (± 0.53%) 3.54s (± 2.57%) -0.01s (- 0.28%) 3.38s 3.65s
Bind Time 0.97s (± 0.78%) 1.00s (± 7.03%) +0.03s (+ 3.10%) 0.96s 1.14s
Check Time 17.09s (± 0.28%) 17.21s (± 0.88%) +0.12s (+ 0.72%) 17.06s 17.50s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.61s (± 0.29%) 21.75s (± 0.69%) +0.14s (+ 0.65%) 21.56s 21.99s
xstate - node (v18.10.0, x64)
Memory used 548,654k (± 0.01%) 548,687k (± 0.01%) +34k (+ 0.01%) 548,558k 548,756k
Parse Time 4.56s (± 0.33%) 4.57s (± 0.46%) +0.01s (+ 0.29%) 4.54s 4.59s
Bind Time 1.71s (± 0.86%) 1.70s (± 0.94%) -0.01s (- 0.59%) 1.68s 1.72s
Check Time 2.74s (± 0.75%) 2.76s (± 0.98%) +0.01s (+ 0.49%) 2.73s 2.80s
Emit Time 0.08s (± 4.99%) 0.09s (± 4.45%) +0.01s (+12.24%) 0.09s 0.10s
Total Time 9.10s (± 0.18%) 9.12s (± 0.36%) +0.02s (+ 0.24%) 9.07s 9.16s
Angular - node (v16.17.1, x64)
Memory used 359,056k (± 0.01%) 359,198k (± 0.01%) +142k (+ 0.04%) 359,163k 359,237k
Parse Time 4.19s (± 0.44%) 4.18s (± 0.44%) -0.00s (- 0.08%) 4.17s 4.22s
Bind Time 1.22s (± 0.33%) 1.22s (± 0.68%) +0.00s (+ 0.27%) 1.22s 1.24s
Check Time 9.55s (± 0.18%) 9.38s (± 0.38%) -0.17s (- 1.83%) 9.34s 9.44s
Emit Time 8.08s (± 0.48%) 7.88s (± 0.22%) -0.20s (- 2.46%) 7.86s 7.90s
Total Time 23.04s (± 0.16%) 22.66s (± 0.17%) -0.38s (- 1.63%) 22.61s 22.72s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,251k (± 0.03%) 194,286k (± 0.05%) +35k (+ 0.02%) 194,186k 194,425k
Parse Time 1.81s (± 0.45%) 1.79s (± 0.77%) -0.01s (- 0.65%) 1.77s 1.81s
Bind Time 0.84s (± 1.06%) 0.84s (± 0.97%) +0.00s (+ 0.40%) 0.84s 0.86s
Check Time 10.37s (± 0.36%) 10.39s (± 0.42%) +0.02s (+ 0.19%) 10.33s 10.43s
Emit Time 3.06s (± 0.77%) 3.03s (± 1.06%) -0.03s (- 0.87%) 3.00s 3.08s
Total Time 16.08s (± 0.19%) 16.06s (± 0.39%) -0.02s (- 0.10%) 15.99s 16.14s
Monaco - node (v16.17.1, x64)
Memory used 343,217k (± 0.01%) 343,258k (± 0.01%) +42k (+ 0.01%) 343,230k 343,299k
Parse Time 3.14s (± 0.82%) 3.15s (± 0.84%) +0.02s (+ 0.53%) 3.11s 3.18s
Bind Time 1.11s (± 0.89%) 1.11s (± 0.00%) +0.00s (+ 0.15%) 1.11s 1.11s
Check Time 7.89s (± 0.25%) 7.70s (± 0.33%) -0.18s (- 2.35%) 7.68s 7.74s
Emit Time 4.57s (± 0.39%) 4.37s (± 0.61%) 🟩-0.19s (- 4.20%) 4.34s 4.41s
Total Time 16.70s (± 0.24%) 16.34s (± 0.19%) -0.36s (- 2.13%) 16.29s 16.38s
TFS - node (v16.17.1, x64)
Memory used 299,713k (± 0.01%) 299,802k (± 0.01%) +89k (+ 0.03%) 299,762k 299,834k
Parse Time 2.47s (± 1.40%) 2.46s (± 0.80%) -0.00s (- 0.20%) 2.45s 2.50s
Bind Time 1.25s (± 0.33%) 1.26s (± 0.44%) +0.00s (+ 0.27%) 1.25s 1.26s
Check Time 7.53s (± 0.50%) 7.25s (± 0.47%) 🟩-0.28s (- 3.72%) 7.22s 7.31s
Emit Time 4.24s (± 0.79%) 4.17s (± 0.75%) -0.07s (- 1.61%) 4.13s 4.21s
Total Time 15.49s (± 0.38%) 15.14s (± 0.50%) -0.35s (- 2.26%) 15.07s 15.28s
material-ui - node (v16.17.1, x64)
Memory used 476,133k (± 0.02%) 476,016k (± 0.01%) -117k (- 0.02%) 475,968k 476,090k
Parse Time 3.72s (± 0.40%) 3.71s (± 0.22%) -0.00s (- 0.09%) 3.70s 3.72s
Bind Time 1.02s (± 0.00%) 1.02s (± 0.00%) 0.00s ( 0.00%) 1.02s 1.02s
Check Time 18.05s (± 0.13%) 18.07s (± 0.33%) +0.03s (+ 0.16%) 18.03s 18.19s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.78s (± 0.14%) 22.81s (± 0.26%) +0.03s (+ 0.13%) 22.75s 22.92s
xstate - node (v16.17.1, x64)
Memory used 546,280k (± 0.03%) 546,222k (± 0.01%) -58k (- 0.01%) 546,178k 546,332k
Parse Time 4.76s (± 0.57%) 4.75s (± 0.37%) -0.01s (- 0.25%) 4.73s 4.78s
Bind Time 1.81s (± 4.15%) 1.82s (± 4.32%) +0.00s (+ 0.09%) 1.66s 1.86s
Check Time 2.98s (± 2.58%) 3.00s (± 2.81%) +0.02s (+ 0.67%) 2.96s 3.17s
Emit Time 0.09s (± 4.45%) 0.09s (± 4.45%) 0.00s ( 0.00%) 0.09s 0.10s
Total Time 9.65s (± 0.47%) 9.66s (± 0.33%) +0.01s (+ 0.10%) 9.60s 9.69s
Angular - node (v14.15.1, x64)
Memory used 352,668k (± 0.01%) 352,806k (± 0.01%) +138k (+ 0.04%) 352,769k 352,829k
Parse Time 4.23s (± 0.35%) 4.23s (± 0.32%) -0.00s (- 0.12%) 4.21s 4.25s
Bind Time 1.28s (± 0.40%) 1.28s (± 0.59%) -0.00s (- 0.13%) 1.27s 1.29s
Check Time 9.84s (± 0.23%) 9.70s (± 0.44%) -0.14s (- 1.47%) 9.63s 9.76s
Emit Time 8.38s (± 0.39%) 8.26s (± 0.62%) -0.12s (- 1.39%) 8.18s 8.31s
Total Time 23.73s (± 0.15%) 23.47s (± 0.17%) -0.27s (- 1.13%) 23.44s 23.54s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,268k (± 0.06%) 189,781k (± 0.72%) +513k (+ 0.27%) 189,082k 192,556k
Parse Time 1.85s (± 0.95%) 1.86s (± 0.56%) +0.01s (+ 0.45%) 1.84s 1.87s
Bind Time 0.86s (± 0.00%) 0.87s (± 0.47%) +0.01s (+ 0.97%) 0.86s 0.87s
Check Time 10.41s (± 0.33%) 10.48s (± 0.42%) +0.07s (+ 0.70%) 10.43s 10.56s
Emit Time 3.21s (± 4.13%) 3.31s (± 5.06%) +0.10s (+ 3.01%) 3.14s 3.48s
Total Time 16.33s (± 0.91%) 16.51s (± 0.97%) +0.18s (+ 1.11%) 16.29s 16.68s
Monaco - node (v14.15.1, x64)
Memory used 337,987k (± 0.01%) 338,041k (± 0.01%) +54k (+ 0.02%) 338,013k 338,069k
Parse Time 3.22s (± 1.28%) 3.25s (± 1.58%) +0.02s (+ 0.72%) 3.21s 3.33s
Bind Time 1.12s (± 0.75%) 1.11s (± 0.37%) -0.01s (- 0.60%) 1.10s 1.11s
Check Time 8.25s (± 0.57%) 8.07s (± 0.31%) -0.18s (- 2.20%) 8.04s 8.10s
Emit Time 4.81s (± 0.43%) 4.60s (± 1.04%) 🟩-0.21s (- 4.33%) 4.55s 4.69s
Total Time 17.39s (± 0.20%) 17.02s (± 0.37%) -0.38s (- 2.16%) 16.96s 17.11s
TFS - node (v14.15.1, x64)
Memory used 294,512k (± 0.01%) 294,593k (± 0.01%) +81k (+ 0.03%) 294,573k 294,623k
Parse Time 2.74s (± 0.88%) 2.75s (± 0.37%) +0.01s (+ 0.30%) 2.74s 2.77s
Bind Time 1.11s (± 0.00%) 1.11s (± 0.68%) +0.00s (+ 0.15%) 1.10s 1.12s
Check Time 7.81s (± 0.50%) 7.54s (± 0.36%) 🟩-0.28s (- 3.54%) 7.49s 7.57s
Emit Time 4.65s (± 0.52%) 4.53s (± 1.08%) -0.12s (- 2.65%) 4.48s 4.61s
Total Time 16.32s (± 0.28%) 15.93s (± 0.26%) -0.39s (- 2.41%) 15.88s 16.00s
material-ui - node (v14.15.1, x64)
Memory used 471,503k (± 0.00%) 471,543k (± 0.00%) +40k (+ 0.01%) 471,531k 471,553k
Parse Time 3.93s (± 0.44%) 3.95s (± 0.65%) +0.02s (+ 0.38%) 3.91s 3.98s
Bind Time 1.05s (± 0.99%) 1.04s (± 0.94%) -0.00s (- 0.48%) 1.03s 1.05s
Check Time 19.05s (± 0.55%) 18.97s (± 0.58%) -0.08s (- 0.41%) 18.82s 19.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.03s (± 0.54%) 23.96s (± 0.52%) -0.07s (- 0.27%) 23.79s 24.14s
xstate - node (v14.15.1, x64)
Memory used 534,330k (± 0.01%) 534,476k (± 0.00%) +146k (+ 0.03%) 534,439k 534,511k
Parse Time 5.14s (± 0.78%) 5.15s (± 0.38%) +0.01s (+ 0.19%) 5.13s 5.17s
Bind Time 1.72s (± 0.86%) 1.73s (± 0.61%) +0.01s (+ 0.39%) 1.71s 1.74s
Check Time 3.08s (± 0.67%) 3.11s (± 0.69%) +0.02s (+ 0.76%) 3.07s 3.13s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.04s (± 0.57%) 10.08s (± 0.39%) +0.04s (+ 0.43%) 10.04s 10.14s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52404 6
Baseline main 6

TSServer

Comparison Report - main..52404
Metric main 52404 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,533ms (± 1.54%) 2,515ms (± 1.54%) -18ms (- 0.71%) 2,474ms 2,577ms
Req 2 - geterr 5,510ms (± 0.33%) 5,500ms (± 0.82%) -11ms (- 0.19%) 5,466ms 5,583ms
Req 3 - references 364ms (± 1.48%) 363ms (± 1.08%) -2ms (- 0.41%) 356ms 367ms
Req 4 - navto 283ms (± 0.99%) 285ms (± 0.18%) +2ms (+ 0.77%) 284ms 285ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 68ms (± 4.41%) 66ms (± 1.14%) -2ms (- 2.95%) 65ms 67ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,735ms (± 1.49%) 2,735ms (± 1.13%) 0ms ( 0.00%) 2,706ms 2,780ms
Req 2 - geterr 4,043ms (± 0.47%) 4,066ms (± 0.76%) +23ms (+ 0.57%) 4,013ms 4,105ms
Req 3 - references 367ms (± 0.36%) 368ms (± 0.33%) +1ms (+ 0.32%) 367ms 370ms
Req 4 - navto 293ms (± 0.63%) 299ms (± 0.92%) +6ms (+ 1.94%) 295ms 302ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 66ms (± 0.62%) 83ms (± 1.27%) +16ms (+24.69%) 81ms 84ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,489ms (± 0.77%) 3,504ms (± 0.55%) +15ms (+ 0.43%) 3,482ms 3,533ms
Req 2 - geterr 1,404ms (± 1.50%) 1,409ms (± 1.18%) +5ms (+ 0.36%) 1,390ms 1,435ms
Req 3 - references 106ms (± 0.97%) 104ms (± 2.30%) -2ms (- 2.04%) 100ms 107ms
Req 4 - navto 355ms (± 0.68%) 356ms (± 1.16%) +1ms (+ 0.33%) 353ms 364ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 467ms (± 1.27%) 464ms (± 1.13%) -3ms (- 0.61%) 454ms 468ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,786ms (± 0.40%) 2,768ms (± 0.88%) -18ms (- 0.64%) 2,731ms 2,799ms
Req 2 - geterr 5,886ms (± 0.36%) 5,892ms (± 0.31%) +6ms (+ 0.10%) 5,857ms 5,908ms
Req 3 - references 379ms (± 1.03%) 380ms (± 1.43%) +1ms (+ 0.18%) 373ms 387ms
Req 4 - navto 279ms (± 1.66%) 278ms (± 1.45%) -1ms (- 0.36%) 273ms 284ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 80ms (± 9.04%) 76ms (± 6.99%) 🟩-4ms (- 5.01%) 70ms 82ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,927ms (± 0.37%) 2,933ms (± 0.54%) +6ms (+ 0.22%) 2,916ms 2,962ms
Req 2 - geterr 4,391ms (± 0.61%) 4,405ms (± 0.37%) +14ms (+ 0.33%) 4,378ms 4,422ms
Req 3 - references 383ms (± 0.71%) 379ms (± 0.49%) -5ms (- 1.26%) 376ms 381ms
Req 4 - navto 287ms (± 0.87%) 288ms (± 0.56%) +1ms (+ 0.29%) 286ms 290ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.14%) 72ms (± 0.77%) -0ms (- 0.23%) 71ms 72ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,642ms (± 0.45%) 3,634ms (± 0.44%) -9ms (- 0.23%) 3,605ms 3,650ms
Req 2 - geterr 1,546ms (± 0.96%) 1,554ms (± 0.84%) +9ms (+ 0.55%) 1,542ms 1,575ms
Req 3 - references 112ms (± 1.43%) 111ms (± 2.20%) -1ms (- 0.75%) 108ms 115ms
Req 4 - navto 333ms (± 0.49%) 341ms (± 1.26%) +9ms (+ 2.61%) 337ms 347ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 478ms (± 0.85%) 479ms (± 0.82%) +0ms (+ 0.07%) 473ms 484ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,900ms (± 0.55%) 2,904ms (± 0.73%) +4ms (+ 0.14%) 2,879ms 2,932ms
Req 2 - geterr 6,271ms (± 0.67%) 6,306ms (± 1.13%) +35ms (+ 0.56%) 6,233ms 6,412ms
Req 3 - references 387ms (± 0.45%) 391ms (± 0.86%) +4ms (+ 1.03%) 385ms 394ms
Req 4 - navto 284ms (± 1.45%) 281ms (± 1.04%) -3ms (- 0.94%) 278ms 285ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 87ms (± 7.36%) 89ms (± 5.88%) +2ms (+ 1.92%) 80ms 94ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,063ms (± 0.28%) 3,075ms (± 0.80%) +12ms (+ 0.38%) 3,056ms 3,118ms
Req 2 - geterr 4,669ms (± 0.28%) 4,702ms (± 0.51%) +33ms (+ 0.71%) 4,668ms 4,741ms
Req 3 - references 413ms (± 1.46%) 406ms (± 0.85%) -6ms (- 1.53%) 404ms 413ms
Req 4 - navto 297ms (± 0.45%) 294ms (± 0.70%) -3ms (- 0.84%) 292ms 298ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 88ms (± 0.85%) 80ms (± 0.51%) 🟩-8ms (- 9.07%) 80ms 81ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,962ms (± 0.53%) 3,974ms (± 0.48%) +12ms (+ 0.29%) 3,952ms 3,996ms
Req 2 - geterr 1,518ms (± 1.29%) 1,526ms (± 1.50%) +8ms (+ 0.52%) 1,499ms 1,562ms
Req 3 - references 133ms (± 3.36%) 134ms (± 1.56%) +2ms (+ 1.13%) 132ms 137ms
Req 4 - navto 374ms (± 0.84%) 376ms (± 1.07%) +2ms (+ 0.49%) 368ms 379ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 504ms (± 1.39%) 508ms (± 1.62%) +4ms (+ 0.76%) 500ms 517ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52404 6
Baseline main 6

Startup

Comparison Report - main..52404
Metric main 52404 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 141.78ms (± 0.17%) 142.40ms (± 0.19%) +0.63ms (+ 0.44%) 141.39ms 146.32ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.20ms (± 0.14%) 226.26ms (± 0.30%) +1.06ms (+ 0.47%) 224.59ms 234.30ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.82ms (± 0.16%) 228.60ms (± 0.25%) +0.77ms (+ 0.34%) 227.24ms 233.41ms
typescript-startup - node (v16.17.1, x64)
Execution time 208.79ms (± 0.16%) 209.68ms (± 0.26%) +0.88ms (+ 0.42%) 208.31ms 216.47ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52404 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey jakebailey closed this Jan 25, 2023
@jakebailey jakebailey deleted the printer-handlers branch January 29, 2024 19:36
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@jakebailey jakebailey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakebailey @typescript-bot