fix(51223): Go-to-definition for yield and await keyword; jump to respective function definition#51838
Merged
sandersn merged 1 commit intomicrosoft:mainfrom Dec 20, 2022
abuob:fix/51223
Merged
fix(51223): Go-to-definition for yield and await keyword; jump to respective function definition#51838sandersn merged 1 commit intomicrosoft:mainfrom abuob:fix/51223
sandersn merged 1 commit intomicrosoft:mainfrom
abuob:fix/51223
Conversation
…pective function definition
Contributor
Author
|
@microsoft-github-policy-service agree |
sandersn
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51223
My first PR on this project, apologies in advance in case I missed anything in the guidelines.
Please note that there was some discussion in the issue for
await, whether it should jump to the function definition or the respectiveasync. This PR does the former - in the very most cases, they should be right next to each other either way, and the latter seems slightly more involved to implement (which I'm absolutely willing to tackle though if preferred).Furthermore, in the case of an error (e.g. surrounding function is not async/generator), this implementation should not provide any goToDefinition.