Fix narrowing by `typeof` applied to discriminant property #51720

ahejlsberg · 2022-12-02T00:02:35Z

Andarist

For what it's worth - LGTM. I was looking into this too and came up locally with a similar fix.

DanielRosenwasser · 2022-12-02T22:54:30Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at acfc111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at acfc111. You can monitor the build here.

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at acfc111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at acfc111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at acfc111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at acfc111. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-02T22:54:33Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at acfc111. You can monitor the build here.

typescript-bot · 2022-12-02T23:04:49Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/51720/merge:

Everything looks good!

typescript-bot · 2022-12-02T23:07:16Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/51720/merge:

Everything looks good!

typescript-bot · 2022-12-02T23:09:43Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51720

_Metric	_main	₅₁₇₂₀	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{340,646k (± 0.01%)}	_{340,651k (± 0.02%)}	_{+5k (+ 0.00%)}	_340,420k	_340,709k
_{Parse Time}	_{1.90s (± 0.76%)}	_{1.90s (± 0.42%)}	_{+0.00s (+ 0.21%)}	_1.88s	_1.92s
_{Bind Time}	_{0.65s (± 0.85%)}	_{0.65s (± 0.51%)}	_{-0.00s (- 0.31%)}	_0.64s	_0.66s
_{Check Time}	_{5.16s (± 0.57%)}	_{5.19s (± 0.48%)}	_{+0.03s (+ 0.68%)}	_5.14s	_5.26s
_{Emit Time}	_{5.13s (± 0.80%)}	_{5.15s (± 0.92%)}	_{+0.03s (+ 0.51%)}	_5.01s	_5.22s
_{Total Time}	_{12.83s (± 0.50%)}	_{12.90s (± 0.41%)}	_{+0.06s (+ 0.50%)}	_12.76s	_12.97s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{187,692k (± 0.60%)}	_{187,660k (± 0.59%)}	_{-33k (- 0.02%)}	_186,619k	_190,061k
_{Parse Time}	_{0.79s (± 0.46%)}	_{0.79s (± 0.70%)}	_{+0.01s (+ 0.76%)}	_0.78s	_0.80s
_{Bind Time}	_{0.42s (± 1.33%)}	_{0.42s (± 0.70%)}	_{+0.00s (+ 0.96%)}	_0.42s	_0.43s
_{Check Time}	_{6.04s (± 0.64%)}	_{6.08s (± 0.66%)}	_{+0.04s (+ 0.70%)}	_6.02s	_6.16s
_{Emit Time}	_{1.96s (± 1.21%)}	_{1.95s (± 0.78%)}	_{-0.01s (- 0.61%)}	_1.91s	_1.98s
_{Total Time}	_{9.21s (± 0.59%)}	_{9.24s (± 0.44%)}	_{+0.04s (+ 0.38%)}	_9.15s	_9.32s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{319,843k (± 0.01%)}	_{319,825k (± 0.01%)}	_{-18k (- 0.01%)}	_319,759k	_319,941k
_{Parse Time}	_{1.42s (± 0.57%)}	_{1.43s (± 0.57%)}	_{+0.01s (+ 0.92%)}	_1.42s	_1.45s
_{Bind Time}	_{0.59s (± 0.00%)}	_{0.59s (± 1.00%)}	_{+0.00s (+ 0.68%)}	_0.58s	_0.61s
_{Check Time}	_{4.88s (± 0.39%)}	_{4.89s (± 0.43%)}	_{+0.01s (+ 0.29%)}	_4.83s	_4.93s
_{Emit Time}	_{2.72s (± 0.80%)}	_{2.74s (± 0.92%)}	_{+0.02s (+ 0.77%)}	_2.68s	_2.79s
_{Total Time}	_{9.61s (± 0.26%)}	_{9.66s (± 0.43%)}	_{+0.05s (+ 0.49%)}	_9.57s	_9.75s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{282,273k (± 0.01%)}	_{282,284k (± 0.01%)}	_{+11k (+ 0.00%)}	_282,133k	_282,321k
_{Parse Time}	_{1.17s (± 1.03%)}	_{1.17s (± 0.90%)}	_{+0.01s (+ 0.51%)}	_1.15s	_1.19s
_{Bind Time}	_{0.65s (± 4.39%)}	_{0.65s (± 3.41%)}	_{+0.01s (+ 0.93%)}	_0.60s	_0.69s
_{Check Time}	_{4.76s (± 0.47%)}	_{4.75s (± 0.40%)}	_{-0.00s (- 0.11%)}	_4.71s	_4.79s
_{Emit Time}	_{2.80s (± 2.46%)}	_{2.79s (± 1.91%)}	_{-0.01s (- 0.50%)}	_2.69s	_2.89s
_{Total Time}	_{9.37s (± 0.68%)}	_{9.37s (± 0.60%)}	_{-0.00s (- 0.05%)}	_9.26s	_9.51s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{435,310k (± 0.01%)}	_{435,301k (± 0.01%)}	_{-10k (- 0.00%)}	_435,254k	_435,381k
_{Parse Time}	_{1.64s (± 0.55%)}	_{1.65s (± 0.69%)}	_{+0.01s (+ 0.67%)}	_1.62s	_1.67s
_{Bind Time}	_{0.50s (± 0.94%)}	_{0.50s (± 1.11%)}	_{+0.00s (+ 0.40%)}	_0.49s	_0.51s
_{Check Time}	_{11.89s (± 0.63%)}	_{11.88s (± 1.16%)}	_{-0.00s (- 0.03%)}	_11.67s	_12.32s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.03s (± 0.53%)}	_{14.04s (± 1.01%)}	_{+0.01s (+ 0.05%)}	_13.84s	_14.49s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{516,031k (± 0.01%)}	_{516,077k (± 0.01%)}	_{+46k (+ 0.01%)}	_515,960k	_516,216k
_{Parse Time}	_{2.31s (± 0.36%)}	_{2.31s (± 0.32%)}	_{+0.00s (+ 0.09%)}	_2.30s	_2.33s
_{Bind Time}	_{0.84s (± 1.62%)}	_{0.83s (± 0.91%)}	_{-0.00s (- 0.48%)}	_0.82s	_0.86s
_{Check Time}	_{1.36s (± 0.38%)}	_{1.36s (± 0.75%)}	_{0.00s ( 0.00%)}	_1.33s	_1.38s
_{Emit Time}	_{0.06s (± 0.00%)}	_{0.06s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.06s	_0.06s
_{Total Time}	_{4.58s (± 0.36%)}	_{4.58s (± 0.22%)}	_{0.00s ( 0.00%)}	_4.55s	_4.60s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-131-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₇₂₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-12-02T23:13:37Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2022-12-03T00:21:49Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/51720/merge:

Everything looks good!

typescript-bot · 2022-12-03T00:57:05Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/51720/merge:

Something interesting changed - please have a look.

Details

ant-design/ant-design

⚠️ Note that built also had errors ⚠️

Req #235 - references
    at hasCovariantVoidArgument (/typescript-main/built/local/tsserver.js:59124:93)
    at relateVariances (/typescript-main/built/local/tsserver.js:58374:66)
    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:58043:34)
    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:57964:23)
    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:57934:21)
    at isRelatedTo (/typescript-main/built/local/tsserver.js:57493:18)
    at compareSignaturesIdentical (/typescript-main/built/local/tsserver.js:59336:25)
    at signaturesIdenticalTo (/typescript-main/built/local/tsserver.js:58868:27)
    at signaturesRelatedTo (/typescript-main/built/local/tsserver.js:58753:18)
    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:58335:26)
    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:57964:23)
    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:57934:21)
    at isRelatedTo (/typescript-main/built/local/tsserver.js:57493:18)
    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:57227:22)
    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:57182:16)
    at isTypeIdenticalTo (/typescript-main/built/local/tsserver.js:56511:14)
    at isTypeOrBaseIdenticalTo (/typescript-main/built/local/tsserver.js:60727:74)
    at inferFromMatchingTypes (/typescript-main/built/local/tsserver.js:60397:17)
    at inferFromTypes (/typescript-main/built/local/tsserver.js:60229:46)
    at inferFromProperties (/typescript-main/built/local/tsserver.js:60674:13)
    at inferFromObjectTypes (/typescript-main/built/local/tsserver.js:60663:11)
    at invokeOnce (/typescript-main/built/local/tsserver.js:60382:11)
    at inferFromTypes (/typescript-main/built/local/tsserver.js:60340:13)
    at inferToMultipleTypes (/typescript-main/built/local/tsserver.js:60494:15)
    at inferFromTypes (/typescript-main/built/local/tsserver.js:60321:11)
    at inferTypes (/typescript-main/built/local/tsserver.js:60204:7)
    at inferJsxTypeArguments (/typescript-main/built/local/tsserver.js:65900:7)
    at inferTypeArguments (/typescript-main/built/local/tsserver.js:65912:16)
    at chooseOverload (/typescript-main/built/local/tsserver.js:66576:35)
    at resolveCall (/typescript-main/built/local/tsserver.js:66440:18)
    at resolveJsxOpeningLikeElement (/typescript-main/built/local/tsserver.js:67111:14)
    at resolveSignature (/typescript-main/built/local/tsserver.js:67128:18)
    at getResolvedSignature (/typescript-main/built/local/tsserver.js:67139:22)
    at getContextualTypeForArgumentAtIndex (/typescript-main/built/local/tsserver.js:63457:114)
    at getContextualJsxElementAttributesType (/typescript-main/built/local/tsserver.js:63882:14)
    at getContextualType2 (/typescript-main/built/local/tsserver.js:63867:18)
    at Object.getContextualType (/typescript-main/built/local/tsserver.js:43233:16)
    at forEachRelatedSymbol (/typescript-main/built/local/tsserver.js:139132:40)
    at getRelatedSymbol (/typescript-main/built/local/tsserver.js:139216:14)
    at getReferencesAtLocation (/typescript-main/built/local/tsserver.js:138712:29)
    at getReferencesInContainer (/typescript-main/built/local/tsserver.js:138683:9)
    at getReferencesInSourceFile (/typescript-main/built/local/tsserver.js:138676:14)
    at searchForName (/typescript-main/built/local/tsserver.js:138490:9)
    at getReferencesInContainerOrFiles (/typescript-main/built/local/tsserver.js:138316:11)
    at getReferencedSymbolsForSymbol (/typescript-main/built/local/tsserver.js:138305:9)
    at Object.getReferencedSymbolsForNode (/typescript-main/built/local/tsserver.js:138101:26)
    at Object.findReferencedSymbols (/typescript-main/built/local/tsserver.js:137707:36)
    at Object.findReferences (/typescript-main/built/local/tsserver.js:121949:43)
    at /typescript-main/built/local/tsserver.js:157949:45
    at searchPosition (/typescript-main/built/local/tsserver.js:158092:30)
    at getPerProjectReferences (/typescript-main/built/local/tsserver.js:158067:34)
    at getReferencesWorker (/typescript-main/built/local/tsserver.js:157942:31)
    at IOSession.getReferences (/typescript-main/built/local/tsserver.js:159491:26)
    at references (/typescript-main/built/local/tsserver.js:158320:45)
    at /typescript-main/built/local/tsserver.js:160420:71
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:160412:16)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:160420:31)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:160448:53)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:161983:16)

Req #235 - references
    at hasCovariantVoidArgument (/typescript-51720/built/local/tsserver.js:59124:93)
    at relateVariances (/typescript-51720/built/local/tsserver.js:58374:66)
    at structuredTypeRelatedToWorker (/typescript-51720/built/local/tsserver.js:58043:34)
    at structuredTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57964:23)
    at recursiveTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57934:21)
    at isRelatedTo (/typescript-51720/built/local/tsserver.js:57493:18)
    at compareSignaturesIdentical (/typescript-51720/built/local/tsserver.js:59336:25)
    at signaturesIdenticalTo (/typescript-51720/built/local/tsserver.js:58868:27)
    at signaturesRelatedTo (/typescript-51720/built/local/tsserver.js:58753:18)
    at structuredTypeRelatedToWorker (/typescript-51720/built/local/tsserver.js:58335:26)
    at structuredTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57964:23)
    at recursiveTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57934:21)
    at isRelatedTo (/typescript-51720/built/local/tsserver.js:57493:18)
    at checkTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57227:22)
    at isTypeRelatedTo (/typescript-51720/built/local/tsserver.js:57182:16)
    at isTypeIdenticalTo (/typescript-51720/built/local/tsserver.js:56511:14)
    at isTypeOrBaseIdenticalTo (/typescript-51720/built/local/tsserver.js:60727:74)
    at inferFromMatchingTypes (/typescript-51720/built/local/tsserver.js:60397:17)
    at inferFromTypes (/typescript-51720/built/local/tsserver.js:60229:46)
    at inferFromProperties (/typescript-51720/built/local/tsserver.js:60674:13)
    at inferFromObjectTypes (/typescript-51720/built/local/tsserver.js:60663:11)
    at invokeOnce (/typescript-51720/built/local/tsserver.js:60382:11)
    at inferFromTypes (/typescript-51720/built/local/tsserver.js:60340:13)
    at inferToMultipleTypes (/typescript-51720/built/local/tsserver.js:60494:15)
    at inferFromTypes (/typescript-51720/built/local/tsserver.js:60321:11)
    at inferTypes (/typescript-51720/built/local/tsserver.js:60204:7)
    at inferJsxTypeArguments (/typescript-51720/built/local/tsserver.js:65900:7)
    at inferTypeArguments (/typescript-51720/built/local/tsserver.js:65912:16)
    at chooseOverload (/typescript-51720/built/local/tsserver.js:66576:35)
    at resolveCall (/typescript-51720/built/local/tsserver.js:66440:18)
    at resolveJsxOpeningLikeElement (/typescript-51720/built/local/tsserver.js:67111:14)
    at resolveSignature (/typescript-51720/built/local/tsserver.js:67128:18)
    at getResolvedSignature (/typescript-51720/built/local/tsserver.js:67139:22)
    at getContextualTypeForArgumentAtIndex (/typescript-51720/built/local/tsserver.js:63457:114)
    at getContextualJsxElementAttributesType (/typescript-51720/built/local/tsserver.js:63882:14)
    at getContextualType2 (/typescript-51720/built/local/tsserver.js:63867:18)
    at Object.getContextualType (/typescript-51720/built/local/tsserver.js:43233:16)
    at forEachRelatedSymbol (/typescript-51720/built/local/tsserver.js:139132:40)
    at getRelatedSymbol (/typescript-51720/built/local/tsserver.js:139216:14)
    at getReferencesAtLocation (/typescript-51720/built/local/tsserver.js:138712:29)
    at getReferencesInContainer (/typescript-51720/built/local/tsserver.js:138683:9)
    at getReferencesInSourceFile (/typescript-51720/built/local/tsserver.js:138676:14)
    at searchForName (/typescript-51720/built/local/tsserver.js:138490:9)
    at getReferencesInContainerOrFiles (/typescript-51720/built/local/tsserver.js:138316:11)
    at getReferencedSymbolsForSymbol (/typescript-51720/built/local/tsserver.js:138305:9)
    at Object.getReferencedSymbolsForNode (/typescript-51720/built/local/tsserver.js:138101:26)
    at Object.findReferencedSymbols (/typescript-51720/built/local/tsserver.js:137707:36)
    at Object.findReferences (/typescript-51720/built/local/tsserver.js:121949:43)
    at /typescript-51720/built/local/tsserver.js:157949:45
    at searchPosition (/typescript-51720/built/local/tsserver.js:158092:30)
    at getPerProjectReferences (/typescript-51720/built/local/tsserver.js:158067:34)
    at getReferencesWorker (/typescript-51720/built/local/tsserver.js:157942:31)
    at IOSession.getReferences (/typescript-51720/built/local/tsserver.js:159491:26)
    at references (/typescript-51720/built/local/tsserver.js:158320:45)
    at /typescript-51720/built/local/tsserver.js:160420:71
    at IOSession.executeWithRequestId (/typescript-51720/built/local/tsserver.js:160412:16)
    at IOSession.executeCommand (/typescript-51720/built/local/tsserver.js:160420:31)
    at IOSession.onMessage (/typescript-51720/built/local/tsserver.js:160448:53)
    at Interface.<anonymous> (/typescript-51720/built/local/tsserver.js:161983:16)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/ant-design.ant-design.rawError.txt in the artifact folder

Last few requests

{"seq":232,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/components/alert/index.tsx","line":142,"offset":30,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":233,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/components/alert/index.tsx","line":142,"offset":30,"entryNames":["action"]}}
{"seq":234,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/components/alert/index.tsx","line":150,"offset":10,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":235,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/components/alert/index.tsx","line":174,"offset":20}}

Repro Steps

git clone https://github.com/ant-design/ant-design --recurse-submodules
In dir ant-design, run git reset --hard 4d33b7443b514acefe40a0a30bacb39bb0932690
In dir ant-design, run npm install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
Back in the initial folder, download RepoResults1/ant-design.ant-design.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./ant-design ./ant-design.ant-design.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

felixrieseberg/windows95

⚠️ Note that built also had errors ⚠️

Req #1053 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-main/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:161983:16)

Req #1053 - references
    at formatMessage2 (/typescript-51720/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-51720/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-51720/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-51720/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-51720/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-51720/built/local/tsserver.js:161983:16)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/felixrieseberg.windows95.rawError.txt in the artifact folder

Last few requests

{"seq":1050,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":355160,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":1051,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":355160,"entryNames":["_"]}}
{"seq":1052,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":355167}}
{"seq":1053,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":358092}}

Repro Steps

git clone https://github.com/felixrieseberg/windows95 --recurse-submodules
In dir windows95, run git reset --hard 17a81393467e2668eb2eea291ab4b6a749756dad
In dir windows95, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/felixrieseberg.windows95.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./windows95 ./felixrieseberg.windows95.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors ⚠️

Req #12877 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-main/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:161983:16)

Req #12877 - references
    at formatMessage2 (/typescript-51720/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-51720/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-51720/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-51720/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-51720/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-51720/built/local/tsserver.js:161983:16)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

{"seq":12874,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":356179,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":12875,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":356179,"entryNames":["_"]}}
{"seq":12876,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":357151,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":"."}}
{"seq":12877,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":358467}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dir blueprint, run git reset --hard 3bfc3f1e9a9b4e0716ed58d6ba20f4786b564057
In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

vercel/hyper

⚠️ Note that built also had errors ⚠️

Req #12538 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-main/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:161983:16)

Req #12538 - references
    at formatMessage2 (/typescript-51720/built/local/tsserver.js:157806:23)
    at IOSession.writeMessage (/typescript-51720/built/local/tsserver.js:158813:23)
    at IOSession.send (/typescript-51720/built/local/tsserver.js:158810:12)
    at IOSession.doOutput (/typescript-51720/built/local/tsserver.js:158857:12)
    at IOSession.onMessage (/typescript-51720/built/local/tsserver.js:160461:16)
    at Interface.<anonymous> (/typescript-51720/built/local/tsserver.js:161983:16)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/vercel.hyper.rawError.txt in the artifact folder

Last few requests

{"seq":12535,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":8877,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":"."}}
{"seq":12536,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":9349}}
{"seq":12537,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":9594,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":"\""}}
{"seq":12538,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":9866}}

Repro Steps

git clone https://github.com/vercel/hyper --recurse-submodules
In dir hyper, run git reset --hard 50b0b61ddd5a1ea5eb3c7a054e2600d9f4ae9693
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir hyper/app, run yarn install --ignore-engines --ignore-scripts --silent
2. In dir hyper, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults1/vercel.hyper.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./hyper ./vercel.hyper.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

ahejlsberg · 2022-12-05T19:51:46Z

Tests and perf look good. Merging now.

ahejlsberg added 3 commits December 1, 2022 15:24

Fix narrowing by typeof applied to discriminant property

40bbce3

Include effects of getReferenceCandidate

0685cd8

Add tests

acfc111

typescript-bot assigned ahejlsberg Dec 2, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 2, 2022

ahejlsberg requested review from sandersn and weswigham December 2, 2022 00:04

Andarist reviewed Dec 2, 2022

View reviewed changes

DanielRosenwasser approved these changes Dec 2, 2022

View reviewed changes

ahejlsberg merged commit c07f512 into main Dec 5, 2022

ahejlsberg deleted the fix51700 branch December 5, 2022 19:51

Andarist mentioned this pull request Dec 6, 2022

Add a regression test for discriminating property access in parenthesized expression #51778

Closed

wbt mentioned this pull request Jan 26, 2023

typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes #52440

Closed

Fix narrowing by typeof applied to discriminant property #51720

Fix narrowing by typeof applied to discriminant property #51720

Uh oh!

Conversation

ahejlsberg commented Dec 2, 2022

Uh oh!

Andarist left a comment

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser commented Dec 2, 2022

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2022

Uh oh!

typescript-bot commented Dec 2, 2022

Uh oh!

typescript-bot commented Dec 2, 2022

Uh oh!

typescript-bot commented Dec 2, 2022

Uh oh!

typescript-bot commented Dec 3, 2022

Uh oh!

typescript-bot commented Dec 3, 2022

ant-design/ant-design

Last few requests

Repro Steps

felixrieseberg/windows95

Last few requests

Repro Steps

palantir/blueprint

Last few requests

Repro Steps

vercel/hyper

Last few requests

Repro Steps

Uh oh!

ahejlsberg commented Dec 5, 2022

Uh oh!

Uh oh!

Fix narrowing by `typeof` applied to discriminant property #51720

Fix narrowing by `typeof` applied to discriminant property #51720

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading

typescript-bot commented Dec 2, 2022 •

edited

Loading