Revert structuredTypeRelatedTo change and fix isUnitLikeType #51076

ahejlsberg · 2022-10-05T20:46:11Z

ahejlsberg · 2022-10-05T20:48:35Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2022-10-05T20:48:38Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at e363198. You can monitor the build here.

typescript-bot · 2022-10-05T20:48:38Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at e363198. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-05T20:48:38Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at e363198. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-05T20:48:38Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at e363198. You can monitor the build here.

typescript-bot · 2022-10-05T20:48:38Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at e363198. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-05T21:03:54Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/51076/merge:

Something interesting changed - please have a look.

Details

puppeteer

tsconfig.base.json

[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/commitlint.config.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/docker/test/smoke-test.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/block-images.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/cross-browser.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/custom-event.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/detect-sniff.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/oopif.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/pdf.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/proxy.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/screenshot-fullpage.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/screenshot.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/search.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/compat.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/compat.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/third_party/mitt/index.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/third_party/mitt/index.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/puppeteer/compat.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/puppeteer/compat.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/third_party/mitt/index.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/third_party/mitt/index.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/rollup.third_party.config.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer/install.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/testserver/lib/index.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/testserver/lib/index.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6import.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6module.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6pathimport.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/frames/script.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/initiator.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/injectedfile.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/input/mouse-helper.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/jscoverage/script1.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/jscoverage/script2.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/modernizr.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/empty/sw.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/extension/background.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/fetch/sw.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/simple-extension/content-script.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/simple-extension/index.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/worker/worker.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/fixtures/closeme.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/fixtures/dumpio.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/bisect.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/check_availability.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/generate-matrix.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/get_deprecated_version_range.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/interface.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/interface.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/main.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/main.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/reporter.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/reporter.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/test.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/test.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/types.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/types.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/utils.d.ts' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/utils.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/remove_version_suffix.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/versions.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/archive.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/babel.config.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/docusaurus.config.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json
[MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/static/sw.js' because it would overwrite input file.
- Project Scope in tsconfig.base.json

typescript-bot · 2022-10-05T21:05:11Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2022-10-05T21:31:18Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51076

_Metric	_main	₅₁₀₇₆	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{346,862k (± 0.01%)}	_{346,890k (± 0.01%)}	_{+28k (+ 0.01%)}	_346,832k	_346,977k
_{Parse Time}	_{2.08s (± 0.81%)}	_{2.12s (± 0.95%)}	_{+0.04s (+ 1.92%)}	_2.07s	_2.15s
_{Bind Time}	_{0.80s (± 0.43%)}	_{0.79s (± 0.75%)}	_{-0.00s (- 0.38%)}	_0.78s	_0.81s
_{Check Time}	_{5.95s (± 0.49%)}	_{5.95s (± 0.56%)}	_{+0.00s (+ 0.07%)}	_5.91s	_6.06s
_{Emit Time}	_{6.26s (± 0.60%)}	_{6.24s (± 0.63%)}	_{-0.02s (- 0.32%)}	_6.17s	_6.35s
_{Total Time}	_{15.08s (± 0.37%)}	_{15.10s (± 0.28%)}	_{+0.02s (+ 0.15%)}	_15.01s	_15.19s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,198k (± 0.01%)}	_{190,166k (± 0.01%)}	_{-32k (- 0.02%)}	_190,103k	_190,218k
_{Parse Time}	_{0.86s (± 0.69%)}	_{0.86s (± 1.05%)}	_{+0.01s (+ 0.58%)}	_0.84s	_0.88s
_{Bind Time}	_{0.49s (± 0.70%)}	_{0.49s (± 0.77%)}	_{-0.00s (- 0.41%)}	_0.48s	_0.49s
_{Check Time}	_{6.72s (± 0.58%)}	_{6.74s (± 0.45%)}	_{+0.01s (+ 0.22%)}	_6.69s	_6.82s
_{Emit Time}	_{2.40s (± 0.62%)}	_{2.39s (± 0.39%)}	_{-0.02s (- 0.62%)}	_2.37s	_2.41s
_{Total Time}	_{10.47s (± 0.44%)}	_{10.47s (± 0.34%)}	_{+0.00s (+ 0.04%)}	_10.42s	_10.56s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,591k (± 0.01%)}	_{326,583k (± 0.01%)}	_{-8k (- 0.00%)}	_326,519k	_326,626k
_{Parse Time}	_{1.59s (± 0.70%)}	_{1.58s (± 0.41%)}	_{-0.00s (- 0.19%)}	_1.57s	_1.59s
_{Bind Time}	_{0.73s (± 0.89%)}	_{0.73s (± 0.61%)}	_{+0.00s (+ 0.55%)}	_0.72s	_0.74s
_{Check Time}	_{5.74s (± 0.55%)}	_{5.75s (± 0.51%)}	_{+0.02s (+ 0.26%)}	_5.70s	_5.82s
_{Emit Time}	_{3.38s (± 0.89%)}	_{3.36s (± 0.63%)}	_{-0.02s (- 0.62%)}	_3.31s	_3.40s
_{Total Time}	_{11.43s (± 0.48%)}	_{11.43s (± 0.37%)}	_{-0.00s (- 0.03%)}	_11.35s	_11.54s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,716k (± 0.01%)}	_{289,704k (± 0.00%)}	_{-12k (- 0.00%)}	_289,677k	_289,735k
_{Parse Time}	_{1.30s (± 0.77%)}	_{1.30s (± 0.63%)}	_{-0.00s (- 0.23%)}	_1.28s	_1.31s
_{Bind Time}	_{0.79s (± 1.45%)}	_{0.79s (± 0.43%)}	_{0.00s ( 0.00%)}	_0.79s	_0.80s
_{Check Time}	_{5.40s (± 0.54%)}	_{5.40s (± 0.50%)}	_{-0.00s (- 0.02%)}	_5.33s	_5.46s
_{Emit Time}	_{3.61s (± 0.40%)}	_{3.60s (± 0.73%)}	_{-0.01s (- 0.28%)}	_3.55s	_3.67s
_{Total Time}	_{11.10s (± 0.41%)}	_{11.09s (± 0.33%)}	_{-0.01s (- 0.08%)}	_11.02s	_11.16s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{435,481k (± 0.07%)}	_{435,673k (± 0.01%)}	_{+192k (+ 0.04%)}	_435,609k	_435,727k
_{Parse Time}	_{1.89s (± 0.47%)}	_{1.88s (± 0.84%)}	_{-0.01s (- 0.27%)}	_1.86s	_1.93s
_{Bind Time}	_{0.58s (± 1.02%)}	_{0.58s (± 0.58%)}	_{-0.00s (- 0.34%)}	_0.58s	_0.59s
_{Check Time}	_{12.93s (± 0.84%)}	_{12.91s (± 0.66%)}	_{-0.02s (- 0.13%)}	_12.75s	_13.11s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.40s (± 0.70%)}	_{15.37s (± 0.60%)}	_{-0.03s (- 0.17%)}	_15.19s	_15.55s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{544,085k (± 0.00%)}	_{544,074k (± 0.00%)}	_{-11k (- 0.00%)}	_544,022k	_544,123k
_{Parse Time}	_{2.61s (± 0.31%)}	_{2.62s (± 0.37%)}	_{+0.01s (+ 0.42%)}	_2.60s	_2.64s
_{Bind Time}	_{0.98s (± 0.96%)}	_{0.97s (± 0.62%)}	_{-0.01s (- 1.13%)}	_0.95s	_0.98s
_{Check Time}	_{1.52s (± 0.51%)}	_{1.51s (± 0.45%)}	_{-0.01s (- 0.39%)}	_1.50s	_1.53s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.19s (± 0.25%)}	_{5.18s (± 0.27%)}	_{-0.01s (- 0.17%)}	_5.15s	_5.20s
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{371,315k (± 0.02%)}	_{371,366k (± 0.03%)}	_{+51k (+ 0.01%)}	_371,238k	_371,681k
_{Parse Time}	_{2.09s (± 0.55%)}	_{2.09s (± 0.84%)}	_{-0.01s (- 0.29%)}	_2.06s	_2.14s
_{Bind Time}	_{0.78s (± 0.83%)}	_{0.79s (± 1.18%)}	_{+0.01s (+ 0.77%)}	_0.77s	_0.82s
_{Check Time}	_{6.30s (± 0.42%)}	_{6.29s (± 0.45%)}	_{-0.01s (- 0.10%)}	_6.25s	_6.38s
_{Emit Time}	_{6.09s (± 0.49%)}	_{6.06s (± 0.65%)}	_{-0.02s (- 0.39%)}	_6.00s	_6.15s
_{Total Time}	_{15.26s (± 0.32%)}	_{15.23s (± 0.46%)}	_{-0.03s (- 0.22%)}	_15.12s	_15.39s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{206,323k (± 0.04%)}	_{206,340k (± 0.03%)}	_{+17k (+ 0.01%)}	_206,129k	_206,456k
_{Parse Time}	_{0.84s (± 0.95%)}	_{0.84s (± 0.87%)}	_{-0.00s (- 0.48%)}	_0.82s	_0.85s
_{Bind Time}	_{0.47s (± 1.00%)}	_{0.47s (± 1.00%)}	_{+0.00s (+ 0.00%)}	_0.46s	_0.48s
_{Check Time}	_{8.47s (± 0.49%)}	_{8.45s (± 0.59%)}	_{-0.02s (- 0.22%)}	_8.30s	_8.55s
_{Emit Time}	_{2.47s (± 1.90%)}	_{2.47s (± 1.27%)}	_{-0.00s (- 0.08%)}	_2.38s	_2.53s
_{Total Time}	_{12.25s (± 0.60%)}	_{12.23s (± 0.43%)}	_{-0.02s (- 0.20%)}	_12.11s	_12.33s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{344,850k (± 0.02%)}	_{344,829k (± 0.02%)}	_{-22k (- 0.01%)}	_344,704k	_344,958k
_{Parse Time}	_{1.61s (± 0.51%)}	_{1.60s (± 0.81%)}	_{-0.00s (- 0.06%)}	_1.56s	_1.63s
_{Bind Time}	_{0.70s (± 0.57%)}	_{0.71s (± 1.26%)}	_{+0.01s (+ 0.71%)}	_0.70s	_0.74s
_{Check Time}	_{6.23s (± 0.51%)}	_{6.21s (± 0.65%)}	_{-0.02s (- 0.37%)}	_6.12s	_6.30s
_{Emit Time}	_{3.25s (± 0.71%)}	_{3.25s (± 1.35%)}	_{-0.00s (- 0.15%)}	_3.17s	_3.39s
_{Total Time}	_{11.79s (± 0.38%)}	_{11.76s (± 0.47%)}	_{-0.02s (- 0.17%)}	_11.64s	_11.88s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{306,092k (± 0.03%)}	_{306,067k (± 0.02%)}	_{-25k (- 0.01%)}	_305,914k	_306,264k
_{Parse Time}	_{1.29s (± 0.54%)}	_{1.30s (± 0.81%)}	_{+0.01s (+ 0.46%)}	_1.27s	_1.32s
_{Bind Time}	_{0.67s (± 0.60%)}	_{0.68s (± 0.54%)}	_{+0.00s (+ 0.75%)}	_0.67s	_0.68s
_{Check Time}	_{5.52s (± 0.58%)}	_{5.50s (± 0.58%)}	_{-0.02s (- 0.33%)}	_5.43s	_5.57s
_{Emit Time}	_{3.43s (± 1.06%)}	_{3.43s (± 1.51%)}	_{-0.00s (- 0.12%)}	_3.32s	_3.53s
_{Total Time}	_{10.91s (± 0.56%)}	_{10.89s (± 0.51%)}	_{-0.02s (- 0.16%)}	_10.76s	_11.01s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{458,135k (± 0.01%)}	_{458,166k (± 0.02%)}	_{+30k (+ 0.01%)}	_458,010k	_458,405k
_{Parse Time}	_{1.82s (± 0.88%)}	_{1.84s (± 0.72%)}	_{+0.01s (+ 0.82%)}	_1.81s	_1.87s
_{Bind Time}	_{0.58s (± 2.06%)}	_{0.57s (± 1.89%)}	_{-0.01s (- 1.56%)}	_0.55s	_0.59s
_{Check Time}	_{15.69s (± 0.94%)}	_{15.54s (± 0.50%)}	_{-0.15s (- 0.96%)}	_15.39s	_15.74s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.09s (± 0.84%)}	_{17.95s (± 0.44%)}	_{-0.14s (- 0.79%)}	_17.79s	_18.14s
_{xstate - node (v10.16.3, x64)}
_{Memory used}	_{581,111k (± 0.01%)}	_{581,032k (± 0.01%)}	_{-78k (- 0.01%)}	_580,896k	_581,186k
_{Parse Time}	_{2.61s (± 0.52%)}	_{2.60s (± 0.29%)}	_{-0.01s (- 0.23%)}	_2.59s	_2.62s
_{Bind Time}	_{0.90s (± 0.62%)}	_{0.90s (± 0.78%)}	_{-0.00s (- 0.33%)}	_0.89s	_0.92s
_{Check Time}	_{1.60s (± 0.42%)}	_{1.61s (± 0.62%)}	_{+0.01s (+ 0.63%)}	_1.59s	_1.64s
_{Emit Time}	_{0.07s (± 4.13%)}	_{0.07s (± 4.13%)}	_{0.00s ( 0.00%)}	_0.07s	_0.08s
_{Total Time}	_{5.19s (± 0.39%)}	_{5.19s (± 0.27%)}	_{+0.00s (+ 0.04%)}	_5.16s	_5.23s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{348,864k (± 0.02%)}	_{348,564k (± 0.10%)}	_{-300k (- 0.09%)}	_347,606k	_348,862k
_{Parse Time}	_{2.10s (± 0.45%)}	_{2.10s (± 0.57%)}	_{+0.00s (+ 0.19%)}	_2.07s	_2.13s
_{Bind Time}	_{0.77s (± 0.68%)}	_{0.76s (± 0.65%)}	_{-0.00s (- 0.52%)}	_0.76s	_0.78s
_{Check Time}	_{5.95s (± 0.42%)}	_{5.99s (± 0.76%)}	_{+0.04s (+ 0.60%)}	_5.88s	_6.09s
_{Emit Time}	_{6.32s (± 0.80%)}	_{6.33s (± 0.83%)}	_{+0.01s (+ 0.13%)}	_6.24s	_6.46s
_{Total Time}	_{15.14s (± 0.40%)}	_{15.19s (± 0.58%)}	_{+0.05s (+ 0.30%)}	_15.00s	_15.38s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{193,548k (± 0.28%)}	_{194,051k (± 0.14%)}	_{+503k (+ 0.26%)}	_193,380k	_194,449k
_{Parse Time}	_{0.84s (± 1.32%)}	_{0.83s (± 0.98%)}	_{-0.01s (- 0.84%)}	_0.81s	_0.85s
_{Bind Time}	_{0.47s (± 0.94%)}	_{0.47s (± 0.78%)}	_{+0.00s (+ 0.64%)}	_0.47s	_0.48s
_{Check Time}	_{6.72s (± 0.76%)}	_{6.75s (± 0.60%)}	_{+0.02s (+ 0.36%)}	_6.63s	_6.82s
_{Emit Time}	_{2.47s (± 1.12%)}	_{2.46s (± 1.19%)}	_{-0.01s (- 0.20%)}	_2.42s	_2.53s
_{Total Time}	_{10.50s (± 0.65%)}	_{10.51s (± 0.46%)}	_{+0.01s (+ 0.12%)}	_10.43s	_10.62s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{327,799k (± 0.02%)}	_{327,825k (± 0.01%)}	_{+26k (+ 0.01%)}	_327,723k	_327,921k
_{Parse Time}	_{1.59s (± 0.96%)}	_{1.60s (± 0.97%)}	_{+0.01s (+ 0.76%)}	_1.57s	_1.64s
_{Bind Time}	_{0.69s (± 0.86%)}	_{0.70s (± 0.92%)}	_{+0.01s (+ 1.01%)}	_0.69s	_0.72s
_{Check Time}	_{5.83s (± 0.33%)}	_{5.86s (± 0.33%)}	_{+0.03s (+ 0.45%)}	_5.82s	_5.90s
_{Emit Time}	_{3.32s (± 0.57%)}	_{3.35s (± 0.68%)}	_{+0.03s (+ 0.81%)}	_3.28s	_3.39s
_{Total Time}	_{11.44s (± 0.27%)}	_{11.51s (± 0.20%)}	_{+0.07s (+ 0.65%)}	_11.46s	_11.55s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{290,711k (± 0.07%)}	_{290,714k (± 0.03%)}	_{+3k (+ 0.00%)}	_290,519k	_291,008k
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.29s (± 0.38%)}	_{-0.01s (- 0.69%)}	_1.28s	_1.30s
_{Bind Time}	_{0.68s (± 0.85%)}	_{0.68s (± 1.07%)}	_{-0.01s (- 0.73%)}	_0.66s	_0.69s
_{Check Time}	_{5.43s (± 0.58%)}	_{5.38s (± 0.47%)}	_{-0.04s (- 0.77%)}	_5.34s	_5.46s
_{Emit Time}	_{3.51s (± 1.06%)}	_{3.55s (± 0.92%)}	_{+0.04s (+ 1.23%)}	_3.49s	_3.63s
_{Total Time}	_{10.92s (± 0.52%)}	_{10.90s (± 0.37%)}	_{-0.01s (- 0.13%)}	_10.84s	_10.99s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{437,443k (± 0.01%)}	_{437,477k (± 0.01%)}	_{+34k (+ 0.01%)}	_437,360k	_437,571k
_{Parse Time}	_{1.84s (± 0.68%)}	_{1.84s (± 0.58%)}	_{+0.00s (+ 0.16%)}	_1.81s	_1.86s
_{Bind Time}	_{0.55s (± 1.17%)}	_{0.55s (± 0.81%)}	_{-0.00s (- 0.72%)}	_0.54s	_0.56s
_{Check Time}	_{12.76s (± 0.69%)}	_{12.80s (± 0.83%)}	_{+0.04s (+ 0.28%)}	_12.65s	_13.10s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.15s (± 0.62%)}	_{15.19s (± 0.76%)}	_{+0.04s (+ 0.23%)}	_15.04s	_15.51s
_{xstate - node (v12.1.0, x64)}
_{Memory used}	_{546,416k (± 0.02%)}	_{546,390k (± 0.02%)}	_{-26k (- 0.00%)}	_546,228k	_546,587k
_{Parse Time}	_{2.57s (± 0.75%)}	_{2.55s (± 0.43%)}	_{-0.02s (- 0.93%)}	_2.53s	_2.58s
_{Bind Time}	_{0.89s (± 1.02%)}	_{0.88s (± 0.41%)}	_{-0.00s (- 0.56%)}	_0.88s	_0.89s
_{Check Time}	_{1.50s (± 0.64%)}	_{1.49s (± 0.51%)}	_{-0.01s (- 0.93%)}	_1.47s	_1.50s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.03s (± 0.70%)}	_{4.99s (± 0.33%)}	_{-0.04s (- 0.86%)}	_4.96s	_5.03s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)
node (v10.16.3, x64)
node (v12.1.0, x64)

Scenarios

Angular - node (v14.15.1, x64)
Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
xstate - node (v14.15.1, x64)
xstate - node (v10.16.3, x64)
xstate - node (v12.1.0, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₀₇₆	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-10-05T22:01:40Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/51076/merge:

Everything looks good!

Andarist · 2022-10-05T22:26:05Z

tests/cases/conformance/types/unknown/unknownControlFlow.ts

+type R2<T extends PropertyKey> =
+    T extends keyof TypeA ?
+    T extends keyof TypeB ?
+        [TypeA[T], TypeB[T]] : never: never


nit:

Suggested change

[TypeA[T], TypeB[T]] : never: never

[TypeA[T], TypeB[T]] : never : never

note that accepting this would require regenerating the baselines

amcasey · 2022-10-06T01:02:53Z

@typescript-bot user test this
@typescript-bot test top100

typescript-bot · 2022-10-06T01:03:15Z

Heya @amcasey, I've started to run the diff-based user code test suite on this PR at e363198. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-06T01:03:15Z

Heya @amcasey, I've started to run the diff-based top-repos suite on this PR at e363198. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-06T01:16:31Z

@amcasey Here are the results of running the user test suite comparing main and refs/pull/51076/merge:

Everything looks good!

typescript-bot · 2022-10-06T02:22:14Z

@amcasey Here are the results of running the top-repos suite comparing main and refs/pull/51076/merge:

Everything looks good!

# Conflicts: # src/compiler/checker.ts

DanielRosenwasser · 2022-10-18T19:19:43Z

tests/cases/conformance/types/unknown/unknownControlFlow.ts

+
+type AB = "A" | "B";
+
+function x<T_AB extends AB>(x: T_AB & undefined, y: any) {


I think the change itself probably makes sense - but why is this test in unknownControlFlow.ts? It doesn't seem related to control flow and it doesn't use unknown anywhere.

It was a regression caused by #50735, so I added it in the same location as the tests for that PR.

@DanielRosenwasser Otherwise good with this? I'd like to get it merged.

Seems like if you could move it, that would be ideal - other than that, the change looks reasonable to me.

ahejlsberg added 3 commits October 5, 2022 13:38

Revert structuredTypeRelatedTo change, fix isUnitLikeType

8ff245f

Accept new baselines

8fd5e4c

Add regression tests

e363198

typescript-bot assigned ahejlsberg Oct 5, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 5, 2022

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh October 5, 2022 20:46

Andarist reviewed Oct 5, 2022

View reviewed changes

amcasey mentioned this pull request Oct 6, 2022

Fix filtering of TS5055 microsoft/typescript-error-deltas#81

Merged

ahejlsberg added 2 commits October 18, 2022 07:34

Merge branch 'main' into fix51009

068d3de

# Conflicts: # src/compiler/checker.ts

Fix formatting in test

8047229

DanielRosenwasser reviewed Oct 18, 2022

View reviewed changes

DanielRosenwasser approved these changes Oct 19, 2022

View reviewed changes

ahejlsberg merged commit 906ebe4 into main Oct 19, 2022

ahejlsberg deleted the fix51009 branch October 19, 2022 22:46

ahejlsberg mentioned this pull request Nov 16, 2022

[4.9.2-rc regression] if/else narrowing with a branded string discriminant no longer eliminates matched constituents in later branches #51538

Closed

ahejlsberg mentioned this pull request Nov 30, 2022

Fix isUnitLikeType to (again) handle tagged literal types #51545

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

	[TypeA[T], TypeB[T]] : never: never
	[TypeA[T], TypeB[T]] : never : never


		type AB = "A" \| "B";

		function x<T_AB extends AB>(x: T_AB & undefined, y: any) {

Revert structuredTypeRelatedTo change and fix isUnitLikeType #51076

Revert structuredTypeRelatedTo change and fix isUnitLikeType #51076

Uh oh!

Conversation

ahejlsberg commented Oct 5, 2022 • edited by DanielRosenwasser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Oct 5, 2022

Uh oh!

typescript-bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 5, 2022

puppeteer

tsconfig.base.json

Uh oh!

typescript-bot commented Oct 5, 2022

Uh oh!

typescript-bot commented Oct 5, 2022

Uh oh!

typescript-bot commented Oct 5, 2022

Uh oh!

Andarist Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

amcasey commented Oct 6, 2022

Uh oh!

typescript-bot commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 6, 2022

Uh oh!

typescript-bot commented Oct 6, 2022

Uh oh!

DanielRosenwasser Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ahejlsberg commented Oct 5, 2022 •

edited by DanielRosenwasser

Loading

typescript-bot commented Oct 5, 2022 •

edited

Loading

typescript-bot commented Oct 5, 2022 •

edited

Loading

typescript-bot commented Oct 5, 2022 •

edited

Loading

typescript-bot commented Oct 5, 2022 •

edited

Loading

typescript-bot commented Oct 5, 2022 •

edited

Loading

typescript-bot commented Oct 6, 2022 •

edited

Loading

typescript-bot commented Oct 6, 2022 •

edited

Loading

DanielRosenwasser Oct 18, 2022 •

edited

Loading