Skip to content

Make the importServicePlugin internal#50572

Closed
sheetalkamat wants to merge 1 commit intomainfrom
makeDynamicImportApiInternal
Closed

Make the importServicePlugin internal#50572
sheetalkamat wants to merge 1 commit intomainfrom
makeDynamicImportApiInternal

Conversation

@sheetalkamat
Copy link
Member

No description provided.

@sheetalkamat sheetalkamat requested review from DanielRosenwasser, andrewbranch, mjbvz and rbuckton and removed request for mjbvz and rbuckton August 31, 2022 17:30
@sheetalkamat
Copy link
Member Author

If we are not taking #50554 we should definitely take this for 4.8 so we have some wiggle room to name API for figuring out custom watch plugin story from tsc as well as editor

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 31, 2022

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.8 on this PR at 5e96e58. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #50573 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 31, 2022
Component commits:
5e96e58 Lets make the importServicePlugin internal for now?
@sheetalkamat
Copy link
Member Author

Closing this as we agreed to take both changes

@sheetalkamat sheetalkamat deleted the makeDynamicImportApiInternal branch August 31, 2022 19:00
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants