Split CI linting/playwright out into separate jobs #50406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting and playwright are unaffected by the node version; split these out into separate jobs, which should speed things up.
While I'm here, remove the tsc matcher; the PR linked in the comment was merged almost a year ago and is already active in setup-node.
Also unset
fetch-depth, which then defaults us to a shallow clone. As far as I can tell, this has been set to5since #34614 (the PR that added GHA), but there's no rationale as to why 5 commits was chosen. At the time, thetravis.ymlfile was also a shallow clone. This workflow doesn't care about the git history at all, unlike some other workflows like the bisecter.