fix(49149): remove unneeded array overload to Object.freeze #50029
Conversation
|
You just need to commit the baseline changes, assuming they look ok. If you’re not sure if they look ok, commit them anyway so we can take a look. |
|
Thanks for that pointer! I'll take a look at those baselines and commit them (i might throw some questions in there if i have any i cant figure out). |
|
Chances are most/all of them are just position changes of symbols defined after Object.freeze in lib.es5.d.ts since they will have moved up a few lines. |
|
|
|
@typescript-bot test this |
|
Heya @andrewbranch, I've started to run the extended test suite on this PR at 646193b. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 646193b. You can monitor the build here. Update: The results are in! |
|
Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 646193b. You can monitor the build here. |
|
Heya @andrewbranch, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@andrewbranch |
|
The TypeScript team hasn't accepted the linked issue #49149. If you can get it accepted, this PR will have a better chance of being reviewed. |
|
@DanielRosenwasser I’m fairly convinced this is right, but maybe we should plan to merge this for 4.9? |
|
Early 4.9 seems appropriate. |
DanielRosenwasser
added
the
Merge/Review for Next Release
|
Thanks @nicolas377! |
|
Very nice 👍 |
Fixes #49149