Fixed outdated expectation comments #49691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Jun 27, 2022
| // @declaration: true | ||
|
|
||
| function ft1<T extends string>(s: string, n: number, u: 'foo' | 'bar' | 'baz', t: T) { | ||
| const c1 = `abc${s}`; // `abc${string}` |
Contributor
Author
There was a problem hiding this comment.
those tests and comments were introduced in https://github.com/microsoft/TypeScript/pull/41891/files#diff-23c99a459cde66a01fe87782c5d76a17b3c75706ad05adc1567eff86995b89e2 but then the change was reverted without removing tests (or adjusting those original comments) here: #42588
aroramrinaal
approved these changes
Jun 30, 2022
sandersn
approved these changes
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.