Skip to content

Conversation

@jakebailey
Copy link
Member

Fixes #48636

Big thanks to @weswigham for sitting with me for 2 hours to debug this.

I couldn't move the caching code from resolvedSignature down into resolveCall; getResolvedSignature conditionally sets resolvedSignature before calling resolveSignature, and resolveSignature then calls a bunch of other functions which do other things before actually resolving the signature. If I move this caching downward where it seems like it should be, I break enough tests to crash the test host.

@jakebailey jakebailey requested review from sandersn and weswigham June 18, 2022 00:22
@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 18, 2022
@jakebailey
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 20, 2022

Heya @jakebailey, I've started to run the extended test suite on this PR at a65ebb2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 20, 2022

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at a65ebb2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 20, 2022

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at a65ebb2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
Great news! no new errors were found between main..refs/pull/49598/merge

@typescript-bot
Copy link
Collaborator

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@jakebailey
Copy link
Member Author

RWC shows one change, and it looks to me like an extra error that shouldn't have been there in the first place (an assignment error where it complains both on the right side, then again on the left side about the same thing), so that seems good.

@jakebailey jakebailey merged commit 71b5bdf into microsoft:main Jun 21, 2022
@jakebailey jakebailey deleted the fix-48636 branch June 21, 2022 20:15
Copy link

@nievesmiguel nievesmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug Failure. No error for last overload signature

5 participants