Update all depedencies, including ESLint 8, refresh lockfile #49550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
amcasey
approved these changes
Jun 16, 2022
At worst, we'll just drift back to less-than-minimal in time, which is fine. We can just do this again when it starts to look hairy. The nightly task shouldn't undo anything in this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since this has been done wholesale; we're on an old version of ESLint, and all of the
npm installside-effect based updates have not kept the lockfile minimal.Upgrade everything via
ncu(with some exceptions for ESM-only packages, and TS itself which is another problem), then remove the lockfile and reinstall.It looks like ESLint's definition of camelCase was changed at some point; I had to add an exception for the newly-added methods that are just numbers for the changes introduced in the modifier AST merge PR.