Fix crash from inaccurate type guard implementation#49252
Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom May 26, 2022
Merged
Fix crash from inaccurate type guard implementation#49252andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch merged 2 commits intomicrosoft:mainfrom
Conversation
…ng true on binding elements
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
commented
May 25, 2022
Comment on lines
-2200
to
-2202
| if (node.kind === SyntaxKind.BindingElement) { | ||
| node = node.parent.parent; | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the problem code; other changes are accounting for the deletion. The issue is that this function gets consumed exclusively by functions whose return type is a predicate of node being some sort of VariableDeclaration, so this defeats that type predicate.
Member
|
RyanCavanaugh
approved these changes
May 26, 2022
Member
Author
|
@typescript-bot cherry-pick this to release-4.7 |
Collaborator
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 26, 2022
Collaborator
|
Hey @andrewbranch, I've opened #49272 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 🙃 #49003 (comment)