Skip to content

Conversation

@punya
Copy link

@punya punya commented Sep 18, 2015

@msftclas
Copy link

Hi @punya, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@punya, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy mhegazy merged commit 55218d6 into microsoft:master Sep 21, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2015

thanks @punya for your PR. the files under lib are generated by the build form sources under src\lib and are not changed as part of PRs.

I have manually merged the change and update the generated files. also would appreciate it if you filed an issue along with the PR.

@punya
Copy link
Author

punya commented Sep 21, 2015

Thanks @mhegazy for fixing up the PR, I wasn't sure if the etiquette was to commit built files as part of the PR or not (this is my first contribution to TS, as you can see).

Would you like me to file an issue for this PR, or for future PRs?

@punya punya deleted the fix-capitalization branch September 21, 2015 12:57
@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2015

Let's do it for future ones. it is just for documentation purposes, so that in the release notes we have a list of all changes.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants