tsserver support for a virtual filesystem #48497

sandersn · 2022-03-31T15:46:00Z

I moved the virtual file system with watch code to a new project. The server now depends on this new project.
The test of the new server message still needs to move to a separate file.

Edit: Remaining work

Should the plugin system start providing a separate FileServerHost to plugins, or should it create a hybrid host that delegates to a fshost in case it's running in the browser?
The ATA installer assumes that it can run npm install on a local disk. It'll have to be substantially rewritten.
The message-based system won't scale very far -- I want to investigate @jakebailey 's idea for starting an in-browser server to let tsserver request files from vs code.

Partly fixes #47600 -- there is probably more work needed here and definitely in vs code.

Except for the new test I added.

I should have done this as two commits. Sorry.

I'm pretty sure I need to delete and re-number some of the rest though.

Plus fix associated mistakes in the code found by the test.

Shortly to be undone, but whatever.

Doesn't quite build yet, uploading so I can use github to view the diff.

But editorServices needs some fixes. At least, createDirectory needs a recursive version.

Next: Make a way to create a vfs server from the start.

typescript-bot · 2022-03-31T15:46:03Z

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

src/server/editorServices.ts

src/server/protocol.ts

src/harness/virtualFileSystemWithWatch.ts

src/testRunner/unittests/tsserver/applyChangesToOpenFiles.ts

tests/baselines/reference/types.asyncGenerators.es2018.2.errors.txt

src/tsserver/webServer.ts

src/vfs/tsconfig.json

I'm not sure why this fails locally, I suspect I need to `npm ci`.

This removes fshost usage in most places except for construction of objects.

Instead, pass in additional configuration from TestServerHost

1. Move VirtualServerHost code to correct vfs/harness location. 2. Serialise watch and timeout information. 3. Improve test by modifying an unopened file. 4. Test can run arbitrary actions in addition to commands.

src/server/project.ts

sheetalkamat · 2022-06-14T18:11:42Z

src/server/project.ts

                };
            }
-            return this.projectService.host;
+            return {


This change is not needed either ?

I put this here to provide a ModuleResolutionHost which uses the projectService's [fs]host for fileExists, directoryExists, realpath, useCaseSensitiveFileNames instead of this.program.fileExists/directoryExists/realpath/useCaseSensitiveFileNames. Maybe it's not needed? I don't know.

src/server/editorServices.ts

src/server/session.ts

src/server/types.ts

src/testRunner/tsconfig.json

src/webServer/tsconfig.json

src/tsserver/tsconfig.json

src/harness/virtualFileSystemWithWatch.ts

1. Reimplement recursive deleting in VirtualServerHost.deleteFile 2. Save a private fshost, then all VirtualServerHost methods directly. 3. Switch from asserts to logs when fshost isn't a valid VirtualServerHost.

src/harness/virtualFileSystemWithWatch.ts

src/server/editorServices.ts

src/harness/virtualFileSystemWithWatch.ts

sandersn · 2023-04-11T15:22:06Z

This is obsoleted by the virtual filesystem written by the vscode team, and the tsserver host that I wrote for vscode to use it.

jimkyndemeyer · 2023-04-12T05:58:28Z

This is obsoleted by the virtual filesystem written by the vscode team, and the tsserver host that I wrote for vscode to use it.

@sandersn can you provide links to both? Would be interesting to see how the solution was implemented. Thanks :)

sandersn · 2023-04-12T23:42:46Z

The tsserver host is in vscode's repo at extensions/typescript-language-features/web/tsServer.ts
The initial PR is microsoft/vscode#169311 -- it adds some filesystem packages whose source you can look up on github.

sandersn added 20 commits March 1, 2022 09:56

initial scribbles

da2622c

create vfs project

9e0e980

Everything builds and tests pass

eb22b4f

Except for the new test I added.

Split fakesHosts and some utils into vfs.

6afd939

I should have done this as two commits. Sorry.

Try to make test behave same as existing one

91f47f7

Test gets further than before

6224ddc

I'm pretty sure I need to delete and re-number some of the rest though.

Test is now passing

160490c

New test better tests UpdateFileSystem

287b6a5

Plus fix associated mistakes in the code found by the test.

try to add a step to test (it fails)

afecf63

Merge branch 'main' into server-vfs-support

587ac14

output vfs in tsserver.js

24a8ba4

Merge branch 'main' into server-vfs-support

c4eb15c

Copy file watching from virtualFileSystemWithWatch

85eee48

Shortly to be undone, but whatever.

Switch to virtualFileSystemWithWatch, move other files back

050e058

Doesn't quite build yet, uploading so I can use github to view the diff.

Tests build and run

978c0bc

But editorServices needs some fixes. At least, createDirectory needs a recursive version.

Tests pass again

a1b9983

Next: Make a way to create a vfs server from the start.

Merge branch 'main' into server-vfs-support

197308e

Add tsserver entrypoint for vfs

22c9470

fix lint

11717fe

clean up oodate TODOs

bb00916

typescript-bot assigned sandersn Mar 31, 2022

typescript-bot added the Author: Team label Mar 31, 2022

sandersn requested a review from sheetalkamat March 31, 2022 15:46

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 31, 2022

sandersn added 2 commits March 31, 2022 09:51

update cleaned-up API baseline

6f599af

Merge branch 'main' into server-vfs-support

73adea3

sheetalkamat requested changes Mar 31, 2022

View reviewed changes

sandersn added 2 commits March 31, 2022 14:12

Try manually reverting failing baseline

1488440

I'm not sure why this fails locally, I suspect I need to `npm ci`.

revert added newline from unix editor

f67ef37

sandersn added 7 commits June 7, 2022 16:12

remove newline from FileServerHost, undo RuntimeServerHost addition

a29c27c

Create composite host/fshost.

2ba27a5

This removes fshost usage in most places except for construction of objects.

Remove VirtualServerBastHost

8be58eb

Instead, pass in additional configuration from TestServerHost

move snap/diff out of tsserver

e23c64b

Merge branch 'main' into server-vfs-support

be91472

More PR comments

b31aaf3

1. Move VirtualServerHost code to correct vfs/harness location. 2. Serialise watch and timeout information. 3. Improve test by modifying an unopened file. 4. Test can run arbitrary actions in addition to commands.

Address remaining comments

32e4795

sheetalkamat requested changes Jun 14, 2022

View reviewed changes