Add assert
keyword in completions
#47644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46371
I added a new function,
getContextualKeywords
, that is called incompletionInfoFromData
.The alternative I've considered would be to use the existing
keywordFilter
mechanism, and have a new filter,KeywordFilter.Assert
. However, that felt odd and difficult to implement, becausekeywordFilter
is created ingetCompletionData
and assigned inside that function, and in other functions it calls, in multiple places. So it's (a) hard to follow all the conditionals and function calls that could assign tokeywordFilter
to make sure the variable ends up being assigned toKeywordFilter.Assert
in the right places, and (b) the existing conditionals didn't reflect the cases where we should offerassert
in completions.