Proposal: simplify auto import descriptions

[andrewbranch]

Compliments #47552 and makes progress on #47521.

Now, when a codefix will result in a new import declaration, the message is Add import from "foo". When adding an import to an existing import declaration, the message is Update import from "foo". The exception is when the thing being imported doesn’t share a name with the identifier that triggered the error—the only way this happens today is when you are prompted to import React (or whatever your JSX element factory is) on an arbitrary JSX element name. In that case, the message is Import 'React' from "react".

This change is based on two assumptions:

• You don’t need to see the name of the thing you’re importing repeated in the description because you’re fixing an error on that name or are in the process of typing that name.
• Nobody really cares whether the import is going to be a default import or named import.

[mjbvz]

The new wording makes sense to me. Thanks for taking a look!

[amcasey]

This is used for both add and update? Also, nitpicky, but why one set of single quotes and one set of double quotes?

[DanielRosenwasser]

I don't think I even see this message used the diff. Am I missing it?

[amcasey]

I missed it too - it's referred to by its property name in the tests.

[andrewbranch]

@amcasey yes, both add and update. We always use double quotes for module specifiers for some reason, and single quotes for other code quoting 🤷‍♂️

[DanielRosenwasser]

you too!

[andrewbranch]

I left it in for so long, never knowing what it was referencing.