Correctly check computed property names in type-space get/set accessors #47156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47146 (introduced by #42425 which enabled this syntax)
Previously this code ran without error:
because we incorrectly swallowed the errors in
checkComputedPropertyNameunder the assumption that we were looking at a{ [K in T]: U }declaration. The code path where the error would have been detected -- in the mapped checking logic -- obviously does not run because this is not actually a mapped type.Thankfully the computed type was completely useless (see comments in linked issue), so it isn't feasible that anyone took a dependency on this.