Improve isValidSpreadType check #47010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
approved these changes
Dec 3, 2021
| return !!(type.flags & (TypeFlags.Any | TypeFlags.NonPrimitive | TypeFlags.Object | TypeFlags.InstantiableNonPrimitive) || | ||
| getFalsyFlags(type) & TypeFlags.DefinitelyFalsy && isValidSpreadType(removeDefinitelyFalsyTypes(type)) || | ||
| type.flags & TypeFlags.UnionOrIntersection && every((type as UnionOrIntersectionType).types, isValidSpreadType)); | ||
| const t = removeDefinitelyFalsyTypes(mapType(type, getBaseConstraintOrType)); |
Member
There was a problem hiding this comment.
love that we have functions named getBaseConstraintOrType and getBaseConstraintOfType
| // no flags for all other types (including non-falsy literal types). | ||
| function getFalsyFlags(type: Type): TypeFlags { | ||
| return type.flags & TypeFlags.Union ? getFalsyFlagsOfTypes((type as UnionType).types) : | ||
| return type.flags & TypeFlags.UnionOrIntersection ? getFalsyFlagsOfTypes((type as UnionType).types) : |
Member
There was a problem hiding this comment.
I'm a little surprised that adding intersections to getFalsyFlags didn't change any existing baselines.
Member
Author
There was a problem hiding this comment.
Well, there are precious few intersections that would be affected, pretty much only those like T & undefined that will now appear to be falsy.
Member
|
Regression: #47028 (comment) |
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Fix getFalsyFlags for intersection types * Fix and simplify isValidSpreadType * Slight tweak * Add tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46976.