Skip to content

fix: do not use ts.NodeArray in factory inputs #46843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Nov 17, 2021

The other functions all accept readonly arrays and these ones should too.

createMappedTypeNode has actually been fixed since the 4.5.2 release, but not these other ones.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 17, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@sandersn sandersn merged commit 9218255 into microsoft:main Dec 9, 2021
@dsherret dsherret deleted the fix_do_not_use_node_array_factory_inputs branch December 9, 2021 02:07
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants