Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Contributor
|
Worth noting that "dom" lib was included by default when target was set to "es5" (because "lib" is commented out in tsc --init template). May no longer be the case with this change. |
Member
|
I would hope that |
Contributor
Author
|
This got OK'd at a design meeting 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES5 is a pretty low target, I doubt most folks making a new TypeScript project want something that old.
So, I propose we think of the default target in
--initas being "5 years" ago, and generally try to keep that in sync. E.g. sometime next year we'd accept a PR which sets it to be es2017.